From 48ac53628a75efb99bd5a261ab79fbc4a6b683c9 Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Mon, 9 Mar 2020 11:09:54 +0100 Subject: [PATCH] fix(examples): fix angular examples prod serve doesn't work on windows In Windows runfiles are not always available thus we need to use the real location using `rlocation`. Closes #1606 --- examples/angular/src/BUILD.bazel | 6 +++++- examples/angular_view_engine/src/BUILD.bazel | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/angular/src/BUILD.bazel b/examples/angular/src/BUILD.bazel index 036f3d7f4d..6c0458f8ff 100644 --- a/examples/angular/src/BUILD.bazel +++ b/examples/angular/src/BUILD.bazel @@ -207,9 +207,13 @@ history_server( # given folder this will result in the following auto-configuration: # /example => src/prodapp/example # / => src/prodapp + args = [ + "--port", + "4200", + ], templated_args = [ "-a", - "src/prodapp", + "$(rlocation examples_angular/src/prodapp)", ], ) diff --git a/examples/angular_view_engine/src/BUILD.bazel b/examples/angular_view_engine/src/BUILD.bazel index 853fac517b..e5748bd848 100644 --- a/examples/angular_view_engine/src/BUILD.bazel +++ b/examples/angular_view_engine/src/BUILD.bazel @@ -217,6 +217,6 @@ history_server( # / => src/prodapp templated_args = [ "-a", - "src/prodapp", + "$(rlocation examples_angular/src/prodapp)", ], )