From fb6d8c47379ce1c352efdf750d5de5412d5109db Mon Sep 17 00:00:00 2001 From: Chressie Himpel Date: Thu, 16 Dec 2021 13:29:41 +0100 Subject: [PATCH] Update x/tools repository to v0.1.8 #3030 Ran the following commands: bazel build go/tools/releaser sed -i /org_golang_x_tools-public-visibility.patch/d go/private/repositories.bzl rm third_party/org_golang_x_tools-public-visibility.patch bazel-bin/go/tools/releaser/releaser_/releaser upgrade-dep org_golang_x_tools --- go/private/repositories.bzl | 11 +- .../org_golang_x_tools-deletegopls.patch | 1139 +++++--- third_party/org_golang_x_tools-gazelle.patch | 2495 ++++++++++++----- ...org_golang_x_tools-public-visibility.patch | 21 - 4 files changed, 2433 insertions(+), 1233 deletions(-) delete mode 100644 third_party/org_golang_x_tools-public-visibility.patch diff --git a/go/private/repositories.bzl b/go/private/repositories.bzl index ea5fd1db5f..9d32871767 100644 --- a/go/private/repositories.bzl +++ b/go/private/repositories.bzl @@ -75,13 +75,13 @@ def go_rules_dependencies(is_rules_go = False): _maybe( http_archive, name = "org_golang_x_tools", - # v0.1.7, latest as of 2021-10-06 + # v0.1.8, latest as of 2021-12-15 urls = [ - "https://mirror.bazel.build/github.com/golang/tools/archive/v0.1.7.zip", - "https://github.com/golang/tools/archive/v0.1.7.zip", + "https://mirror.bazel.build/github.com/golang/tools/archive/v0.1.8.zip", + "https://github.com/golang/tools/archive/v0.1.8.zip", ], - sha256 = "c069fd1d1dcbbfd2e396993307adf0edde5ef5d419c5db92649ab8cfabec255e", - strip_prefix = "tools-0.1.7", + sha256 = "aec8a9ade0974bafc290bad1c53fa2b4d2b87ac8a90bf5340ded216ff81d1b2a", + strip_prefix = "tools-0.1.8", patches = [ # deletegopls removes the gopls subdirectory. It contains a nested # module with additional dependencies. It's not needed by rules_go. @@ -89,7 +89,6 @@ def go_rules_dependencies(is_rules_go = False): "@io_bazel_rules_go//third_party:org_golang_x_tools-deletegopls.patch", # releaser:patch-cmd gazelle -repo_root . -go_prefix golang.org/x/tools -go_naming_convention import_alias "@io_bazel_rules_go//third_party:org_golang_x_tools-gazelle.patch", - "@io_bazel_rules_go//third_party:org_golang_x_tools-public-visibility.patch", ], patch_args = ["-p1"], ) diff --git a/third_party/org_golang_x_tools-deletegopls.patch b/third_party/org_golang_x_tools-deletegopls.patch index e72ed2a626..bb37be625c 100644 --- a/third_party/org_golang_x_tools-deletegopls.patch +++ b/third_party/org_golang_x_tools-deletegopls.patch @@ -1,119 +1,7 @@ -diff -urN a/gopls/README.md b/gopls/README.md ---- a/gopls/README.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/README.md 1969-12-31 16:00:00.000000000 -0800 -@@ -1,108 +0,0 @@ --# `gopls`, the Go language server -- --[![PkgGoDev](https://pkg.go.dev/badge/golang.org/x/tools/gopls)](https://pkg.go.dev/golang.org/x/tools/gopls) -- --`gopls` (pronounced "Go please") is the official Go [language server] developed --by the Go team. It provides IDE features to any [LSP]-compatible editor. -- -- -- --You should not need to interact with `gopls` directly--it will be automatically --integrated into your editor. The specific features and settings vary slightly --by editor, so we recommend that you proceed to the [documentation for your --editor](#editors) below. -- --## Editors -- --To get started with `gopls`, install an LSP plugin in your editor of choice. -- --* [VSCode](https://github.com/golang/vscode-go/blob/master/README.md) --* [Vim / Neovim](doc/vim.md) --* [Emacs](doc/emacs.md) --* [Atom](https://github.com/MordFustang21/ide-gopls) --* [Sublime Text](doc/subl.md) --* [Acme](https://github.com/fhs/acme-lsp) -- --If you use `gopls` with an editor that is not on this list, please let us know --by [filing an issue](#new-issue) or [modifying this documentation](doc/contributing.md). -- --## Installation -- --For the most part, you should not need to install or update `gopls`. Your --editor should handle that step for you. -- --If you do want to get the latest stable version of `gopls`, change to any --directory that is both outside of your `GOPATH` and outside of a module (a temp --directory is fine), and run: -- --```sh --GO111MODULE=on go get golang.org/x/tools/gopls@latest --``` -- --**NOTE**: Do not use the `-u` flag, as it will update your dependencies to --incompatible versions. -- --Learn more in the [advanced installation --instructions](doc/advanced.md#installing-unreleased-versions). -- --## Setting up your workspace -- --`gopls` supports both Go module and GOPATH modes, but if you are working with --multiple modules or uncommon project layouts, you will need to specifically --configure your workspace. See the [Workspace document](doc/workspace.md) for --information on supported workspace layouts. -- --## Configuration -- --You can configure `gopls` to change your editor experience or view additional --debugging information. Configuration options will be made available by your --editor, so see your [editor's instructions](#editors) for specific details. A --full list of `gopls` settings can be found in the [Settings documentation](doc/settings.md). -- --### Environment variables -- --`gopls` inherits your editor's environment, so be aware of any environment --variables you configure. Some editors, such as VS Code, allow users to --selectively override the values of some environment variables. -- --## Troubleshooting -- --If you are having issues with `gopls`, please follow the steps described in the --[troubleshooting guide](doc/troubleshooting.md). -- --## Supported Go versions and build systems -- --`gopls` follows the [Go Release --Policy](https://golang.org/doc/devel/release.html#policy), meaning that it --officially supports the last 2 major Go releases. Per --[issue #39146](golang.org/issues/39146), we attempt to maintain best-effort --support for the last 4 major Go releases, but this support extends only to not --breaking the build and avoiding easily fixable regressions. -- --Our extended support is enforced via [continuous integration with older Go --versions](doc/contributing.md#ci). This legacy Go CI may not block releases: --test failures may be skipped rather than fixed. Furthermore, if a regression in --an older Go version causes irreconcilable CI failures, we may drop support for --that Go version in CI if it is 3 or 4 Go versions old. -- --`gopls` currently only supports the `go` command, so if you are using a --different build system, `gopls` will not work well. Bazel is not officially --supported, but Bazel support is in development (see --[bazelbuild/rules_go#512](https://github.com/bazelbuild/rules_go/issues/512)). --You can follow [these instructions](https://github.com/bazelbuild/rules_go/wiki/Editor-setup) --to configure your `gopls` to work with Bazel. -- --## Additional information -- --* [Features](doc/features.md) --* [Command-line interface](doc/command-line.md) --* [Advanced topics](doc/advanced.md) --* [Contributing to `gopls`](doc/contributing.md) --* [Integrating `gopls` with an editor](doc/design/integrating.md) --* [Design requirements and decisions](doc/design/design.md) --* [Implementation details](doc/design/implementation.md) --* [Open issues](https://github.com/golang/go/issues?q=is%3Aissue+is%3Aopen+label%3Agopls) -- --[language server]: https://langserver.org --[LSP]: https://microsoft.github.io/language-server-protocol/ --[Gophers Slack]: https://gophers.slack.com/ diff -urN a/gopls/api-diff/api_diff.go b/gopls/api-diff/api_diff.go ---- a/gopls/api-diff/api_diff.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/api-diff/api_diff.go 1969-12-31 16:00:00.000000000 -0800 -@@ -1,264 +0,0 @@ +--- a/gopls/api-diff/api_diff.go 2021-12-15 10:41:42.359936085 +0100 ++++ b/gopls/api-diff/api_diff.go 1970-01-01 01:00:00.000000000 +0100 +@@ -1,274 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. @@ -125,6 +13,7 @@ diff -urN a/gopls/api-diff/api_diff.go b/gopls/api-diff/api_diff.go - -import ( - "bytes" +- "context" - "encoding/json" - "flag" - "fmt" @@ -136,6 +25,7 @@ diff -urN a/gopls/api-diff/api_diff.go b/gopls/api-diff/api_diff.go - "path/filepath" - "strings" - +- "golang.org/x/tools/internal/gocommand" - difflib "golang.org/x/tools/internal/lsp/diff" - "golang.org/x/tools/internal/lsp/diff/myers" - "golang.org/x/tools/internal/lsp/source" @@ -164,18 +54,19 @@ diff -urN a/gopls/api-diff/api_diff.go b/gopls/api-diff/api_diff.go -} - -func diffAPI(version, prev string) (string, error) { -- previousApi, err := loadAPI(prev) +- ctx := context.Background() +- previousApi, err := loadAPI(ctx, prev) - if err != nil { -- return "", err +- return "", fmt.Errorf("load previous API: %v", err) - } - var currentApi *source.APIJSON - if version == "" { - currentApi = source.GeneratedAPIJSON - } else { - var err error -- currentApi, err = loadAPI(version) +- currentApi, err = loadAPI(ctx, version) - if err != nil { -- return "", err +- return "", fmt.Errorf("load current API: %v", err) - } - } - @@ -183,17 +74,17 @@ diff -urN a/gopls/api-diff/api_diff.go b/gopls/api-diff/api_diff.go - if err := diff(b, previousApi.Commands, currentApi.Commands, "command", func(c *source.CommandJSON) string { - return c.Command - }, diffCommands); err != nil { -- return "", err +- return "", fmt.Errorf("diff commands: %v", err) - } - if diff(b, previousApi.Analyzers, currentApi.Analyzers, "analyzer", func(a *source.AnalyzerJSON) string { - return a.Name - }, diffAnalyzers); err != nil { -- return "", err +- return "", fmt.Errorf("diff analyzers: %v", err) - } - if err := diff(b, previousApi.Lenses, currentApi.Lenses, "code lens", func(l *source.LensJSON) string { - return l.Lens - }, diffLenses); err != nil { -- return "", err +- return "", fmt.Errorf("diff lenses: %v", err) - } - for key, prev := range previousApi.Options { - current, ok := currentApi.Options[key] @@ -203,7 +94,7 @@ diff -urN a/gopls/api-diff/api_diff.go b/gopls/api-diff/api_diff.go - if err := diff(b, prev, current, "option", func(o *source.OptionJSON) string { - return o.Name - }, diffOptions); err != nil { -- return "", err +- return "", fmt.Errorf("diff options (%s): %v", key, err) - } - } - @@ -254,41 +145,48 @@ diff -urN a/gopls/api-diff/api_diff.go b/gopls/api-diff/api_diff.go - return m -} - --func loadAPI(version string) (*source.APIJSON, error) { -- dir, err := ioutil.TempDir("", "gopath*") +-var goCmdRunner = gocommand.Runner{} +- +-func loadAPI(ctx context.Context, version string) (*source.APIJSON, error) { +- tmpGopath, err := ioutil.TempDir("", "gopath*") - if err != nil { -- return nil, err +- return nil, fmt.Errorf("temp dir: %v", err) - } -- defer os.RemoveAll(dir) +- defer os.RemoveAll(tmpGopath) - -- if err := os.Mkdir(fmt.Sprintf("%s/src", dir), 0776); err != nil { -- return nil, err +- exampleDir := fmt.Sprintf("%s/src/example.com", tmpGopath) +- if err := os.MkdirAll(exampleDir, 0776); err != nil { +- return nil, fmt.Errorf("mkdir: %v", err) - } -- goCmd, err := exec.LookPath("go") -- if err != nil { -- return nil, err -- } -- cmd := exec.Cmd{ -- Path: goCmd, -- Args: []string{"go", "get", fmt.Sprintf("golang.org/x/tools/gopls@%s", version)}, -- Dir: dir, -- Env: append(os.Environ(), fmt.Sprintf("GOPATH=%s", dir)), +- +- if stdout, err := goCmdRunner.Run(ctx, gocommand.Invocation{ +- Verb: "mod", +- Args: []string{"init", "example.com"}, +- WorkingDir: exampleDir, +- Env: append(os.Environ(), fmt.Sprintf("GOPATH=%s", tmpGopath)), +- }); err != nil { +- return nil, fmt.Errorf("go mod init failed: %v (stdout: %v)", err, stdout) - } -- if err := cmd.Run(); err != nil { -- return nil, err +- if stdout, err := goCmdRunner.Run(ctx, gocommand.Invocation{ +- Verb: "install", +- Args: []string{fmt.Sprintf("golang.org/x/tools/gopls@%s", version)}, +- WorkingDir: exampleDir, +- Env: append(os.Environ(), fmt.Sprintf("GOPATH=%s", tmpGopath)), +- }); err != nil { +- return nil, fmt.Errorf("go install failed: %v (stdout: %v)", err, stdout.String()) - } -- cmd = exec.Cmd{ -- Path: filepath.Join(dir, "bin", "gopls"), +- cmd := exec.Cmd{ +- Path: filepath.Join(tmpGopath, "bin", "gopls"), - Args: []string{"gopls", "api-json"}, -- Dir: dir, +- Dir: tmpGopath, - } - out, err := cmd.Output() - if err != nil { -- return nil, err +- return nil, fmt.Errorf("output: %v", err) - } - apiJson := &source.APIJSON{} - if err := json.Unmarshal(out, apiJson); err != nil { -- return nil, err +- return nil, fmt.Errorf("unmarshal: %v", err) - } - return apiJson, nil -} @@ -379,9 +277,9 @@ diff -urN a/gopls/api-diff/api_diff.go b/gopls/api-diff/api_diff.go - return fmt.Sprintf("%q", difflib.ToUnified("previous", "current", before, d)), err -} diff -urN a/gopls/doc/advanced.md b/gopls/doc/advanced.md ---- a/gopls/doc/advanced.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/advanced.md 1969-12-31 16:00:00.000000000 -0800 -@@ -1,70 +0,0 @@ +--- a/gopls/doc/advanced.md 2021-12-15 10:41:42.359936085 +0100 ++++ b/gopls/doc/advanced.md 1970-01-01 01:00:00.000000000 +0100 +@@ -1,81 +0,0 @@ -# Advanced topics - -This documentation is for advanced `gopls` users, who may want to test @@ -393,7 +291,7 @@ diff -urN a/gopls/doc/advanced.md b/gopls/doc/advanced.md -version), run: - -```sh --GO111MODULE=on go get golang.org/x/tools/gopls@vX.Y.Z +-GO111MODULE=on go install golang.org/x/tools/gopls@vX.Y.Z -``` - -Where `vX.Y.Z` is the desired version. @@ -403,7 +301,17 @@ diff -urN a/gopls/doc/advanced.md b/gopls/doc/advanced.md -To update `gopls` to the latest **unstable** version, use: - -```sh --GO111MODULE=on go get golang.org/x/tools/gopls@master golang.org/x/tools@master +-# Create an empty go.mod file, only for tracking requirements. +-cd $(mktemp -d) +-go mod init gopls-unstable +- +-# Use 'go get' to add requirements and to ensure they work together. +-go get golang.org/x/tools/gopls@master golang.org/x/tools@master +- +-# For go1.17 or older, the above `go get` command will build and +-# install `gopls`. For go1.18+ or tip, run the following command to install +-# using selected versions in go.mod. +-go install golang.org/x/tools/gopls -``` - -## Working on the Go source distribution @@ -430,20 +338,21 @@ diff -urN a/gopls/doc/advanced.md b/gopls/doc/advanced.md -`golang.org/dl/gotip`: - -``` --$ go get golang.org/dl/gotip +-$ go install golang.org/dl/gotip@latest -$ gotip download -``` - -For building gopls with type parameter support, it is recommended that you --build gopls at tip. External APIs are under active development on the --Go `master` branch, so building gopls at tip minimizes the chances of --a build failure. +-build gopls at tip. External APIs are under active development on the Go +-`master` branch, so building gopls at tip minimizes the chances of a build +-failure. You will also need to update the `go` directive in your `go.mod` +-file to refer to `go 1.18` to use generics. - --``` --$ GO111MODULE=on gotip get golang.org/x/tools/gopls@master golang.org/x/tools@master --``` +-Build and install the latest **unstable** version of `gopls` following +-[the instruction](#installing-unreleased-versions). +-Remember to use `gotip` instead of `go`. - --This will build a version of gopls that understands generic code. To actually +-The `gopls` build with this instruction understands generic code. To actually -run the generic code you develop, you must also use the tip version of the Go -compiler. For example: - @@ -453,9 +362,9 @@ diff -urN a/gopls/doc/advanced.md b/gopls/doc/advanced.md - -[Go project]: https://go.googlesource.com/go diff -urN a/gopls/doc/analyzers.md b/gopls/doc/analyzers.md ---- a/gopls/doc/analyzers.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/analyzers.md 1969-12-31 16:00:00.000000000 -0800 -@@ -1,641 +0,0 @@ +--- a/gopls/doc/analyzers.md 2021-12-15 10:41:42.359936085 +0100 ++++ b/gopls/doc/analyzers.md 1970-01-01 01:00:00.000000000 +0100 +@@ -1,657 +0,0 @@ -# Analyzers - -This document describes the analyzers that `gopls` uses inside the editor. @@ -642,6 +551,22 @@ diff -urN a/gopls/doc/analyzers.md b/gopls/doc/analyzers.md - -**Enabled by default.** - +-## **infertypeargs** +- +-check for unnecessary type arguments in call expressions +- +-Explicit type arguments may be omitted from call expressions if they can be +-inferred from function arguments, or from other type arguments: +- +-func f[T any](T) {} +- +-func _() { +- f[string]("foo") // string could be inferred +-} +- +- +-**Enabled by default.** +- -## **loopclosure** - -check references to loop variables from within nested functions @@ -1098,9 +1023,9 @@ diff -urN a/gopls/doc/analyzers.md b/gopls/doc/analyzers.md - - diff -urN a/gopls/doc/command-line.md b/gopls/doc/command-line.md ---- a/gopls/doc/command-line.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/command-line.md 1969-12-31 16:00:00.000000000 -0800 -@@ -1,17 +0,0 @@ +--- a/gopls/doc/command-line.md 2021-12-15 10:41:42.359936085 +0100 ++++ b/gopls/doc/command-line.md 1970-01-01 01:00:00.000000000 +0100 +@@ -1,15 +0,0 @@ -# Command line - -**Note: The `gopls` command-line is still experimental and subject to change at any point.** @@ -1116,11 +1041,9 @@ diff -urN a/gopls/doc/command-line.md b/gopls/doc/command-line.md -There are two main reasons for this. The first is that we do not want users to rely on separate command line tools when they wish to do some task outside of an editor. The second is that the CLI assists in debugging. It is easier to reproduce behavior via single command. - -It is not a goal of `gopls` to be a high performance command line tool. Its command line is intended for single file/package user interaction speeds, not bulk processing. -- --For more information, see the `gopls` [command line page](command-line.md). diff -urN a/gopls/doc/commands.md b/gopls/doc/commands.md ---- a/gopls/doc/commands.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/commands.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/commands.md 2021-12-15 10:41:42.359936085 +0100 ++++ b/gopls/doc/commands.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,370 +0,0 @@ -# Commands - @@ -1493,8 +1416,8 @@ diff -urN a/gopls/doc/commands.md b/gopls/doc/commands.md - - diff -urN a/gopls/doc/contributing.md b/gopls/doc/contributing.md ---- a/gopls/doc/contributing.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/contributing.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/contributing.md 2021-12-15 10:41:42.359936085 +0100 ++++ b/gopls/doc/contributing.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,119 +0,0 @@ -# Documentation for contributors - @@ -1616,8 +1539,8 @@ diff -urN a/gopls/doc/contributing.md b/gopls/doc/contributing.md -[issue-gopls]: https://github.com/golang/go/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3Agopls "gopls issues" -[issue-wanted]: https://github.com/golang/go/issues?utf8=✓&q=is%3Aissue+is%3Aopen+label%3Agopls+label%3A"help+wanted" "help wanted" diff -urN a/gopls/doc/daemon.md b/gopls/doc/daemon.md ---- a/gopls/doc/daemon.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/daemon.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/daemon.md 2021-12-15 10:41:42.359936085 +0100 ++++ b/gopls/doc/daemon.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,183 +0,0 @@ -# Running gopls as a daemon - @@ -1803,8 +1726,8 @@ diff -urN a/gopls/doc/daemon.md b/gopls/doc/daemon.md -change its configuration. These flags only matter for the forwarder process -that actually starts the daemon. diff -urN a/gopls/doc/design/design.md b/gopls/doc/design/design.md ---- a/gopls/doc/design/design.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/design/design.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/design/design.md 2021-12-15 10:41:42.359936085 +0100 ++++ b/gopls/doc/design/design.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,394 +0,0 @@ -# `gopls` design documentation - @@ -2201,8 +2124,8 @@ diff -urN a/gopls/doc/design/design.md b/gopls/doc/design/design.md -[`textDocument/typeDefinition`]: https://github.com/Microsoft/language-server-protocol/blob/gh-pages/_specifications/specification-3-14.md#textDocument_typeDefinition -[`workspace/didChangeWatchedFiles`]: https://github.com/Microsoft/language-server-protocol/blob/gh-pages/_specifications/specification-3-14.md#workspace_didChangeWatchedFiles diff -urN a/gopls/doc/design/implementation.md b/gopls/doc/design/implementation.md ---- a/gopls/doc/design/implementation.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/design/implementation.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/design/implementation.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/design/implementation.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,48 +0,0 @@ -# gopls implementation documentation - @@ -2253,8 +2176,8 @@ diff -urN a/gopls/doc/design/implementation.md b/gopls/doc/design/implementation -[internal/span]: https://github.com/golang/tools/tree/master/internal/span -[x/tools]: https://github.com/golang/tools diff -urN a/gopls/doc/design/integrating.md b/gopls/doc/design/integrating.md ---- a/gopls/doc/design/integrating.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/design/integrating.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/design/integrating.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/design/integrating.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,91 +0,0 @@ -# Documentation for plugin authors - @@ -2348,8 +2271,8 @@ diff -urN a/gopls/doc/design/integrating.md b/gopls/doc/design/integrating.md -[#31553]: https://github.com/golang/go/issues/31553 -[#31526]: https://github.com/golang/go/issues/31526 diff -urN a/gopls/doc/emacs.md b/gopls/doc/emacs.md ---- a/gopls/doc/emacs.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/emacs.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/emacs.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/emacs.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,183 +0,0 @@ -# Emacs - @@ -2535,19 +2458,19 @@ diff -urN a/gopls/doc/emacs.md b/gopls/doc/emacs.md -[settings]: settings.md -[Gophers slack]: https://invite.slack.golangbridge.org/ diff -urN a/gopls/doc/features.md b/gopls/doc/features.md ---- a/gopls/doc/features.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/features.md 1969-12-31 16:00:00.000000000 -0800 -@@ -1,24 +0,0 @@ +--- a/gopls/doc/features.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/features.md 1970-01-01 01:00:00.000000000 +0100 +@@ -1,46 +0,0 @@ -# Features - -This document describes some of the features supported by `gopls`. It is -currently under construction, so, for a comprehensive list, see the -[Language Server Protocol](https://microsoft.github.io/language-server-protocol/). - --For now, only special features outside of the LSP are described below. -- -## Special features - +-Here, only special features outside of the LSP are described. +- -### Symbol Queries - -Gopls supports some extended syntax for `workspace/symbol` requests, when using @@ -2561,10 +2484,32 @@ diff -urN a/gopls/doc/features.md b/gopls/doc/features.md -| `^` | `^printf` | exact prefix | -| `$` | `printf$` | exact suffix | - +-## Template Files +- +-Gopls provides some support for Go template files, that is, files that +-are parsed by `text/template` or `html/template`. +-Gopls recognizes template files based on their file extension. +-By default it looks for files ending in `.tmpl` or `.gotmpl`, +-but this list may be configured by the +-[`templateExtensions`](https://github.com/golang/tools/blob/master/gopls/doc/settings.md#templateextensions-string) setting. +-Making this list empty turns off template support. +- +-In template files, template support works inside +-the default `{{` delimiters. (Go template parsing +-allows the user to specify other delimiters, but +-gopls does not know how to do that.) +- +-Gopls template support includes the following features: +-+ **Diagnostics**: if template parsing returns an error, +-it is presented as a diagnostic. (Missing functions do not produce errors.) +-+ **Syntax Highlighting**: syntax highlighting is provided for template files. +-+ **Definitions**: gopls provides jump-to-definition inside templates, though it does not understand scoping (all templates are considered to be in one global scope). +-+ **References**: gopls provides find-references, with the same scoping limitation as definitions. +-+ **Completions**: gopls will attempt to suggest completions inside templates. - diff -urN a/gopls/doc/generate.go b/gopls/doc/generate.go ---- a/gopls/doc/generate.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/generate.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/generate.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/generate.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,721 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -3288,8 +3233,8 @@ diff -urN a/gopls/doc/generate.go b/gopls/doc/generate.go - return result, nil -} diff -urN a/gopls/doc/generate_test.go b/gopls/doc/generate_test.go ---- a/gopls/doc/generate_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/generate_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/generate_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/generate_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,23 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -3315,8 +3260,8 @@ diff -urN a/gopls/doc/generate_test.go b/gopls/doc/generate_test.go - } -} diff -urN a/gopls/doc/semantictokens.md b/gopls/doc/semantictokens.md ---- a/gopls/doc/semantictokens.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/semantictokens.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/semantictokens.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/semantictokens.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,121 +0,0 @@ -# Semantic Tokens - @@ -3441,9 +3386,9 @@ diff -urN a/gopls/doc/semantictokens.md b/gopls/doc/semantictokens.md -in the unedited part of the file, and they do. \ No newline at end of file diff -urN a/gopls/doc/settings.md b/gopls/doc/settings.md ---- a/gopls/doc/settings.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/settings.md 1969-12-31 16:00:00.000000000 -0800 -@@ -1,487 +0,0 @@ +--- a/gopls/doc/settings.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/settings.md 1970-01-01 01:00:00.000000000 +0100 +@@ -1,486 +0,0 @@ -# Settings - - @@ -3518,6 +3463,14 @@ diff -urN a/gopls/doc/settings.md b/gopls/doc/settings.md - -Default: `["-node_modules"]`. - +-#### **templateExtensions** *[]string* +- +-templateExtensions gives the extensions of file names that are treateed +-as template files. (The extension +-is the part of the file name after the final dot.) +- +-Default: `["tmpl","gotmpl"]`. +- -#### **memoryMode** *enum* - -**This setting is experimental and may be deleted.** @@ -3558,15 +3511,6 @@ diff -urN a/gopls/doc/settings.md b/gopls/doc/settings.md - -Default: `false`. - --#### **experimentalTemplateSupport** *bool* -- --**This setting is experimental and may be deleted.** -- --experimentalTemplateSupport opts into the experimental support --for template files. -- --Default: `false`. -- -#### **experimentalPackageCacheKey** *bool* - -**This setting is experimental and may be deleted.** @@ -3932,8 +3876,8 @@ diff -urN a/gopls/doc/settings.md b/gopls/doc/settings.md -Runs `go mod vendor` for a module. - diff -urN a/gopls/doc/subl.md b/gopls/doc/subl.md ---- a/gopls/doc/subl.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/subl.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/subl.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/subl.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,77 +0,0 @@ -# Sublime Text - @@ -4013,8 +3957,8 @@ diff -urN a/gopls/doc/subl.md b/gopls/doc/subl.md - -[LSP]: https://packagecontrol.io/packages/LSP diff -urN a/gopls/doc/troubleshooting.md b/gopls/doc/troubleshooting.md ---- a/gopls/doc/troubleshooting.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/troubleshooting.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/troubleshooting.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/troubleshooting.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,48 +0,0 @@ -# Troubleshooting - @@ -4065,8 +4009,8 @@ diff -urN a/gopls/doc/troubleshooting.md b/gopls/doc/troubleshooting.md - -`gopls` automatically writes out memory debug information when your usage exceeds 1GB. This information can be found in your temporary directory with names like `gopls.1234-5GiB-withnames.zip`. On Windows, your temporary directory will be located at `%TMP%`, and on Unixes, it will be `$TMPDIR`, which is usually `/tmp`. Please [file an issue](#file-an-issue) with this memory debug information attached. If you are uncomfortable sharing the package names of your code, you can share the `-nonames` zip instead, but it's much less useful. diff -urN a/gopls/doc/vim.md b/gopls/doc/vim.md ---- a/gopls/doc/vim.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/vim.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/vim.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/vim.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,229 +0,0 @@ -# Vim / Neovim - @@ -4298,8 +4242,8 @@ diff -urN a/gopls/doc/vim.md b/gopls/doc/vim.md -[nvim-lspconfig]: https://github.com/neovim/nvim-lspconfig/blob/master/CONFIG.md#gopls -[nvim-lspconfig-imports]: https://github.com/neovim/nvim-lspconfig/issues/115 diff -urN a/gopls/doc/workspace.md b/gopls/doc/workspace.md ---- a/gopls/doc/workspace.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/doc/workspace.md 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/doc/workspace.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/doc/workspace.md 1970-01-01 01:00:00.000000000 +0100 @@ -1,75 +0,0 @@ -# Setting up your workspace - @@ -4377,35 +4321,38 @@ diff -urN a/gopls/doc/workspace.md b/gopls/doc/workspace.md -If you have additional use cases that are not mentioned above, please -[file a new issue](https://github.com/golang/go/issues/new). diff -urN a/gopls/go.mod b/gopls/go.mod ---- a/gopls/go.mod 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/go.mod 1969-12-31 16:00:00.000000000 -0800 -@@ -1,23 +0,0 @@ +--- a/gopls/go.mod 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/go.mod 1970-01-01 01:00:00.000000000 +0100 +@@ -1,26 +0,0 @@ -module golang.org/x/tools/gopls - -go 1.18 - -require ( -- github.com/BurntSushi/toml v0.4.1 // indirect - github.com/google/go-cmp v0.5.6 -- github.com/google/safehtml v0.0.2 // indirect - github.com/jba/templatecheck v0.6.0 - github.com/sanity-io/litter v1.5.1 - github.com/sergi/go-diff v1.1.0 -- golang.org/x/mod v0.4.2 +- golang.org/x/mod v0.5.1 +- golang.org/x/sys v0.0.0-20211019181941-9d821ace8654 +- golang.org/x/tools v0.1.7 +- honnef.co/go/tools v0.2.1 +- mvdan.cc/gofumpt v0.1.1 +- mvdan.cc/xurls/v2 v2.3.0 +-) +- +-require ( +- github.com/BurntSushi/toml v0.4.1 // indirect +- github.com/google/safehtml v0.0.2 // indirect - golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect -- golang.org/x/sys v0.0.0-20210809222454-d867a43fc93e - golang.org/x/text v0.3.7 // indirect -- golang.org/x/tools v0.1.5 - golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect -- honnef.co/go/tools v0.2.0 -- mvdan.cc/gofumpt v0.1.1 -- mvdan.cc/xurls/v2 v2.3.0 -) - -replace golang.org/x/tools => ../ diff -urN a/gopls/go.sum b/gopls/go.sum ---- a/gopls/go.sum 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/go.sum 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/go.sum 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/go.sum 1970-01-01 01:00:00.000000000 +0100 @@ -1,70 +0,0 @@ -github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU= -github.com/BurntSushi/toml v0.4.1 h1:GaI7EiDXDRfa8VshkTj7Fym7ha+y8/XxIgD2okUIjLw= @@ -4438,22 +4385,22 @@ diff -urN a/gopls/go.sum b/gopls/go.sum -github.com/stretchr/testify v0.0.0-20161117074351-18a02ba4a312/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs= -github.com/stretchr/testify v1.4.0 h1:2E4SXV/wtOkTonXsotYi4li6zVWxYlZuYNCXe9XRJyk= -github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4= --github.com/yuin/goldmark v1.4.0/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k= +-github.com/yuin/goldmark v1.4.1/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k= -golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= -golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= -golang.org/x/mod v0.4.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= --golang.org/x/mod v0.4.2 h1:Gz96sIWK3OalVv/I/qNygP42zyoKp3xptRVCWRFEBvo= --golang.org/x/mod v0.4.2/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= +-golang.org/x/mod v0.5.1 h1:OJxoQ/rynoF0dcCdI7cLPktw/hR2cueqYfjm43oqK38= +-golang.org/x/mod v0.5.1/go.mod h1:5OXOZSfqPIIbmVBIIKWRFfZjPR0E5r58TLhUjH0a2Ro= -golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= --golang.org/x/net v0.0.0-20210805182204-aaa1db679c0d/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= +-golang.org/x/net v0.0.0-20211015210444-4f30a5c0130f/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= -golang.org/x/sync v0.0.0-20210220032951-036812b2e83c h1:5KslGYwFpkhGh+Q16bwMP3cOontH8FOep7tGV86Y7SQ= -golang.org/x/sync v0.0.0-20210220032951-036812b2e83c/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= -golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= -golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= -golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= -golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= --golang.org/x/sys v0.0.0-20210809222454-d867a43fc93e h1:WUoyKPm6nCo1BnNUvPGnFG3T5DUVem42yDJZZ4CNxMA= --golang.org/x/sys v0.0.0-20210809222454-d867a43fc93e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= +-golang.org/x/sys v0.0.0-20211019181941-9d821ace8654 h1:id054HUawV2/6IGm2IV8KZQjqtwAOo2CYlOToYqa0d0= +-golang.org/x/sys v0.0.0-20211019181941-9d821ace8654/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= -golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo= -golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= -golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= @@ -4471,86 +4418,15 @@ diff -urN a/gopls/go.sum b/gopls/go.sum -gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= -gopkg.in/yaml.v2 v2.2.4 h1:/eiJrUcujPVeJ3xlSWaiNi3uSVmDGBK1pDHUHAnao1I= -gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= --honnef.co/go/tools v0.2.0 h1:ws8AfbgTX3oIczLPNPCu5166oBg9ST2vNs0rcht+mDE= --honnef.co/go/tools v0.2.0/go.mod h1:lPVVZ2BS5TfnjLyizF7o7hv7j9/L+8cZY2hLyjP9cGY= +-honnef.co/go/tools v0.2.1 h1:/EPr//+UMMXwMTkXvCCoaJDq8cpjMO80Ou+L4PDo2mY= +-honnef.co/go/tools v0.2.1/go.mod h1:lPVVZ2BS5TfnjLyizF7o7hv7j9/L+8cZY2hLyjP9cGY= -mvdan.cc/gofumpt v0.1.1 h1:bi/1aS/5W00E2ny5q65w9SnKpWEF/UIOqDYBILpo9rA= -mvdan.cc/gofumpt v0.1.1/go.mod h1:yXG1r1WqZVKWbVRtBWKWX9+CxGYfA51nSomhM0woR48= -mvdan.cc/xurls/v2 v2.3.0 h1:59Olnbt67UKpxF1EwVBopJvkSUBmgtb468E4GVWIZ1I= -mvdan.cc/xurls/v2 v2.3.0/go.mod h1:AjuTy7gEiUArFMjgBBDU4SMxlfUYsRokpJQgNWOt3e4= -diff -urN a/gopls/integration/govim/Dockerfile b/gopls/integration/govim/Dockerfile ---- a/gopls/integration/govim/Dockerfile 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/integration/govim/Dockerfile 1969-12-31 16:00:00.000000000 -0800 -@@ -1,16 +0,0 @@ --# Copyright 2019 The Go Authors. All rights reserved. --# Use of this source code is governed by a BSD-style --# license that can be found in the LICENSE file. -- --# govim requires a more recent version of vim than is available in most --# distros, so we build from their base image. --FROM govim/govim:latest-vim --ARG GOVIM_REF -- --ENV GOPROXY=https://proxy.golang.org GOPATH=/go VIM_FLAVOR=vim --WORKDIR /src -- --# Clone govim. In order to use the go command for resolving latest, we download --# a redundant copy of govim to the build cache using `go mod download`. --RUN git clone https://github.com/govim/govim /src/govim && cd /src/govim && \ -- git checkout $GOVIM_REF -diff -urN a/gopls/integration/govim/README.md b/gopls/integration/govim/README.md ---- a/gopls/integration/govim/README.md 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/integration/govim/README.md 1969-12-31 16:00:00.000000000 -0800 -@@ -1,47 +0,0 @@ --# govim integration tests -- --Files in this directory configure Cloud Build to run [govim] integration tests --against a gopls binary built from source. -- --## Running on GCP -- --To run these integration tests in Cloud Build, use the following steps. Here --we assume that `$PROJECT_ID` is a valid GCP project and `$BUCKET` is a cloud --storage bucket owned by that project. -- --- `cd` to the root directory of the tools project. --- (at least once per GCP project) Build the test harness: --``` --$ gcloud builds submit \ -- --project="${PROJECT_ID}" \ -- --config=gopls/integration/govim/cloudbuild.harness.yaml --``` --- Run the integration tests: --``` --$ gcloud builds submit \ -- --project="${PROJECT_ID}" \ -- --config=gopls/integration/govim/cloudbuild.yaml \ -- --substitutions=_RESULT_BUCKET="${BUCKET}" --``` -- --## Fetching Artifacts -- --Assuming the artifacts bucket is world readable, you can fetch integration from --GCS. They are located at: -- --- logs: `https://storage.googleapis.com/${BUCKET}/log-${EVALUATION_ID}.txt` --- artifact tarball: `https://storage.googleapis.com/${BUCKET}/govim/${EVALUATION_ID}/artifacts.tar.gz` -- --The `artifacts.go` command can be used to fetch both artifacts using an --evaluation id. -- --## Running locally -- --Run `gopls/integration/govim/run_local.sh`. This may take a while the first --time it is run, as it will require building the test harness. This script --accepts two flags to modify its behavior: -- --**--sudo**: run docker with `sudo` --**--short**: run `go test -short` -- --[govim]: https://github.com/govim/govim diff -urN a/gopls/integration/govim/artifacts.go b/gopls/integration/govim/artifacts.go ---- a/gopls/integration/govim/artifacts.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/integration/govim/artifacts.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/integration/govim/artifacts.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/integration/govim/artifacts.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,67 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -4620,8 +4496,8 @@ diff -urN a/gopls/integration/govim/artifacts.go b/gopls/integration/govim/artif - return nil -} diff -urN a/gopls/integration/govim/cloudbuild.harness.yaml b/gopls/integration/govim/cloudbuild.harness.yaml ---- a/gopls/integration/govim/cloudbuild.harness.yaml 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/integration/govim/cloudbuild.harness.yaml 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/integration/govim/cloudbuild.harness.yaml 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/integration/govim/cloudbuild.harness.yaml 1970-01-01 01:00:00.000000000 +0100 @@ -1,21 +0,0 @@ -# Copyright 2019 The Go Authors. All rights reserved. -# Use of this source code is governed by a BSD-style @@ -4645,8 +4521,8 @@ diff -urN a/gopls/integration/govim/cloudbuild.harness.yaml b/gopls/integration/ -images: - - gcr.io/$PROJECT_ID/govim-harness diff -urN a/gopls/integration/govim/cloudbuild.yaml b/gopls/integration/govim/cloudbuild.yaml ---- a/gopls/integration/govim/cloudbuild.yaml 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/integration/govim/cloudbuild.yaml 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/integration/govim/cloudbuild.yaml 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/integration/govim/cloudbuild.yaml 1970-01-01 01:00:00.000000000 +0100 @@ -1,51 +0,0 @@ -# Copyright 2019 The Go Authors. All rights reserved. -# Use of this source code is governed by a BSD-style @@ -4699,9 +4575,80 @@ diff -urN a/gopls/integration/govim/cloudbuild.yaml b/gopls/integration/govim/cl -# Write build logs to the same bucket as artifacts, so they can be more easily -# shared. -logsBucket: 'gs://${_RESULT_BUCKET}' +diff -urN a/gopls/integration/govim/Dockerfile b/gopls/integration/govim/Dockerfile +--- a/gopls/integration/govim/Dockerfile 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/integration/govim/Dockerfile 1970-01-01 01:00:00.000000000 +0100 +@@ -1,16 +0,0 @@ +-# Copyright 2019 The Go Authors. All rights reserved. +-# Use of this source code is governed by a BSD-style +-# license that can be found in the LICENSE file. +- +-# govim requires a more recent version of vim than is available in most +-# distros, so we build from their base image. +-FROM govim/govim:latest-vim +-ARG GOVIM_REF +- +-ENV GOPROXY=https://proxy.golang.org GOPATH=/go VIM_FLAVOR=vim +-WORKDIR /src +- +-# Clone govim. In order to use the go command for resolving latest, we download +-# a redundant copy of govim to the build cache using `go mod download`. +-RUN git clone https://github.com/govim/govim /src/govim && cd /src/govim && \ +- git checkout $GOVIM_REF +diff -urN a/gopls/integration/govim/README.md b/gopls/integration/govim/README.md +--- a/gopls/integration/govim/README.md 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/integration/govim/README.md 1970-01-01 01:00:00.000000000 +0100 +@@ -1,47 +0,0 @@ +-# govim integration tests +- +-Files in this directory configure Cloud Build to run [govim] integration tests +-against a gopls binary built from source. +- +-## Running on GCP +- +-To run these integration tests in Cloud Build, use the following steps. Here +-we assume that `$PROJECT_ID` is a valid GCP project and `$BUCKET` is a cloud +-storage bucket owned by that project. +- +-- `cd` to the root directory of the tools project. +-- (at least once per GCP project) Build the test harness: +-``` +-$ gcloud builds submit \ +- --project="${PROJECT_ID}" \ +- --config=gopls/integration/govim/cloudbuild.harness.yaml +-``` +-- Run the integration tests: +-``` +-$ gcloud builds submit \ +- --project="${PROJECT_ID}" \ +- --config=gopls/integration/govim/cloudbuild.yaml \ +- --substitutions=_RESULT_BUCKET="${BUCKET}" +-``` +- +-## Fetching Artifacts +- +-Assuming the artifacts bucket is world readable, you can fetch integration from +-GCS. They are located at: +- +-- logs: `https://storage.googleapis.com/${BUCKET}/log-${EVALUATION_ID}.txt` +-- artifact tarball: `https://storage.googleapis.com/${BUCKET}/govim/${EVALUATION_ID}/artifacts.tar.gz` +- +-The `artifacts.go` command can be used to fetch both artifacts using an +-evaluation id. +- +-## Running locally +- +-Run `gopls/integration/govim/run_local.sh`. This may take a while the first +-time it is run, as it will require building the test harness. This script +-accepts two flags to modify its behavior: +- +-**--sudo**: run docker with `sudo` +-**--short**: run `go test -short` +- +-[govim]: https://github.com/govim/govim diff -urN a/gopls/integration/govim/run_local.sh b/gopls/integration/govim/run_local.sh ---- a/gopls/integration/govim/run_local.sh 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/integration/govim/run_local.sh 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/integration/govim/run_local.sh 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/integration/govim/run_local.sh 1970-01-01 01:00:00.000000000 +0100 @@ -1,96 +0,0 @@ -#!/bin/bash -e - @@ -4800,8 +4747,8 @@ diff -urN a/gopls/integration/govim/run_local.sh b/gopls/integration/govim/run_l - go test ${TEST_SHORT} ./cmd/govim \ - -gopls "/src/tools/gopls/${temp_gopls_name}" diff -urN a/gopls/integration/govim/run_tests_for_cloudbuild.sh b/gopls/integration/govim/run_tests_for_cloudbuild.sh ---- a/gopls/integration/govim/run_tests_for_cloudbuild.sh 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/integration/govim/run_tests_for_cloudbuild.sh 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/integration/govim/run_tests_for_cloudbuild.sh 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/integration/govim/run_tests_for_cloudbuild.sh 1970-01-01 01:00:00.000000000 +0100 @@ -1,28 +0,0 @@ -#!/bin/bash - @@ -4832,8 +4779,8 @@ diff -urN a/gopls/integration/govim/run_tests_for_cloudbuild.sh b/gopls/integrat - find "$GOVIM_TESTSCRIPT_WORKDIR_ROOT" -type d \( -name .vim -o -name gopath \) -prune -exec rm -rf '{}' \; -fi diff -urN a/gopls/internal/coverage/coverage.go b/gopls/internal/coverage/coverage.go ---- a/gopls/internal/coverage/coverage.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/coverage/coverage.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/coverage/coverage.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/coverage/coverage.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,261 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -5096,9 +5043,25 @@ diff -urN a/gopls/internal/coverage/coverage.go b/gopls/internal/coverage/covera - filepath.WalkDir(dir, f) - return ans -} +diff -urN a/gopls/internal/hooks/analysis_115.go b/gopls/internal/hooks/analysis_115.go +--- a/gopls/internal/hooks/analysis_115.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/hooks/analysis_115.go 1970-01-01 01:00:00.000000000 +0100 +@@ -1,12 +0,0 @@ +-// Copyright 2021 The Go Authors. All rights reserved. +-// Use of this source code is governed by a BSD-style +-// license that can be found in the LICENSE file. +- +-//go:build !go1.15 +-// +build !go1.15 +- +-package hooks +- +-import "golang.org/x/tools/internal/lsp/source" +- +-func updateAnalyzers(_ *source.Options) {} diff -urN a/gopls/internal/hooks/analysis.go b/gopls/internal/hooks/analysis.go ---- a/gopls/internal/hooks/analysis.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/hooks/analysis.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/hooks/analysis.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/hooks/analysis.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,60 +0,0 @@ -// Copyright 2019 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -5153,32 +5116,16 @@ diff -urN a/gopls/internal/hooks/analysis.go b/gopls/internal/hooks/analysis.go - add(staticcheck.Analyzers, map[string]struct{}{ - // This check conflicts with the vet printf check (golang/go#34494). - "SA5009": {}, -- // This check relies on facts from dependencies, which -- // we don't currently compute. -- "SA5011": {}, -- }) -- add(stylecheck.Analyzers, nil) -- add(quickfix.Analyzers, nil) --} -diff -urN a/gopls/internal/hooks/analysis_115.go b/gopls/internal/hooks/analysis_115.go ---- a/gopls/internal/hooks/analysis_115.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/hooks/analysis_115.go 1969-12-31 16:00:00.000000000 -0800 -@@ -1,12 +0,0 @@ --// Copyright 2021 The Go Authors. All rights reserved. --// Use of this source code is governed by a BSD-style --// license that can be found in the LICENSE file. -- --//go:build !go1.15 --// +build !go1.15 -- --package hooks -- --import "golang.org/x/tools/internal/lsp/source" -- --func updateAnalyzers(_ *source.Options) {} +- // This check relies on facts from dependencies, which +- // we don't currently compute. +- "SA5011": {}, +- }) +- add(stylecheck.Analyzers, nil) +- add(quickfix.Analyzers, nil) +-} diff -urN a/gopls/internal/hooks/diff.go b/gopls/internal/hooks/diff.go ---- a/gopls/internal/hooks/diff.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/hooks/diff.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/hooks/diff.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/hooks/diff.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,41 +0,0 @@ -// Copyright 2019 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -5222,8 +5169,8 @@ diff -urN a/gopls/internal/hooks/diff.go b/gopls/internal/hooks/diff.go - return edits, nil -} diff -urN a/gopls/internal/hooks/diff_test.go b/gopls/internal/hooks/diff_test.go ---- a/gopls/internal/hooks/diff_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/hooks/diff_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/hooks/diff_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/hooks/diff_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,16 +0,0 @@ -// Copyright 2019 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -5242,8 +5189,8 @@ diff -urN a/gopls/internal/hooks/diff_test.go b/gopls/internal/hooks/diff_test.g - difftest.DiffTest(t, hooks.ComputeEdits) -} diff -urN a/gopls/internal/hooks/gen-licenses.sh b/gopls/internal/hooks/gen-licenses.sh ---- a/gopls/internal/hooks/gen-licenses.sh 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/hooks/gen-licenses.sh 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/hooks/gen-licenses.sh 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/hooks/gen-licenses.sh 1970-01-01 01:00:00.000000000 +0100 @@ -1,38 +0,0 @@ -#!/bin/bash -eu - @@ -5285,8 +5232,8 @@ diff -urN a/gopls/internal/hooks/gen-licenses.sh b/gopls/internal/hooks/gen-lice -mv $tempfile $output \ No newline at end of file diff -urN a/gopls/internal/hooks/hooks.go b/gopls/internal/hooks/hooks.go ---- a/gopls/internal/hooks/hooks.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/hooks/hooks.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/hooks/hooks.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/hooks/hooks.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,37 +0,0 @@ -// Copyright 2019 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -5326,8 +5273,8 @@ diff -urN a/gopls/internal/hooks/hooks.go b/gopls/internal/hooks/hooks.go - relaxedFullWord.Longest() -} diff -urN a/gopls/internal/hooks/licenses.go b/gopls/internal/hooks/licenses.go ---- a/gopls/internal/hooks/licenses.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/hooks/licenses.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/hooks/licenses.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/hooks/licenses.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,169 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -5499,8 +5446,8 @@ diff -urN a/gopls/internal/hooks/licenses.go b/gopls/internal/hooks/licenses.go - -` diff -urN a/gopls/internal/hooks/licenses_test.go b/gopls/internal/hooks/licenses_test.go ---- a/gopls/internal/hooks/licenses_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/hooks/licenses_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/hooks/licenses_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/hooks/licenses_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,46 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -5549,8 +5496,8 @@ diff -urN a/gopls/internal/hooks/licenses_test.go b/gopls/internal/hooks/license - } -} diff -urN a/gopls/internal/regtest/bench/bench_test.go b/gopls/internal/regtest/bench/bench_test.go ---- a/gopls/internal/regtest/bench/bench_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/bench/bench_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/bench/bench_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/bench/bench_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,191 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -5744,8 +5691,8 @@ diff -urN a/gopls/internal/regtest/bench/bench_test.go b/gopls/internal/regtest/ - }) -} diff -urN a/gopls/internal/regtest/bench/completion_bench_test.go b/gopls/internal/regtest/bench/completion_bench_test.go ---- a/gopls/internal/regtest/bench/completion_bench_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/bench/completion_bench_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/bench/completion_bench_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/bench/completion_bench_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,186 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -5934,8 +5881,8 @@ diff -urN a/gopls/internal/regtest/bench/completion_bench_test.go b/gopls/intern - }, t) -} diff -urN a/gopls/internal/regtest/bench/stress_test.go b/gopls/internal/regtest/bench/stress_test.go ---- a/gopls/internal/regtest/bench/stress_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/bench/stress_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/bench/stress_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/bench/stress_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,66 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -6004,8 +5951,8 @@ diff -urN a/gopls/internal/regtest/bench/stress_test.go b/gopls/internal/regtest - }) -} diff -urN a/gopls/internal/regtest/codelens/codelens_test.go b/gopls/internal/regtest/codelens/codelens_test.go ---- a/gopls/internal/regtest/codelens/codelens_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/codelens/codelens_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/codelens/codelens_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/codelens/codelens_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,356 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -6364,8 +6311,8 @@ diff -urN a/gopls/internal/regtest/codelens/codelens_test.go b/gopls/internal/re - }) -} diff -urN a/gopls/internal/regtest/completion/completion_test.go b/gopls/internal/regtest/completion/completion_test.go ---- a/gopls/internal/regtest/completion/completion_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/completion/completion_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/completion/completion_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/completion/completion_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,544 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -6912,8 +6859,8 @@ diff -urN a/gopls/internal/regtest/completion/completion_test.go b/gopls/interna - }) -} diff -urN a/gopls/internal/regtest/completion/postfix_snippet_test.go b/gopls/internal/regtest/completion/postfix_snippet_test.go ---- a/gopls/internal/regtest/completion/postfix_snippet_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/completion/postfix_snippet_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/completion/postfix_snippet_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/completion/postfix_snippet_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,402 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -7318,8 +7265,8 @@ diff -urN a/gopls/internal/regtest/completion/postfix_snippet_test.go b/gopls/in - }) -} diff -urN a/gopls/internal/regtest/diagnostics/builtin_test.go b/gopls/internal/regtest/diagnostics/builtin_test.go ---- a/gopls/internal/regtest/diagnostics/builtin_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/diagnostics/builtin_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/diagnostics/builtin_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/diagnostics/builtin_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,38 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -7360,9 +7307,9 @@ diff -urN a/gopls/internal/regtest/diagnostics/builtin_test.go b/gopls/internal/ - }) -} diff -urN a/gopls/internal/regtest/diagnostics/diagnostics_test.go b/gopls/internal/regtest/diagnostics/diagnostics_test.go ---- a/gopls/internal/regtest/diagnostics/diagnostics_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/diagnostics/diagnostics_test.go 1969-12-31 16:00:00.000000000 -0800 -@@ -1,2135 +0,0 @@ +--- a/gopls/internal/regtest/diagnostics/diagnostics_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/diagnostics/diagnostics_test.go 1970-01-01 01:00:00.000000000 +0100 +@@ -1,2140 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. @@ -8003,6 +7950,8 @@ diff -urN a/gopls/internal/regtest/diagnostics/diagnostics_test.go b/gopls/inter - -// Test for golang/go#38211. -func Test_Issue38211(t *testing.T) { +- t.Skipf("Skipping flaky test: https://golang.org/issue/44098") +- - testenv.NeedsGo1Point(t, 14) - const ardanLabs = ` --- go.mod -- @@ -8332,6 +8281,8 @@ diff -urN a/gopls/internal/regtest/diagnostics/diagnostics_test.go b/gopls/inter -// This is a copy of the scenario_default/quickfix_empty_files.txt test from -// govim. Reproduces golang/go#39646. -func TestQuickFixEmptyFiles(t *testing.T) { +- t.Skip("too flaky: golang/go#48773") +- - testenv.NeedsGo1Point(t, 15) - - const mod = ` @@ -8874,6 +8825,7 @@ diff -urN a/gopls/internal/regtest/diagnostics/diagnostics_test.go b/gopls/inter -// TestProgressBarErrors confirms that critical workspace load errors are shown -// and updated via progress reports. -func TestProgressBarErrors(t *testing.T) { +- t.Skip("too flaky: golang/go#46930") - testenv.NeedsGo1Point(t, 14) - - const pkg = ` @@ -9498,9 +9450,80 @@ diff -urN a/gopls/internal/regtest/diagnostics/diagnostics_test.go b/gopls/inter - ) - }) -} +diff -urN a/gopls/internal/regtest/diagnostics/undeclared_test.go b/gopls/internal/regtest/diagnostics/undeclared_test.go +--- a/gopls/internal/regtest/diagnostics/undeclared_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/diagnostics/undeclared_test.go 1970-01-01 01:00:00.000000000 +0100 +@@ -1,67 +0,0 @@ +-// Copyright 2021 The Go Authors. All rights reserved. +-// Use of this source code is governed by a BSD-style +-// license that can be found in the LICENSE file. +- +-package diagnostics +- +-import ( +- "testing" +- +- "golang.org/x/tools/internal/lsp/protocol" +- . "golang.org/x/tools/internal/lsp/regtest" +-) +- +-func TestUndeclaredDiagnostics(t *testing.T) { +- src := ` +--- go.mod -- +-module mod.com +- +-go 1.12 +--- a/a.go -- +-package a +- +-func _() int { +- return x +-} +--- b/b.go -- +-package b +- +-func _() int { +- var y int +- y = y +- return y +-} +-` +- Run(t, src, func(t *testing.T, env *Env) { +- isUnnecessary := func(diag protocol.Diagnostic) bool { +- for _, tag := range diag.Tags { +- if tag == protocol.Unnecessary { +- return true +- } +- } +- return false +- } +- +- // 'x' is undeclared, but still necessary. +- env.OpenFile("a/a.go") +- env.Await(env.DiagnosticAtRegexp("a/a.go", "x")) +- diags := env.DiagnosticsFor("a/a.go") +- if got := len(diags.Diagnostics); got != 1 { +- t.Errorf("len(Diagnostics) = %d, want 1", got) +- } +- if diag := diags.Diagnostics[0]; isUnnecessary(diag) { +- t.Errorf("%v tagged unnecessary, want necessary", diag) +- } +- +- // 'y = y' is pointless, and should be detected as unnecessary. +- env.OpenFile("b/b.go") +- env.Await(env.DiagnosticAtRegexp("b/b.go", "y = y")) +- diags = env.DiagnosticsFor("b/b.go") +- if got := len(diags.Diagnostics); got != 1 { +- t.Errorf("len(Diagnostics) = %d, want 1", got) +- } +- if diag := diags.Diagnostics[0]; !isUnnecessary(diag) { +- t.Errorf("%v tagged necessary, want unnecessary", diag) +- } +- }) +-} diff -urN a/gopls/internal/regtest/misc/add_import_test.go b/gopls/internal/regtest/misc/add_import_test.go ---- a/gopls/internal/regtest/misc/add_import_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/add_import_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/add_import_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/add_import_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,59 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -9561,9 +9584,48 @@ diff -urN a/gopls/internal/regtest/misc/add_import_test.go b/gopls/internal/regt - } - }) -} +diff -urN a/gopls/internal/regtest/misc/call_hierarchy_test.go b/gopls/internal/regtest/misc/call_hierarchy_test.go +--- a/gopls/internal/regtest/misc/call_hierarchy_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/call_hierarchy_test.go 1970-01-01 01:00:00.000000000 +0100 +@@ -1,35 +0,0 @@ +-// Copyright 2021 The Go Authors. All rights reserved. +-// Use of this source code is governed by a BSD-style +-// license that can be found in the LICENSE file. +-package misc +- +-import ( +- "testing" +- +- "golang.org/x/tools/internal/lsp/protocol" +- . "golang.org/x/tools/internal/lsp/regtest" +-) +- +-// Test for golang/go#49125 +-func TestCallHierarchy_Issue49125(t *testing.T) { +- const files = ` +--- go.mod -- +-module mod.com +- +-go 1.12 +--- p.go -- +-package pkg +-` +- // TODO(rfindley): this could probably just be a marker test. +- Run(t, files, func(t *testing.T, env *Env) { +- env.OpenFile("p.go") +- pos := env.RegexpSearch("p.go", "pkg") +- +- var params protocol.CallHierarchyPrepareParams +- params.TextDocument.URI = env.Sandbox.Workdir.URI("p.go") +- params.Position = pos.ToProtocolPosition() +- +- // Check that this doesn't panic. +- env.Editor.Server.PrepareCallHierarchy(env.Ctx, ¶ms) +- }) +-} diff -urN a/gopls/internal/regtest/misc/configuration_test.go b/gopls/internal/regtest/misc/configuration_test.go ---- a/gopls/internal/regtest/misc/configuration_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/configuration_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/configuration_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/configuration_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,49 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -9615,8 +9677,8 @@ diff -urN a/gopls/internal/regtest/misc/configuration_test.go b/gopls/internal/r - }) -} diff -urN a/gopls/internal/regtest/misc/debugserver_test.go b/gopls/internal/regtest/misc/debugserver_test.go ---- a/gopls/internal/regtest/misc/debugserver_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/debugserver_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/debugserver_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/debugserver_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,46 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -9665,9 +9727,9 @@ diff -urN a/gopls/internal/regtest/misc/debugserver_test.go b/gopls/internal/reg - }) -} diff -urN a/gopls/internal/regtest/misc/definition_test.go b/gopls/internal/regtest/misc/definition_test.go ---- a/gopls/internal/regtest/misc/definition_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/definition_test.go 1969-12-31 16:00:00.000000000 -0800 -@@ -1,279 +0,0 @@ +--- a/gopls/internal/regtest/misc/definition_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/definition_test.go 1970-01-01 01:00:00.000000000 +0100 +@@ -1,291 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. @@ -9679,6 +9741,7 @@ diff -urN a/gopls/internal/regtest/misc/definition_test.go b/gopls/internal/regt - "strings" - "testing" - +- "golang.org/x/tools/internal/lsp/protocol" - . "golang.org/x/tools/internal/lsp/regtest" - "golang.org/x/tools/internal/testenv" - @@ -9947,9 +10010,20 @@ diff -urN a/gopls/internal/regtest/misc/definition_test.go b/gopls/internal/regt - env.GoToDefinition("client/client_role_test.go", env.RegexpSearch("client/client_role_test.go", "RoleSetup")) - }) -} +- +-// This test exercises a crashing pattern from golang/go#49223. +-func TestGoToCrashingDefinition_Issue49223(t *testing.T) { +- Run(t, "", func(t *testing.T, env *Env) { +- params := &protocol.DefinitionParams{} +- params.TextDocument.URI = protocol.DocumentURI("fugitive%3A///Users/user/src/mm/ems/.git//0/pkg/domain/treasury/provider.go") +- params.Position.Character = 18 +- params.Position.Line = 0 +- env.Editor.Server.Definition(env.Ctx, params) +- }) +-} diff -urN a/gopls/internal/regtest/misc/embed_test.go b/gopls/internal/regtest/misc/embed_test.go ---- a/gopls/internal/regtest/misc/embed_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/embed_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/embed_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/embed_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,37 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -9989,8 +10063,8 @@ diff -urN a/gopls/internal/regtest/misc/embed_test.go b/gopls/internal/regtest/m - }) -} diff -urN a/gopls/internal/regtest/misc/failures_test.go b/gopls/internal/regtest/misc/failures_test.go ---- a/gopls/internal/regtest/misc/failures_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/failures_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/failures_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/failures_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,70 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -10063,9 +10137,9 @@ diff -urN a/gopls/internal/regtest/misc/failures_test.go b/gopls/internal/regtes - }) -} diff -urN a/gopls/internal/regtest/misc/fix_test.go b/gopls/internal/regtest/misc/fix_test.go ---- a/gopls/internal/regtest/misc/fix_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/fix_test.go 1969-12-31 16:00:00.000000000 -0800 -@@ -1,106 +0,0 @@ +--- a/gopls/internal/regtest/misc/fix_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/fix_test.go 1970-01-01 01:00:00.000000000 +0100 +@@ -1,107 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. @@ -10130,6 +10204,7 @@ diff -urN a/gopls/internal/regtest/misc/fix_test.go b/gopls/internal/regtest/mis -} - -func TestFillReturns(t *testing.T) { +- t.Skip("temporarily skipped until CL 367196 is submitted") - const files = ` --- go.mod -- -module mod.com @@ -10173,8 +10248,8 @@ diff -urN a/gopls/internal/regtest/misc/fix_test.go b/gopls/internal/regtest/mis - }) -} diff -urN a/gopls/internal/regtest/misc/formatting_test.go b/gopls/internal/regtest/misc/formatting_test.go ---- a/gopls/internal/regtest/misc/formatting_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/formatting_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/formatting_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/formatting_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,270 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -10447,9 +10522,9 @@ diff -urN a/gopls/internal/regtest/misc/formatting_test.go b/gopls/internal/regt - } -} diff -urN a/gopls/internal/regtest/misc/generate_test.go b/gopls/internal/regtest/misc/generate_test.go ---- a/gopls/internal/regtest/misc/generate_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/generate_test.go 1969-12-31 16:00:00.000000000 -0800 -@@ -1,73 +0,0 @@ +--- a/gopls/internal/regtest/misc/generate_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/generate_test.go 1970-01-01 01:00:00.000000000 +0100 +@@ -1,75 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. @@ -10468,6 +10543,8 @@ diff -urN a/gopls/internal/regtest/misc/generate_test.go b/gopls/internal/regtes -) - -func TestGenerateProgress(t *testing.T) { +- t.Skipf("skipping flaky test: https://golang.org/issue/49901") +- - const generatedWorkspace = ` --- go.mod -- -module fake.test @@ -10524,8 +10601,8 @@ diff -urN a/gopls/internal/regtest/misc/generate_test.go b/gopls/internal/regtes - }) -} diff -urN a/gopls/internal/regtest/misc/highlight_test.go b/gopls/internal/regtest/misc/highlight_test.go ---- a/gopls/internal/regtest/misc/highlight_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/highlight_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/highlight_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/highlight_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,151 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -10679,8 +10756,8 @@ diff -urN a/gopls/internal/regtest/misc/highlight_test.go b/gopls/internal/regte - } -} diff -urN a/gopls/internal/regtest/misc/hover_test.go b/gopls/internal/regtest/misc/hover_test.go ---- a/gopls/internal/regtest/misc/hover_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/hover_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/hover_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/hover_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,132 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -10815,8 +10892,8 @@ diff -urN a/gopls/internal/regtest/misc/hover_test.go b/gopls/internal/regtest/m - }) -} diff -urN a/gopls/internal/regtest/misc/imports_test.go b/gopls/internal/regtest/misc/imports_test.go ---- a/gopls/internal/regtest/misc/imports_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/imports_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/imports_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/imports_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,216 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -11035,8 +11112,8 @@ diff -urN a/gopls/internal/regtest/misc/imports_test.go b/gopls/internal/regtest - }) -} diff -urN a/gopls/internal/regtest/misc/link_test.go b/gopls/internal/regtest/misc/link_test.go ---- a/gopls/internal/regtest/misc/link_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/link_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/link_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/link_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,95 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -11134,8 +11211,8 @@ diff -urN a/gopls/internal/regtest/misc/link_test.go b/gopls/internal/regtest/mi - }) -} diff -urN a/gopls/internal/regtest/misc/misc_test.go b/gopls/internal/regtest/misc/misc_test.go ---- a/gopls/internal/regtest/misc/misc_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/misc_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/misc_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/misc_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,16 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -11154,8 +11231,8 @@ diff -urN a/gopls/internal/regtest/misc/misc_test.go b/gopls/internal/regtest/mi - regtest.Main(m, hooks.Options) -} diff -urN a/gopls/internal/regtest/misc/multiple_adhoc_test.go b/gopls/internal/regtest/misc/multiple_adhoc_test.go ---- a/gopls/internal/regtest/misc/multiple_adhoc_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/multiple_adhoc_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/multiple_adhoc_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/multiple_adhoc_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,44 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -11202,8 +11279,8 @@ diff -urN a/gopls/internal/regtest/misc/multiple_adhoc_test.go b/gopls/internal/ - }) -} diff -urN a/gopls/internal/regtest/misc/references_test.go b/gopls/internal/regtest/misc/references_test.go ---- a/gopls/internal/regtest/misc/references_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/references_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/references_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/references_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,83 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -11289,8 +11366,8 @@ diff -urN a/gopls/internal/regtest/misc/references_test.go b/gopls/internal/regt - }) -} diff -urN a/gopls/internal/regtest/misc/rename_test.go b/gopls/internal/regtest/misc/rename_test.go ---- a/gopls/internal/regtest/misc/rename_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/rename_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/rename_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/rename_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,58 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -11351,8 +11428,8 @@ diff -urN a/gopls/internal/regtest/misc/rename_test.go b/gopls/internal/regtest/ - }) -} diff -urN a/gopls/internal/regtest/misc/semantictokens_test.go b/gopls/internal/regtest/misc/semantictokens_test.go ---- a/gopls/internal/regtest/misc/semantictokens_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/semantictokens_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/semantictokens_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/semantictokens_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,44 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -11399,8 +11476,8 @@ diff -urN a/gopls/internal/regtest/misc/semantictokens_test.go b/gopls/internal/ - }) -} diff -urN a/gopls/internal/regtest/misc/shared_test.go b/gopls/internal/regtest/misc/shared_test.go ---- a/gopls/internal/regtest/misc/shared_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/shared_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/shared_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/shared_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,64 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -11467,8 +11544,8 @@ diff -urN a/gopls/internal/regtest/misc/shared_test.go b/gopls/internal/regtest/ - }) -} diff -urN a/gopls/internal/regtest/misc/template_test.go b/gopls/internal/regtest/misc/template_test.go ---- a/gopls/internal/regtest/misc/template_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/template_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/misc/template_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/template_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,72 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -11543,9 +11620,9 @@ diff -urN a/gopls/internal/regtest/misc/template_test.go b/gopls/internal/regtes -// Hover, SemTok, Diagnose with errors -// and better coverage diff -urN a/gopls/internal/regtest/misc/vendor_test.go b/gopls/internal/regtest/misc/vendor_test.go ---- a/gopls/internal/regtest/misc/vendor_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/misc/vendor_test.go 1969-12-31 16:00:00.000000000 -0800 -@@ -1,69 +0,0 @@ +--- a/gopls/internal/regtest/misc/vendor_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/misc/vendor_test.go 1970-01-01 01:00:00.000000000 +0100 +@@ -1,73 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. @@ -11553,6 +11630,7 @@ diff -urN a/gopls/internal/regtest/misc/vendor_test.go b/gopls/internal/regtest/ -package misc - -import ( +- "runtime" - "testing" - - . "golang.org/x/tools/internal/lsp/regtest" @@ -11574,6 +11652,9 @@ diff -urN a/gopls/internal/regtest/misc/vendor_test.go b/gopls/internal/regtest/ - -func TestInconsistentVendoring(t *testing.T) { - testenv.NeedsGo1Point(t, 14) +- if runtime.GOOS == "windows" { +- t.Skipf("skipping test due to flakiness on Windows: https://golang.org/issue/49646") +- } - - const pkgThatUsesVendoring = ` --- go.mod -- @@ -11616,8 +11697,8 @@ diff -urN a/gopls/internal/regtest/misc/vendor_test.go b/gopls/internal/regtest/ - }) -} diff -urN a/gopls/internal/regtest/modfile/modfile_test.go b/gopls/internal/regtest/modfile/modfile_test.go ---- a/gopls/internal/regtest/modfile/modfile_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/modfile/modfile_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/modfile/modfile_test.go 2021-12-15 10:41:42.363936091 +0100 ++++ b/gopls/internal/regtest/modfile/modfile_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,1117 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -12737,8 +12818,8 @@ diff -urN a/gopls/internal/regtest/modfile/modfile_test.go b/gopls/internal/regt - }) -} diff -urN a/gopls/internal/regtest/watch/watch_test.go b/gopls/internal/regtest/watch/watch_test.go ---- a/gopls/internal/regtest/watch/watch_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/watch/watch_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/internal/regtest/watch/watch_test.go 2021-12-15 10:41:42.367936097 +0100 ++++ b/gopls/internal/regtest/watch/watch_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,766 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -13507,9 +13588,9 @@ diff -urN a/gopls/internal/regtest/watch/watch_test.go b/gopls/internal/regtest/ - }) -} diff -urN a/gopls/internal/regtest/workspace/workspace_test.go b/gopls/internal/regtest/workspace/workspace_test.go ---- a/gopls/internal/regtest/workspace/workspace_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/internal/regtest/workspace/workspace_test.go 1969-12-31 16:00:00.000000000 -0800 -@@ -1,1083 +0,0 @@ +--- a/gopls/internal/regtest/workspace/workspace_test.go 2021-12-15 10:41:42.367936097 +0100 ++++ b/gopls/internal/regtest/workspace/workspace_test.go 1970-01-01 01:00:00.000000000 +0100 +@@ -1,1161 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. @@ -13521,11 +13602,13 @@ diff -urN a/gopls/internal/regtest/workspace/workspace_test.go b/gopls/internal/ - "fmt" - "io/ioutil" - "path/filepath" +- "sort" - "strings" - "testing" - - "golang.org/x/tools/gopls/internal/hooks" - . "golang.org/x/tools/internal/lsp/regtest" +- "golang.org/x/tools/internal/lsp/source" - - "golang.org/x/tools/internal/lsp/command" - "golang.org/x/tools/internal/lsp/fake" @@ -13649,6 +13732,38 @@ diff -urN a/gopls/internal/regtest/workspace/workspace_test.go b/gopls/internal/ - } -} - +-// make sure that directory filters work +-func TestFilters(t *testing.T) { +- for _, tt := range []struct { +- name, rootPath string +- }{ +- { +- name: "module root", +- rootPath: "pkg", +- }, +- } { +- t.Run(tt.name, func(t *testing.T) { +- opts := []RunOption{ProxyFiles(workspaceProxy)} +- if tt.rootPath != "" { +- opts = append(opts, WorkspaceFolders(tt.rootPath)) +- } +- f := func(o *source.Options) { +- o.DirectoryFilters = append(o.DirectoryFilters, "-inner") +- } +- opts = append(opts, Options(f)) +- WithOptions(opts...).Run(t, workspaceModule, func(t *testing.T, env *Env) { +- syms := env.WorkspaceSymbol("Hi") +- sort.Slice(syms, func(i, j int) bool { return syms[i].ContainerName < syms[j].ContainerName }) +- for i, s := range syms { +- if strings.Contains(s.ContainerName, "/inner") { +- t.Errorf("%s %v %s %s %d\n", s.Name, s.Kind, s.ContainerName, tt.name, i) +- } +- } +- }) +- }) +- } +-} +- -// Make sure that analysis diagnostics are cleared for the whole package when -// the only opened file is closed. This test was inspired by the experience in -// VS Code, where clicking on a reference result triggers a @@ -14168,7 +14283,6 @@ diff -urN a/gopls/internal/regtest/workspace/workspace_test.go b/gopls/internal/ -` - WithOptions( - ProxyFiles(workspaceModuleProxy), -- Modes(Experimental), - ).Run(t, multiModule, func(t *testing.T, env *Env) { - // Initially, the gopls.mod should cause only the a.com module to be - // loaded. Validate this by jumping to a definition in b.com and ensuring @@ -14334,6 +14448,7 @@ diff -urN a/gopls/internal/regtest/workspace/workspace_test.go b/gopls/internal/ --- moda/a/go.mod -- -module a.com - +-go 1.15 --- moda/a/a.go -- -package main - @@ -14342,6 +14457,8 @@ diff -urN a/gopls/internal/regtest/workspace/workspace_test.go b/gopls/internal/ -} --- modb/go.mod -- -module b.com +- +-go 1.16 --- modb/b/b.go -- -package main - @@ -14371,7 +14488,7 @@ diff -urN a/gopls/internal/regtest/workspace/workspace_test.go b/gopls/internal/ - t.Fatalf("reading expected workspace modfile: %v", err) - } - got := string(gotb) -- for _, want := range []string{"a.com v1.9999999.0-goplsworkspace", "b.com v1.9999999.0-goplsworkspace"} { +- for _, want := range []string{"go 1.16", "a.com v1.9999999.0-goplsworkspace", "b.com v1.9999999.0-goplsworkspace"} { - if !strings.Contains(got, want) { - // want before got here, since the go.mod is multi-line - t.Fatalf("workspace go.mod missing %q. got:\n%s", want, got) @@ -14593,9 +14710,51 @@ diff -urN a/gopls/internal/regtest/workspace/workspace_test.go b/gopls/internal/ - ) - }) -} +- +-func TestAddGoWork(t *testing.T) { +- const nomod = ` +--- a/go.mod -- +-module a.com +- +-go 1.16 +--- a/main.go -- +-package main +- +-func main() {} +--- b/go.mod -- +-module b.com +- +-go 1.16 +--- b/main.go -- +-package main +- +-func main() {} +-` +- WithOptions( +- Modes(Singleton), +- ).Run(t, nomod, func(t *testing.T, env *Env) { +- env.OpenFile("a/main.go") +- env.OpenFile("b/main.go") +- env.Await( +- DiagnosticAt("a/main.go", 0, 0), +- DiagnosticAt("b/main.go", 0, 0), +- ) +- env.WriteWorkspaceFile("go.work", `go 1.16 +- +-directory ( +- a +- b +-) +-`) +- env.Await( +- EmptyDiagnostics("a/main.go"), +- EmptyDiagnostics("b/main.go"), +- ) +- }) +-} diff -urN a/gopls/main.go b/gopls/main.go ---- a/gopls/main.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/main.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/main.go 2021-12-15 10:41:42.367936097 +0100 ++++ b/gopls/main.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,26 +0,0 @@ -// Copyright 2019 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -14623,9 +14782,121 @@ diff -urN a/gopls/main.go b/gopls/main.go - ctx := context.Background() - tool.Main(ctx, cmd.New("gopls", "", nil, hooks.Options), os.Args[1:]) -} +diff -urN a/gopls/README.md b/gopls/README.md +--- a/gopls/README.md 2021-12-15 10:41:42.359936085 +0100 ++++ b/gopls/README.md 1970-01-01 01:00:00.000000000 +0100 +@@ -1,108 +0,0 @@ +-# `gopls`, the Go language server +- +-[![PkgGoDev](https://pkg.go.dev/badge/golang.org/x/tools/gopls)](https://pkg.go.dev/golang.org/x/tools/gopls) +- +-`gopls` (pronounced "Go please") is the official Go [language server] developed +-by the Go team. It provides IDE features to any [LSP]-compatible editor. +- +- +- +-You should not need to interact with `gopls` directly--it will be automatically +-integrated into your editor. The specific features and settings vary slightly +-by editor, so we recommend that you proceed to the [documentation for your +-editor](#editors) below. +- +-## Editors +- +-To get started with `gopls`, install an LSP plugin in your editor of choice. +- +-* [VSCode](https://github.com/golang/vscode-go/blob/master/README.md) +-* [Vim / Neovim](doc/vim.md) +-* [Emacs](doc/emacs.md) +-* [Atom](https://github.com/MordFustang21/ide-gopls) +-* [Sublime Text](doc/subl.md) +-* [Acme](https://github.com/fhs/acme-lsp) +- +-If you use `gopls` with an editor that is not on this list, please let us know +-by [filing an issue](#new-issue) or [modifying this documentation](doc/contributing.md). +- +-## Installation +- +-For the most part, you should not need to install or update `gopls`. Your +-editor should handle that step for you. +- +-If you do want to get the latest stable version of `gopls`, change to any +-directory that is both outside of your `GOPATH` and outside of a module (a temp +-directory is fine), and run: +- +-```sh +-go install golang.org/x/tools/gopls@latest +-``` +- +-**NOTE**: Do not use the `-u` flag, as it will update your dependencies to +-incompatible versions. +- +-Learn more in the [advanced installation +-instructions](doc/advanced.md#installing-unreleased-versions). +- +-## Setting up your workspace +- +-`gopls` supports both Go module and GOPATH modes, but if you are working with +-multiple modules or uncommon project layouts, you will need to specifically +-configure your workspace. See the [Workspace document](doc/workspace.md) for +-information on supported workspace layouts. +- +-## Configuration +- +-You can configure `gopls` to change your editor experience or view additional +-debugging information. Configuration options will be made available by your +-editor, so see your [editor's instructions](#editors) for specific details. A +-full list of `gopls` settings can be found in the [Settings documentation](doc/settings.md). +- +-### Environment variables +- +-`gopls` inherits your editor's environment, so be aware of any environment +-variables you configure. Some editors, such as VS Code, allow users to +-selectively override the values of some environment variables. +- +-## Troubleshooting +- +-If you are having issues with `gopls`, please follow the steps described in the +-[troubleshooting guide](doc/troubleshooting.md). +- +-## Supported Go versions and build systems +- +-`gopls` follows the [Go Release +-Policy](https://golang.org/doc/devel/release.html#policy), meaning that it +-officially supports the last 2 major Go releases. Per +-[issue #39146](golang.org/issues/39146), we attempt to maintain best-effort +-support for the last 4 major Go releases, but this support extends only to not +-breaking the build and avoiding easily fixable regressions. +- +-Our extended support is enforced via [continuous integration with older Go +-versions](doc/contributing.md#ci). This legacy Go CI may not block releases: +-test failures may be skipped rather than fixed. Furthermore, if a regression in +-an older Go version causes irreconcilable CI failures, we may drop support for +-that Go version in CI if it is 3 or 4 Go versions old. +- +-`gopls` currently only supports the `go` command, so if you are using a +-different build system, `gopls` will not work well. Bazel is not officially +-supported, but Bazel support is in development (see +-[bazelbuild/rules_go#512](https://github.com/bazelbuild/rules_go/issues/512)). +-You can follow [these instructions](https://github.com/bazelbuild/rules_go/wiki/Editor-setup) +-to configure your `gopls` to work with Bazel. +- +-## Additional information +- +-* [Features](doc/features.md) +-* [Command-line interface](doc/command-line.md) +-* [Advanced topics](doc/advanced.md) +-* [Contributing to `gopls`](doc/contributing.md) +-* [Integrating `gopls` with an editor](doc/design/integrating.md) +-* [Design requirements and decisions](doc/design/design.md) +-* [Implementation details](doc/design/implementation.md) +-* [Open issues](https://github.com/golang/go/issues?q=is%3Aissue+is%3Aopen+label%3Agopls) +- +-[language server]: https://langserver.org +-[LSP]: https://microsoft.github.io/language-server-protocol/ +-[Gophers Slack]: https://gophers.slack.com/ diff -urN a/gopls/release/release.go b/gopls/release/release.go ---- a/gopls/release/release.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/release/release.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/release/release.go 2021-12-15 10:41:42.367936097 +0100 ++++ b/gopls/release/release.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,213 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -14841,8 +15112,8 @@ diff -urN a/gopls/release/release.go b/gopls/release/release.go - return nil -} diff -urN a/gopls/test/debug/debug_test.go b/gopls/test/debug/debug_test.go ---- a/gopls/test/debug/debug_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/test/debug/debug_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/test/debug/debug_test.go 2021-12-15 10:41:42.367936097 +0100 ++++ b/gopls/test/debug/debug_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,181 +0,0 @@ -// Copyright 2020 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -15026,8 +15297,8 @@ diff -urN a/gopls/test/debug/debug_test.go b/gopls/test/debug/debug_test.go - return nil -} diff -urN a/gopls/test/gopls_test.go b/gopls/test/gopls_test.go ---- a/gopls/test/gopls_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/test/gopls_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/test/gopls_test.go 2021-12-15 10:41:42.367936097 +0100 ++++ b/gopls/test/gopls_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,32 +0,0 @@ -// Copyright 2019 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style @@ -15062,8 +15333,8 @@ diff -urN a/gopls/test/gopls_test.go b/gopls/test/gopls_test.go - hooks.Options(options) -} diff -urN a/gopls/test/json_test.go b/gopls/test/json_test.go ---- a/gopls/test/json_test.go 2021-10-06 09:35:10.000000000 -0700 -+++ b/gopls/test/json_test.go 1969-12-31 16:00:00.000000000 -0800 +--- a/gopls/test/json_test.go 2021-12-15 10:41:42.367936097 +0100 ++++ b/gopls/test/json_test.go 1970-01-01 01:00:00.000000000 +0100 @@ -1,134 +0,0 @@ -// Copyright 2021 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style diff --git a/third_party/org_golang_x_tools-gazelle.patch b/third_party/org_golang_x_tools-gazelle.patch index ed5c55eec9..babd50fc2b 100644 --- a/third_party/org_golang_x_tools-gazelle.patch +++ b/third_party/org_golang_x_tools-gazelle.patch @@ -1,5 +1,5 @@ diff -urN b/benchmark/parse/BUILD.bazel c/benchmark/parse/BUILD.bazel ---- b/benchmark/parse/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/benchmark/parse/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/benchmark/parse/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -22,8 +22,26 @@ diff -urN b/benchmark/parse/BUILD.bazel c/benchmark/parse/BUILD.bazel + srcs = ["parse_test.go"], + embed = [":parse"], +) +diff -urN b/blog/atom/BUILD.bazel c/blog/atom/BUILD.bazel +--- b/blog/atom/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/blog/atom/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "atom", ++ srcs = ["atom.go"], ++ importpath = "golang.org/x/tools/blog/atom", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":atom", ++ visibility = ["//visibility:public"], ++) diff -urN b/blog/BUILD.bazel c/blog/BUILD.bazel ---- b/blog/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/blog/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/blog/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -50,26 +68,8 @@ diff -urN b/blog/BUILD.bazel c/blog/BUILD.bazel + srcs = ["blog_test.go"], + embed = [":blog"], +) -diff -urN b/blog/atom/BUILD.bazel c/blog/atom/BUILD.bazel ---- b/blog/atom/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/blog/atom/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,14 @@ -+load("@io_bazel_rules_go//go:def.bzl", "go_library") -+ -+go_library( -+ name = "atom", -+ srcs = ["atom.go"], -+ importpath = "golang.org/x/tools/blog/atom", -+ visibility = ["//visibility:public"], -+) -+ -+alias( -+ name = "go_default_library", -+ actual = ":atom", -+ visibility = ["//visibility:public"], -+) diff -urN b/cmd/auth/authtest/BUILD.bazel c/cmd/auth/authtest/BUILD.bazel ---- b/cmd/auth/authtest/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/auth/authtest/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/auth/authtest/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -88,7 +88,7 @@ diff -urN b/cmd/auth/authtest/BUILD.bazel c/cmd/auth/authtest/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/auth/cookieauth/BUILD.bazel c/cmd/auth/cookieauth/BUILD.bazel ---- b/cmd/auth/cookieauth/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/auth/cookieauth/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/auth/cookieauth/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -106,7 +106,7 @@ diff -urN b/cmd/auth/cookieauth/BUILD.bazel c/cmd/auth/cookieauth/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/auth/gitauth/BUILD.bazel c/cmd/auth/gitauth/BUILD.bazel ---- b/cmd/auth/gitauth/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/auth/gitauth/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/auth/gitauth/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -125,7 +125,7 @@ diff -urN b/cmd/auth/gitauth/BUILD.bazel c/cmd/auth/gitauth/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/auth/netrcauth/BUILD.bazel c/cmd/auth/netrcauth/BUILD.bazel ---- b/cmd/auth/netrcauth/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/auth/netrcauth/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/auth/netrcauth/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -143,7 +143,7 @@ diff -urN b/cmd/auth/netrcauth/BUILD.bazel c/cmd/auth/netrcauth/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/benchcmp/BUILD.bazel c/cmd/benchcmp/BUILD.bazel ---- b/cmd/benchcmp/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/benchcmp/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/benchcmp/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -176,7 +176,7 @@ diff -urN b/cmd/benchcmp/BUILD.bazel c/cmd/benchcmp/BUILD.bazel + deps = ["//benchmark/parse"], +) diff -urN b/cmd/bundle/BUILD.bazel c/cmd/bundle/BUILD.bazel ---- b/cmd/bundle/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/bundle/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/bundle/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,22 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -202,7 +202,7 @@ diff -urN b/cmd/bundle/BUILD.bazel c/cmd/bundle/BUILD.bazel + deps = ["//go/packages/packagestest"], +) diff -urN b/cmd/bundle/testdata/src/domain.name/importdecl/BUILD.bazel c/cmd/bundle/testdata/src/domain.name/importdecl/BUILD.bazel ---- b/cmd/bundle/testdata/src/domain.name/importdecl/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/bundle/testdata/src/domain.name/importdecl/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/bundle/testdata/src/domain.name/importdecl/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -220,7 +220,7 @@ diff -urN b/cmd/bundle/testdata/src/domain.name/importdecl/BUILD.bazel c/cmd/bun + visibility = ["//visibility:public"], +) diff -urN b/cmd/bundle/testdata/src/initial/BUILD.bazel c/cmd/bundle/testdata/src/initial/BUILD.bazel ---- b/cmd/bundle/testdata/src/initial/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/bundle/testdata/src/initial/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/bundle/testdata/src/initial/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -242,7 +242,7 @@ diff -urN b/cmd/bundle/testdata/src/initial/BUILD.bazel c/cmd/bundle/testdata/sr + visibility = ["//visibility:public"], +) diff -urN b/cmd/callgraph/BUILD.bazel c/cmd/callgraph/BUILD.bazel ---- b/cmd/callgraph/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/callgraph/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/callgraph/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,73 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -319,7 +319,7 @@ diff -urN b/cmd/callgraph/BUILD.bazel c/cmd/callgraph/BUILD.bazel + }), +) diff -urN b/cmd/callgraph/testdata/src/pkg/BUILD.bazel c/cmd/callgraph/testdata/src/pkg/BUILD.bazel ---- b/cmd/callgraph/testdata/src/pkg/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/callgraph/testdata/src/pkg/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/callgraph/testdata/src/pkg/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -343,7 +343,7 @@ diff -urN b/cmd/callgraph/testdata/src/pkg/BUILD.bazel c/cmd/callgraph/testdata/ + embed = [":pkg_lib"], +) diff -urN b/cmd/compilebench/BUILD.bazel c/cmd/compilebench/BUILD.bazel ---- b/cmd/compilebench/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/compilebench/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/compilebench/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -362,7 +362,7 @@ diff -urN b/cmd/compilebench/BUILD.bazel c/cmd/compilebench/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/cover/BUILD.bazel c/cmd/cover/BUILD.bazel ---- b/cmd/cover/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/cover/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/cover/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,70 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -436,7 +436,7 @@ diff -urN b/cmd/cover/BUILD.bazel c/cmd/cover/BUILD.bazel + }), +) diff -urN b/cmd/cover/testdata/BUILD.bazel c/cmd/cover/testdata/BUILD.bazel ---- b/cmd/cover/testdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/cover/testdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/cover/testdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -457,7 +457,7 @@ diff -urN b/cmd/cover/testdata/BUILD.bazel c/cmd/cover/testdata/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/digraph/BUILD.bazel c/cmd/digraph/BUILD.bazel ---- b/cmd/digraph/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/digraph/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/digraph/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -481,7 +481,7 @@ diff -urN b/cmd/digraph/BUILD.bazel c/cmd/digraph/BUILD.bazel + embed = [":digraph_lib"], +) diff -urN b/cmd/eg/BUILD.bazel c/cmd/eg/BUILD.bazel ---- b/cmd/eg/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/eg/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/eg/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,19 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -504,7 +504,7 @@ diff -urN b/cmd/eg/BUILD.bazel c/cmd/eg/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/file2fuzz/BUILD.bazel c/cmd/file2fuzz/BUILD.bazel ---- b/cmd/file2fuzz/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/file2fuzz/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/file2fuzz/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -528,7 +528,7 @@ diff -urN b/cmd/file2fuzz/BUILD.bazel c/cmd/file2fuzz/BUILD.bazel + embed = [":file2fuzz_lib"], +) diff -urN b/cmd/fiximports/BUILD.bazel c/cmd/fiximports/BUILD.bazel ---- b/cmd/fiximports/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/fiximports/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/fiximports/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,63 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -595,7 +595,7 @@ diff -urN b/cmd/fiximports/BUILD.bazel c/cmd/fiximports/BUILD.bazel + }), +) diff -urN b/cmd/fiximports/testdata/src/fruit.io/banana/BUILD.bazel c/cmd/fiximports/testdata/src/fruit.io/banana/BUILD.bazel ---- b/cmd/fiximports/testdata/src/fruit.io/banana/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/fiximports/testdata/src/fruit.io/banana/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/fiximports/testdata/src/fruit.io/banana/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -613,7 +613,7 @@ diff -urN b/cmd/fiximports/testdata/src/fruit.io/banana/BUILD.bazel c/cmd/fiximp + visibility = ["//visibility:public"], +) diff -urN b/cmd/fiximports/testdata/src/fruit.io/orange/BUILD.bazel c/cmd/fiximports/testdata/src/fruit.io/orange/BUILD.bazel ---- b/cmd/fiximports/testdata/src/fruit.io/orange/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/fiximports/testdata/src/fruit.io/orange/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/fiximports/testdata/src/fruit.io/orange/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -631,7 +631,7 @@ diff -urN b/cmd/fiximports/testdata/src/fruit.io/orange/BUILD.bazel c/cmd/fiximp + visibility = ["//visibility:public"], +) diff -urN b/cmd/fiximports/testdata/src/fruit.io/pear/BUILD.bazel c/cmd/fiximports/testdata/src/fruit.io/pear/BUILD.bazel ---- b/cmd/fiximports/testdata/src/fruit.io/pear/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/fiximports/testdata/src/fruit.io/pear/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/fiximports/testdata/src/fruit.io/pear/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -649,7 +649,7 @@ diff -urN b/cmd/fiximports/testdata/src/fruit.io/pear/BUILD.bazel c/cmd/fiximpor + visibility = ["//visibility:public"], +) diff -urN b/cmd/fiximports/testdata/src/new.com/one/BUILD.bazel c/cmd/fiximports/testdata/src/new.com/one/BUILD.bazel ---- b/cmd/fiximports/testdata/src/new.com/one/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/fiximports/testdata/src/new.com/one/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/fiximports/testdata/src/new.com/one/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -667,7 +667,7 @@ diff -urN b/cmd/fiximports/testdata/src/new.com/one/BUILD.bazel c/cmd/fiximports + visibility = ["//visibility:public"], +) diff -urN b/cmd/fiximports/testdata/src/old.com/bad/BUILD.bazel c/cmd/fiximports/testdata/src/old.com/bad/BUILD.bazel ---- b/cmd/fiximports/testdata/src/old.com/bad/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/fiximports/testdata/src/old.com/bad/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/fiximports/testdata/src/old.com/bad/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -685,7 +685,7 @@ diff -urN b/cmd/fiximports/testdata/src/old.com/bad/BUILD.bazel c/cmd/fiximports + visibility = ["//visibility:public"], +) diff -urN b/cmd/fiximports/testdata/src/old.com/one/BUILD.bazel c/cmd/fiximports/testdata/src/old.com/one/BUILD.bazel ---- b/cmd/fiximports/testdata/src/old.com/one/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/fiximports/testdata/src/old.com/one/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/fiximports/testdata/src/old.com/one/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -703,7 +703,7 @@ diff -urN b/cmd/fiximports/testdata/src/old.com/one/BUILD.bazel c/cmd/fiximports + visibility = ["//visibility:public"], +) diff -urN b/cmd/fiximports/testdata/src/titanic.biz/bar/BUILD.bazel c/cmd/fiximports/testdata/src/titanic.biz/bar/BUILD.bazel ---- b/cmd/fiximports/testdata/src/titanic.biz/bar/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/fiximports/testdata/src/titanic.biz/bar/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/fiximports/testdata/src/titanic.biz/bar/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -721,7 +721,7 @@ diff -urN b/cmd/fiximports/testdata/src/titanic.biz/bar/BUILD.bazel c/cmd/fiximp + visibility = ["//visibility:public"], +) diff -urN b/cmd/fiximports/testdata/src/titanic.biz/foo/BUILD.bazel c/cmd/fiximports/testdata/src/titanic.biz/foo/BUILD.bazel ---- b/cmd/fiximports/testdata/src/titanic.biz/foo/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/fiximports/testdata/src/titanic.biz/foo/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/fiximports/testdata/src/titanic.biz/foo/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -739,7 +739,7 @@ diff -urN b/cmd/fiximports/testdata/src/titanic.biz/foo/BUILD.bazel c/cmd/fiximp + visibility = ["//visibility:public"], +) diff -urN b/cmd/getgo/BUILD.bazel c/cmd/getgo/BUILD.bazel ---- b/cmd/getgo/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/getgo/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/getgo/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,74 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -817,7 +817,7 @@ diff -urN b/cmd/getgo/BUILD.bazel c/cmd/getgo/BUILD.bazel + embed = [":getgo_lib"], +) diff -urN b/cmd/getgo/server/BUILD.bazel c/cmd/getgo/server/BUILD.bazel ---- b/cmd/getgo/server/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/getgo/server/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/getgo/server/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -835,7 +835,7 @@ diff -urN b/cmd/getgo/server/BUILD.bazel c/cmd/getgo/server/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/go-contrib-init/BUILD.bazel c/cmd/go-contrib-init/BUILD.bazel ---- b/cmd/go-contrib-init/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/go-contrib-init/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/go-contrib-init/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,21 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -860,7 +860,7 @@ diff -urN b/cmd/go-contrib-init/BUILD.bazel c/cmd/go-contrib-init/BUILD.bazel + embed = [":go-contrib-init_lib"], +) diff -urN b/cmd/godex/BUILD.bazel c/cmd/godex/BUILD.bazel ---- b/cmd/godex/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/godex/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/godex/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -888,9 +888,9 @@ diff -urN b/cmd/godex/BUILD.bazel c/cmd/godex/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/godoc/BUILD.bazel c/cmd/godoc/BUILD.bazel ---- b/cmd/godoc/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/godoc/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/godoc/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,42 @@ +@@ -0,0 +1,41 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") + +go_library( @@ -905,7 +905,6 @@ diff -urN b/cmd/godoc/BUILD.bazel c/cmd/godoc/BUILD.bazel + visibility = ["//visibility:private"], + deps = [ + "//godoc", -+ "//godoc/analysis", + "//godoc/redirect", + "//godoc/static", + "//godoc/vfs", @@ -934,7 +933,7 @@ diff -urN b/cmd/godoc/BUILD.bazel c/cmd/godoc/BUILD.bazel + ], +) diff -urN b/cmd/goimports/BUILD.bazel c/cmd/goimports/BUILD.bazel ---- b/cmd/goimports/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/goimports/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/goimports/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,23 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -961,7 +960,7 @@ diff -urN b/cmd/goimports/BUILD.bazel c/cmd/goimports/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/gomvpkg/BUILD.bazel c/cmd/gomvpkg/BUILD.bazel ---- b/cmd/gomvpkg/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/gomvpkg/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/gomvpkg/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -983,7 +982,7 @@ diff -urN b/cmd/gomvpkg/BUILD.bazel c/cmd/gomvpkg/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/gorename/BUILD.bazel c/cmd/gorename/BUILD.bazel ---- b/cmd/gorename/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/gorename/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/gorename/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -1011,7 +1010,7 @@ diff -urN b/cmd/gorename/BUILD.bazel c/cmd/gorename/BUILD.bazel + deps = ["//internal/testenv"], +) diff -urN b/cmd/gotype/BUILD.bazel c/cmd/gotype/BUILD.bazel ---- b/cmd/gotype/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/gotype/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/gotype/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1033,7 +1032,7 @@ diff -urN b/cmd/gotype/BUILD.bazel c/cmd/gotype/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/goyacc/BUILD.bazel c/cmd/goyacc/BUILD.bazel ---- b/cmd/goyacc/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/goyacc/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/goyacc/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1054,7 +1053,7 @@ diff -urN b/cmd/goyacc/BUILD.bazel c/cmd/goyacc/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/goyacc/testdata/expr/BUILD.bazel c/cmd/goyacc/testdata/expr/BUILD.bazel ---- b/cmd/goyacc/testdata/expr/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/goyacc/testdata/expr/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/goyacc/testdata/expr/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1072,7 +1071,7 @@ diff -urN b/cmd/goyacc/testdata/expr/BUILD.bazel c/cmd/goyacc/testdata/expr/BUIL + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/BUILD.bazel c/cmd/guru/BUILD.bazel ---- b/cmd/guru/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,56 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -1132,7 +1131,7 @@ diff -urN b/cmd/guru/BUILD.bazel c/cmd/guru/BUILD.bazel + deps = ["//internal/testenv"], +) diff -urN b/cmd/guru/serial/BUILD.bazel c/cmd/guru/serial/BUILD.bazel ---- b/cmd/guru/serial/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/serial/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/serial/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -1150,7 +1149,7 @@ diff -urN b/cmd/guru/serial/BUILD.bazel c/cmd/guru/serial/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/alias/BUILD.bazel c/cmd/guru/testdata/src/alias/BUILD.bazel ---- b/cmd/guru/testdata/src/alias/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/alias/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/alias/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -1168,7 +1167,7 @@ diff -urN b/cmd/guru/testdata/src/alias/BUILD.bazel c/cmd/guru/testdata/src/alia + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/calls/BUILD.bazel c/cmd/guru/testdata/src/calls/BUILD.bazel ---- b/cmd/guru/testdata/src/calls/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/calls/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/calls/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1186,7 +1185,7 @@ diff -urN b/cmd/guru/testdata/src/calls/BUILD.bazel c/cmd/guru/testdata/src/call + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/calls-json/BUILD.bazel c/cmd/guru/testdata/src/calls-json/BUILD.bazel ---- b/cmd/guru/testdata/src/calls-json/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/calls-json/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/calls-json/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1204,7 +1203,7 @@ diff -urN b/cmd/guru/testdata/src/calls-json/BUILD.bazel c/cmd/guru/testdata/src + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/definition-json/BUILD.bazel c/cmd/guru/testdata/src/definition-json/BUILD.bazel ---- b/cmd/guru/testdata/src/definition-json/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/definition-json/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/definition-json/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -1225,7 +1224,7 @@ diff -urN b/cmd/guru/testdata/src/definition-json/BUILD.bazel c/cmd/guru/testdat + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/describe/BUILD.bazel c/cmd/guru/testdata/src/describe/BUILD.bazel ---- b/cmd/guru/testdata/src/describe/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/describe/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/describe/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -1243,7 +1242,7 @@ diff -urN b/cmd/guru/testdata/src/describe/BUILD.bazel c/cmd/guru/testdata/src/d + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/describe-json/BUILD.bazel c/cmd/guru/testdata/src/describe-json/BUILD.bazel ---- b/cmd/guru/testdata/src/describe-json/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/describe-json/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/describe-json/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -1261,7 +1260,7 @@ diff -urN b/cmd/guru/testdata/src/describe-json/BUILD.bazel c/cmd/guru/testdata/ + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/freevars/BUILD.bazel c/cmd/guru/testdata/src/freevars/BUILD.bazel ---- b/cmd/guru/testdata/src/freevars/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/freevars/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/freevars/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1279,7 +1278,7 @@ diff -urN b/cmd/guru/testdata/src/freevars/BUILD.bazel c/cmd/guru/testdata/src/f + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/implements/BUILD.bazel c/cmd/guru/testdata/src/implements/BUILD.bazel ---- b/cmd/guru/testdata/src/implements/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/implements/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/implements/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1297,7 +1296,7 @@ diff -urN b/cmd/guru/testdata/src/implements/BUILD.bazel c/cmd/guru/testdata/src + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/implements-json/BUILD.bazel c/cmd/guru/testdata/src/implements-json/BUILD.bazel ---- b/cmd/guru/testdata/src/implements-json/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/implements-json/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/implements-json/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1315,7 +1314,7 @@ diff -urN b/cmd/guru/testdata/src/implements-json/BUILD.bazel c/cmd/guru/testdat + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/implements-methods/BUILD.bazel c/cmd/guru/testdata/src/implements-methods/BUILD.bazel ---- b/cmd/guru/testdata/src/implements-methods/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/implements-methods/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/implements-methods/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1333,7 +1332,7 @@ diff -urN b/cmd/guru/testdata/src/implements-methods/BUILD.bazel c/cmd/guru/test + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/implements-methods-json/BUILD.bazel c/cmd/guru/testdata/src/implements-methods-json/BUILD.bazel ---- b/cmd/guru/testdata/src/implements-methods-json/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/implements-methods-json/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/implements-methods-json/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1351,7 +1350,7 @@ diff -urN b/cmd/guru/testdata/src/implements-methods-json/BUILD.bazel c/cmd/guru + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/imports/BUILD.bazel c/cmd/guru/testdata/src/imports/BUILD.bazel ---- b/cmd/guru/testdata/src/imports/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/imports/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/imports/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1369,7 +1368,7 @@ diff -urN b/cmd/guru/testdata/src/imports/BUILD.bazel c/cmd/guru/testdata/src/im + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/lib/BUILD.bazel c/cmd/guru/testdata/src/lib/BUILD.bazel ---- b/cmd/guru/testdata/src/lib/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/lib/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/lib/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -1387,7 +1386,7 @@ diff -urN b/cmd/guru/testdata/src/lib/BUILD.bazel c/cmd/guru/testdata/src/lib/BU + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/lib/sublib/BUILD.bazel c/cmd/guru/testdata/src/lib/sublib/BUILD.bazel ---- b/cmd/guru/testdata/src/lib/sublib/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/lib/sublib/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/lib/sublib/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -1405,7 +1404,7 @@ diff -urN b/cmd/guru/testdata/src/lib/sublib/BUILD.bazel c/cmd/guru/testdata/src + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/main/BUILD.bazel c/cmd/guru/testdata/src/main/BUILD.bazel ---- b/cmd/guru/testdata/src/main/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/main/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/main/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1423,7 +1422,7 @@ diff -urN b/cmd/guru/testdata/src/main/BUILD.bazel c/cmd/guru/testdata/src/main/ + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/peers/BUILD.bazel c/cmd/guru/testdata/src/peers/BUILD.bazel ---- b/cmd/guru/testdata/src/peers/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/peers/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/peers/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1441,7 +1440,7 @@ diff -urN b/cmd/guru/testdata/src/peers/BUILD.bazel c/cmd/guru/testdata/src/peer + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/peers-json/BUILD.bazel c/cmd/guru/testdata/src/peers-json/BUILD.bazel ---- b/cmd/guru/testdata/src/peers-json/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/peers-json/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/peers-json/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1459,7 +1458,7 @@ diff -urN b/cmd/guru/testdata/src/peers-json/BUILD.bazel c/cmd/guru/testdata/src + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/pointsto/BUILD.bazel c/cmd/guru/testdata/src/pointsto/BUILD.bazel ---- b/cmd/guru/testdata/src/pointsto/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/pointsto/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/pointsto/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1477,7 +1476,7 @@ diff -urN b/cmd/guru/testdata/src/pointsto/BUILD.bazel c/cmd/guru/testdata/src/p + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/pointsto-json/BUILD.bazel c/cmd/guru/testdata/src/pointsto-json/BUILD.bazel ---- b/cmd/guru/testdata/src/pointsto-json/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/pointsto-json/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/pointsto-json/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1495,7 +1494,7 @@ diff -urN b/cmd/guru/testdata/src/pointsto-json/BUILD.bazel c/cmd/guru/testdata/ + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/referrers/BUILD.bazel c/cmd/guru/testdata/src/referrers/BUILD.bazel ---- b/cmd/guru/testdata/src/referrers/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/referrers/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/referrers/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,23 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") @@ -1522,7 +1521,7 @@ diff -urN b/cmd/guru/testdata/src/referrers/BUILD.bazel c/cmd/guru/testdata/src/ + embed = [":referrers_lib"], +) diff -urN b/cmd/guru/testdata/src/referrers-json/BUILD.bazel c/cmd/guru/testdata/src/referrers-json/BUILD.bazel ---- b/cmd/guru/testdata/src/referrers-json/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/referrers-json/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/referrers-json/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1540,7 +1539,7 @@ diff -urN b/cmd/guru/testdata/src/referrers-json/BUILD.bazel c/cmd/guru/testdata + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/reflection/BUILD.bazel c/cmd/guru/testdata/src/reflection/BUILD.bazel ---- b/cmd/guru/testdata/src/reflection/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/reflection/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/reflection/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1558,7 +1557,7 @@ diff -urN b/cmd/guru/testdata/src/reflection/BUILD.bazel c/cmd/guru/testdata/src + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/softerrs/BUILD.bazel c/cmd/guru/testdata/src/softerrs/BUILD.bazel ---- b/cmd/guru/testdata/src/softerrs/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/softerrs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/softerrs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1576,7 +1575,7 @@ diff -urN b/cmd/guru/testdata/src/softerrs/BUILD.bazel c/cmd/guru/testdata/src/s + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/what/BUILD.bazel c/cmd/guru/testdata/src/what/BUILD.bazel ---- b/cmd/guru/testdata/src/what/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/what/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/what/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1594,7 +1593,7 @@ diff -urN b/cmd/guru/testdata/src/what/BUILD.bazel c/cmd/guru/testdata/src/what/ + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/what-json/BUILD.bazel c/cmd/guru/testdata/src/what-json/BUILD.bazel ---- b/cmd/guru/testdata/src/what-json/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/what-json/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/what-json/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1612,7 +1611,7 @@ diff -urN b/cmd/guru/testdata/src/what-json/BUILD.bazel c/cmd/guru/testdata/src/ + visibility = ["//visibility:public"], +) diff -urN b/cmd/guru/testdata/src/whicherrs/BUILD.bazel c/cmd/guru/testdata/src/whicherrs/BUILD.bazel ---- b/cmd/guru/testdata/src/whicherrs/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/guru/testdata/src/whicherrs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/guru/testdata/src/whicherrs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1630,7 +1629,7 @@ diff -urN b/cmd/guru/testdata/src/whicherrs/BUILD.bazel c/cmd/guru/testdata/src/ + visibility = ["//visibility:public"], +) diff -urN b/cmd/html2article/BUILD.bazel c/cmd/html2article/BUILD.bazel ---- b/cmd/html2article/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/html2article/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/html2article/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1652,7 +1651,7 @@ diff -urN b/cmd/html2article/BUILD.bazel c/cmd/html2article/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/present/BUILD.bazel c/cmd/present/BUILD.bazel ---- b/cmd/present/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/present/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/present/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,25 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1681,7 +1680,7 @@ diff -urN b/cmd/present/BUILD.bazel c/cmd/present/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/present2md/BUILD.bazel c/cmd/present2md/BUILD.bazel ---- b/cmd/present2md/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/present2md/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/present2md/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1700,7 +1699,7 @@ diff -urN b/cmd/present2md/BUILD.bazel c/cmd/present2md/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/splitdwarf/BUILD.bazel c/cmd/splitdwarf/BUILD.bazel ---- b/cmd/splitdwarf/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/splitdwarf/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/splitdwarf/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,47 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1751,7 +1750,7 @@ diff -urN b/cmd/splitdwarf/BUILD.bazel c/cmd/splitdwarf/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/splitdwarf/internal/macho/BUILD.bazel c/cmd/splitdwarf/internal/macho/BUILD.bazel ---- b/cmd/splitdwarf/internal/macho/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/splitdwarf/internal/macho/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/splitdwarf/internal/macho/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,27 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -1782,7 +1781,7 @@ diff -urN b/cmd/splitdwarf/internal/macho/BUILD.bazel c/cmd/splitdwarf/internal/ + embed = [":macho"], +) diff -urN b/cmd/ssadump/BUILD.bazel c/cmd/ssadump/BUILD.bazel ---- b/cmd/ssadump/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/ssadump/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/ssadump/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,21 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1807,7 +1806,7 @@ diff -urN b/cmd/ssadump/BUILD.bazel c/cmd/ssadump/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/stress/BUILD.bazel c/cmd/stress/BUILD.bazel ---- b/cmd/stress/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/stress/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/stress/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,56 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1867,9 +1866,9 @@ diff -urN b/cmd/stress/BUILD.bazel c/cmd/stress/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/cmd/stringer/BUILD.bazel c/cmd/stringer/BUILD.bazel ---- b/cmd/stringer/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/stringer/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/stringer/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,26 @@ +@@ -0,0 +1,69 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") + +go_library( @@ -1894,10 +1893,53 @@ diff -urN b/cmd/stringer/BUILD.bazel c/cmd/stringer/BUILD.bazel + "util_test.go", + ], + embed = [":stringer_lib"], -+ deps = ["//internal/testenv"], ++ deps = [ ++ "//internal/testenv", ++ ] + select({ ++ "@io_bazel_rules_go//go/platform:aix": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:darwin": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:dragonfly": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:freebsd": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:illumos": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:ios": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:js": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:linux": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:netbsd": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:openbsd": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:plan9": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:solaris": [ ++ "//internal/typeparams", ++ ], ++ "@io_bazel_rules_go//go/platform:windows": [ ++ "//internal/typeparams", ++ ], ++ "//conditions:default": [], ++ }), +) diff -urN b/cmd/stringer/testdata/BUILD.bazel c/cmd/stringer/testdata/BUILD.bazel ---- b/cmd/stringer/testdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/stringer/testdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/stringer/testdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,27 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1927,8 +1969,29 @@ diff -urN b/cmd/stringer/testdata/BUILD.bazel c/cmd/stringer/testdata/BUILD.baze + embed = [":testdata_lib"], + visibility = ["//visibility:public"], +) +diff -urN b/cmd/stringer/testdata/typeparams/BUILD.bazel c/cmd/stringer/testdata/typeparams/BUILD.bazel +--- b/cmd/stringer/testdata/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/cmd/stringer/testdata/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,17 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") ++ ++go_library( ++ name = "typeparams_lib", ++ srcs = [ ++ "conv2.go", ++ "prime2.go", ++ ], ++ importpath = "golang.org/x/tools/cmd/stringer/testdata/typeparams", ++ visibility = ["//visibility:private"], ++) ++ ++go_binary( ++ name = "typeparams", ++ embed = [":typeparams_lib"], ++ visibility = ["//visibility:public"], ++) diff -urN b/cmd/toolstash/BUILD.bazel c/cmd/toolstash/BUILD.bazel ---- b/cmd/toolstash/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cmd/toolstash/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cmd/toolstash/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -1950,7 +2013,7 @@ diff -urN b/cmd/toolstash/BUILD.bazel c/cmd/toolstash/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/container/intsets/BUILD.bazel c/container/intsets/BUILD.bazel ---- b/container/intsets/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/container/intsets/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/container/intsets/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -1983,7 +2046,7 @@ diff -urN b/container/intsets/BUILD.bazel c/container/intsets/BUILD.bazel + embed = [":intsets"], +) diff -urN b/copyright/BUILD.bazel c/copyright/BUILD.bazel ---- b/copyright/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/copyright/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/copyright/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -2007,7 +2070,7 @@ diff -urN b/copyright/BUILD.bazel c/copyright/BUILD.bazel + embed = [":copyright"], +) diff -urN b/cover/BUILD.bazel c/cover/BUILD.bazel ---- b/cover/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/cover/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/cover/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -2030,38 +2093,8 @@ diff -urN b/cover/BUILD.bazel c/cover/BUILD.bazel + srcs = ["profile_test.go"], + embed = [":cover"], +) -diff -urN b/go/analysis/BUILD.bazel c/go/analysis/BUILD.bazel ---- b/go/analysis/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/go/analysis/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,26 @@ -+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") -+ -+go_library( -+ name = "analysis", -+ srcs = [ -+ "analysis.go", -+ "diagnostic.go", -+ "doc.go", -+ "validate.go", -+ ], -+ importpath = "golang.org/x/tools/go/analysis", -+ visibility = ["//visibility:public"], -+ deps = ["//internal/analysisinternal"], -+) -+ -+alias( -+ name = "go_default_library", -+ actual = ":analysis", -+ visibility = ["//visibility:public"], -+) -+ -+go_test( -+ name = "analysis_test", -+ srcs = ["validate_test.go"], -+ embed = [":analysis"], -+) diff -urN b/go/analysis/analysistest/BUILD.bazel c/go/analysis/analysistest/BUILD.bazel ---- b/go/analysis/analysistest/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/analysistest/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/analysistest/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,34 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -2098,8 +2131,38 @@ diff -urN b/go/analysis/analysistest/BUILD.bazel c/go/analysis/analysistest/BUIL + "//internal/testenv", + ], +) +diff -urN b/go/analysis/BUILD.bazel c/go/analysis/BUILD.bazel +--- b/go/analysis/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,26 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") ++ ++go_library( ++ name = "analysis", ++ srcs = [ ++ "analysis.go", ++ "diagnostic.go", ++ "doc.go", ++ "validate.go", ++ ], ++ importpath = "golang.org/x/tools/go/analysis", ++ visibility = ["//visibility:public"], ++ deps = ["//internal/analysisinternal"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":analysis", ++ visibility = ["//visibility:public"], ++) ++ ++go_test( ++ name = "analysis_test", ++ srcs = ["validate_test.go"], ++ embed = [":analysis"], ++) diff -urN b/go/analysis/internal/analysisflags/BUILD.bazel c/go/analysis/internal/analysisflags/BUILD.bazel ---- b/go/analysis/internal/analysisflags/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/internal/analysisflags/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/internal/analysisflags/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,27 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -2130,7 +2193,7 @@ diff -urN b/go/analysis/internal/analysisflags/BUILD.bazel c/go/analysis/interna + ], +) diff -urN b/go/analysis/internal/checker/BUILD.bazel c/go/analysis/internal/checker/BUILD.bazel ---- b/go/analysis/internal/checker/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/internal/checker/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/internal/checker/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,34 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -2168,9 +2231,9 @@ diff -urN b/go/analysis/internal/checker/BUILD.bazel c/go/analysis/internal/chec + ], +) diff -urN b/go/analysis/internal/facts/BUILD.bazel c/go/analysis/internal/facts/BUILD.bazel ---- b/go/analysis/internal/facts/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/internal/facts/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/internal/facts/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,32 @@ +@@ -0,0 +1,34 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -2180,17 +2243,18 @@ diff -urN b/go/analysis/internal/facts/BUILD.bazel c/go/analysis/internal/facts/ + "imports.go", + ], + importpath = "golang.org/x/tools/go/analysis/internal/facts", -+ visibility = ["//go/analysis:__subpackages__"], ++ visibility = ["//visibility:public"], + deps = [ + "//go/analysis", + "//go/types/objectpath", ++ "//internal/typeparams", + ], +) + +alias( + name = "go_default_library", + actual = ":facts", -+ visibility = ["//go/analysis:__subpackages__"], ++ visibility = ["//visibility:public"], +) + +go_test( @@ -2201,10 +2265,11 @@ diff -urN b/go/analysis/internal/facts/BUILD.bazel c/go/analysis/internal/facts/ + "//go/analysis/analysistest", + "//go/packages", + "//internal/testenv", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/multichecker/BUILD.bazel c/go/analysis/multichecker/BUILD.bazel ---- b/go/analysis/multichecker/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/multichecker/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/multichecker/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,31 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -2239,7 +2304,7 @@ diff -urN b/go/analysis/multichecker/BUILD.bazel c/go/analysis/multichecker/BUIL + ], +) diff -urN b/go/analysis/passes/asmdecl/BUILD.bazel c/go/analysis/passes/asmdecl/BUILD.bazel ---- b/go/analysis/passes/asmdecl/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/asmdecl/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/asmdecl/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,27 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -2270,7 +2335,7 @@ diff -urN b/go/analysis/passes/asmdecl/BUILD.bazel c/go/analysis/passes/asmdecl/ + ], +) diff -urN b/go/analysis/passes/asmdecl/testdata/src/a/BUILD.bazel c/go/analysis/passes/asmdecl/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/asmdecl/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/asmdecl/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/asmdecl/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,25 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2299,9 +2364,9 @@ diff -urN b/go/analysis/passes/asmdecl/testdata/src/a/BUILD.bazel c/go/analysis/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/assign/BUILD.bazel c/go/analysis/passes/assign/BUILD.bazel ---- b/go/analysis/passes/assign/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/assign/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/assign/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -2329,10 +2394,11 @@ diff -urN b/go/analysis/passes/assign/BUILD.bazel c/go/analysis/passes/assign/BU + deps = [ + ":assign", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/assign/testdata/src/a/BUILD.bazel c/go/analysis/passes/assign/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/assign/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/assign/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/assign/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2349,10 +2415,28 @@ diff -urN b/go/analysis/passes/assign/testdata/src/a/BUILD.bazel c/go/analysis/p + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/assign/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/assign/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/assign/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/assign/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/assign/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/atomic/BUILD.bazel c/go/analysis/passes/atomic/BUILD.bazel ---- b/go/analysis/passes/atomic/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/atomic/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/atomic/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -2380,10 +2464,11 @@ diff -urN b/go/analysis/passes/atomic/BUILD.bazel c/go/analysis/passes/atomic/BU + deps = [ + ":atomic", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/atomic/testdata/src/a/BUILD.bazel c/go/analysis/passes/atomic/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/atomic/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/atomic/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/atomic/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2400,8 +2485,26 @@ diff -urN b/go/analysis/passes/atomic/testdata/src/a/BUILD.bazel c/go/analysis/p + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/atomic/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/atomic/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/atomic/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/atomic/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/atomic/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/atomicalign/BUILD.bazel c/go/analysis/passes/atomicalign/BUILD.bazel ---- b/go/analysis/passes/atomicalign/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/atomicalign/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/atomicalign/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -2434,7 +2537,7 @@ diff -urN b/go/analysis/passes/atomicalign/BUILD.bazel c/go/analysis/passes/atom + ], +) diff -urN b/go/analysis/passes/atomicalign/testdata/src/a/BUILD.bazel c/go/analysis/passes/atomicalign/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/atomicalign/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/atomicalign/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/atomicalign/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2455,7 +2558,7 @@ diff -urN b/go/analysis/passes/atomicalign/testdata/src/a/BUILD.bazel c/go/analy + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/atomicalign/testdata/src/b/BUILD.bazel c/go/analysis/passes/atomicalign/testdata/src/b/BUILD.bazel ---- b/go/analysis/passes/atomicalign/testdata/src/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/atomicalign/testdata/src/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/atomicalign/testdata/src/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2476,9 +2579,9 @@ diff -urN b/go/analysis/passes/atomicalign/testdata/src/b/BUILD.bazel c/go/analy + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/bools/BUILD.bazel c/go/analysis/passes/bools/BUILD.bazel ---- b/go/analysis/passes/bools/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/bools/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/bools/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -2506,10 +2609,11 @@ diff -urN b/go/analysis/passes/bools/BUILD.bazel c/go/analysis/passes/bools/BUIL + deps = [ + ":bools", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/bools/testdata/src/a/BUILD.bazel c/go/analysis/passes/bools/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/bools/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/bools/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/bools/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2526,8 +2630,26 @@ diff -urN b/go/analysis/passes/bools/testdata/src/a/BUILD.bazel c/go/analysis/pa + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/bools/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/bools/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/bools/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/bools/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/bools/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/buildssa/BUILD.bazel c/go/analysis/passes/buildssa/BUILD.bazel ---- b/go/analysis/passes/buildssa/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/buildssa/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/buildssa/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,27 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -2558,7 +2680,7 @@ diff -urN b/go/analysis/passes/buildssa/BUILD.bazel c/go/analysis/passes/buildss + ], +) diff -urN b/go/analysis/passes/buildssa/testdata/src/a/BUILD.bazel c/go/analysis/passes/buildssa/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/buildssa/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/buildssa/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/buildssa/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2576,7 +2698,7 @@ diff -urN b/go/analysis/passes/buildssa/testdata/src/a/BUILD.bazel c/go/analysis + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/buildtag/BUILD.bazel c/go/analysis/passes/buildtag/BUILD.bazel ---- b/go/analysis/passes/buildtag/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/buildtag/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/buildtag/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,31 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -2611,7 +2733,7 @@ diff -urN b/go/analysis/passes/buildtag/BUILD.bazel c/go/analysis/passes/buildta + ], +) diff -urN b/go/analysis/passes/buildtag/testdata/src/a/BUILD.bazel c/go/analysis/passes/buildtag/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/buildtag/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/buildtag/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/buildtag/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2633,9 +2755,9 @@ diff -urN b/go/analysis/passes/buildtag/testdata/src/a/BUILD.bazel c/go/analysis + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/cgocall/BUILD.bazel c/go/analysis/passes/cgocall/BUILD.bazel ---- b/go/analysis/passes/cgocall/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/cgocall/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/cgocall/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,27 @@ +@@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -2661,10 +2783,11 @@ diff -urN b/go/analysis/passes/cgocall/BUILD.bazel c/go/analysis/passes/cgocall/ + deps = [ + ":cgocall", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/cgocall/testdata/src/a/BUILD.bazel c/go/analysis/passes/cgocall/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/cgocall/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/cgocall/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/cgocall/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2686,7 +2809,7 @@ diff -urN b/go/analysis/passes/cgocall/testdata/src/a/BUILD.bazel c/go/analysis/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/cgocall/testdata/src/b/BUILD.bazel c/go/analysis/passes/cgocall/testdata/src/b/BUILD.bazel ---- b/go/analysis/passes/cgocall/testdata/src/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/cgocall/testdata/src/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/cgocall/testdata/src/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2704,7 +2827,7 @@ diff -urN b/go/analysis/passes/cgocall/testdata/src/b/BUILD.bazel c/go/analysis/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/cgocall/testdata/src/c/BUILD.bazel c/go/analysis/passes/cgocall/testdata/src/c/BUILD.bazel ---- b/go/analysis/passes/cgocall/testdata/src/c/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/cgocall/testdata/src/c/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/cgocall/testdata/src/c/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2721,10 +2844,29 @@ diff -urN b/go/analysis/passes/cgocall/testdata/src/c/BUILD.bazel c/go/analysis/ + actual = ":c", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/cgocall/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/cgocall/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/cgocall/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/cgocall/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,15 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ cgo = True, ++ importpath = "golang.org/x/tools/go/analysis/passes/cgocall/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/composite/BUILD.bazel c/go/analysis/passes/composite/BUILD.bazel ---- b/go/analysis/passes/composite/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/composite/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/composite/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,31 @@ +@@ -0,0 +1,33 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -2739,6 +2881,7 @@ diff -urN b/go/analysis/passes/composite/BUILD.bazel c/go/analysis/passes/compos + "//go/analysis", + "//go/analysis/passes/inspect", + "//go/ast/inspector", ++ "//internal/typeparams", + ], +) + @@ -2754,10 +2897,11 @@ diff -urN b/go/analysis/passes/composite/BUILD.bazel c/go/analysis/passes/compos + deps = [ + ":composite", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/composite/testdata/src/a/BUILD.bazel c/go/analysis/passes/composite/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/composite/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/composite/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/composite/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2774,10 +2918,46 @@ diff -urN b/go/analysis/passes/composite/testdata/src/a/BUILD.bazel c/go/analysi + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/composite/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/composite/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/composite/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/composite/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/composite/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) +diff -urN b/go/analysis/passes/composite/testdata/src/typeparams/lib/BUILD.bazel c/go/analysis/passes/composite/testdata/src/typeparams/lib/BUILD.bazel +--- b/go/analysis/passes/composite/testdata/src/typeparams/lib/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/composite/testdata/src/typeparams/lib/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "lib", ++ srcs = ["lib.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/composite/testdata/src/typeparams/lib", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":lib", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/copylock/BUILD.bazel c/go/analysis/passes/copylock/BUILD.bazel ---- b/go/analysis/passes/copylock/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/copylock/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/copylock/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,31 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -2790,6 +2970,7 @@ diff -urN b/go/analysis/passes/copylock/BUILD.bazel c/go/analysis/passes/copyloc + "//go/analysis/passes/inspect", + "//go/analysis/passes/internal/analysisutil", + "//go/ast/inspector", ++ "//internal/typeparams", + ], +) + @@ -2805,10 +2986,11 @@ diff -urN b/go/analysis/passes/copylock/BUILD.bazel c/go/analysis/passes/copyloc + deps = [ + ":copylock", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/copylock/testdata/src/a/BUILD.bazel c/go/analysis/passes/copylock/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/copylock/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/copylock/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/copylock/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2829,15 +3011,33 @@ diff -urN b/go/analysis/passes/copylock/testdata/src/a/BUILD.bazel c/go/analysis + actual = ":a", + visibility = ["//visibility:public"], +) -diff -urN b/go/analysis/passes/ctrlflow/BUILD.bazel c/go/analysis/passes/ctrlflow/BUILD.bazel ---- b/go/analysis/passes/ctrlflow/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/go/analysis/passes/ctrlflow/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,30 @@ -+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") +diff -urN b/go/analysis/passes/copylock/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/copylock/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/copylock/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/copylock/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") + +go_library( -+ name = "ctrlflow", -+ srcs = ["ctrlflow.go"], ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/copylock/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) +diff -urN b/go/analysis/passes/ctrlflow/BUILD.bazel c/go/analysis/passes/ctrlflow/BUILD.bazel +--- b/go/analysis/passes/ctrlflow/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/ctrlflow/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,31 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") ++ ++go_library( ++ name = "ctrlflow", ++ srcs = ["ctrlflow.go"], + importpath = "golang.org/x/tools/go/analysis/passes/ctrlflow", + visibility = ["//visibility:public"], + deps = [ @@ -2861,10 +3061,11 @@ diff -urN b/go/analysis/passes/ctrlflow/BUILD.bazel c/go/analysis/passes/ctrlflo + deps = [ + ":ctrlflow", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/ctrlflow/testdata/src/a/BUILD.bazel c/go/analysis/passes/ctrlflow/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/ctrlflow/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/ctrlflow/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/ctrlflow/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2882,7 +3083,7 @@ diff -urN b/go/analysis/passes/ctrlflow/testdata/src/a/BUILD.bazel c/go/analysis + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/ctrlflow/testdata/src/lib/BUILD.bazel c/go/analysis/passes/ctrlflow/testdata/src/lib/BUILD.bazel ---- b/go/analysis/passes/ctrlflow/testdata/src/lib/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/ctrlflow/testdata/src/lib/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/ctrlflow/testdata/src/lib/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2899,10 +3100,28 @@ diff -urN b/go/analysis/passes/ctrlflow/testdata/src/lib/BUILD.bazel c/go/analys + actual = ":lib", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/ctrlflow/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/ctrlflow/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/ctrlflow/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/ctrlflow/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/ctrlflow/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/deepequalerrors/BUILD.bazel c/go/analysis/passes/deepequalerrors/BUILD.bazel ---- b/go/analysis/passes/deepequalerrors/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/deepequalerrors/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/deepequalerrors/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -2930,10 +3149,11 @@ diff -urN b/go/analysis/passes/deepequalerrors/BUILD.bazel c/go/analysis/passes/ + deps = [ + ":deepequalerrors", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/deepequalerrors/testdata/src/a/BUILD.bazel c/go/analysis/passes/deepequalerrors/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/deepequalerrors/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/deepequalerrors/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/deepequalerrors/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -2950,10 +3170,28 @@ diff -urN b/go/analysis/passes/deepequalerrors/testdata/src/a/BUILD.bazel c/go/a + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/deepequalerrors/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/deepequalerrors/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/deepequalerrors/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/deepequalerrors/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/deepequalerrors/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/errorsas/BUILD.bazel c/go/analysis/passes/errorsas/BUILD.bazel ---- b/go/analysis/passes/errorsas/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/errorsas/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/errorsas/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -2981,10 +3219,11 @@ diff -urN b/go/analysis/passes/errorsas/BUILD.bazel c/go/analysis/passes/errorsa + deps = [ + ":errorsas", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/errorsas/testdata/src/a/BUILD.bazel c/go/analysis/passes/errorsas/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/errorsas/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/errorsas/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/errorsas/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3001,8 +3240,26 @@ diff -urN b/go/analysis/passes/errorsas/testdata/src/a/BUILD.bazel c/go/analysis + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/errorsas/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/errorsas/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/errorsas/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/errorsas/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/errorsas/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/fieldalignment/BUILD.bazel c/go/analysis/passes/fieldalignment/BUILD.bazel ---- b/go/analysis/passes/fieldalignment/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/fieldalignment/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/fieldalignment/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -3034,7 +3291,7 @@ diff -urN b/go/analysis/passes/fieldalignment/BUILD.bazel c/go/analysis/passes/f + ], +) diff -urN b/go/analysis/passes/fieldalignment/cmd/fieldalignment/BUILD.bazel c/go/analysis/passes/fieldalignment/cmd/fieldalignment/BUILD.bazel ---- b/go/analysis/passes/fieldalignment/cmd/fieldalignment/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/fieldalignment/cmd/fieldalignment/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/fieldalignment/cmd/fieldalignment/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -3056,7 +3313,7 @@ diff -urN b/go/analysis/passes/fieldalignment/cmd/fieldalignment/BUILD.bazel c/g + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/fieldalignment/testdata/src/a/BUILD.bazel c/go/analysis/passes/fieldalignment/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/fieldalignment/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/fieldalignment/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/fieldalignment/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3078,7 +3335,7 @@ diff -urN b/go/analysis/passes/fieldalignment/testdata/src/a/BUILD.bazel c/go/an + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/findcall/BUILD.bazel c/go/analysis/passes/findcall/BUILD.bazel ---- b/go/analysis/passes/findcall/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/findcall/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/findcall/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -3106,7 +3363,7 @@ diff -urN b/go/analysis/passes/findcall/BUILD.bazel c/go/analysis/passes/findcal + ], +) diff -urN b/go/analysis/passes/findcall/cmd/findcall/BUILD.bazel c/go/analysis/passes/findcall/cmd/findcall/BUILD.bazel ---- b/go/analysis/passes/findcall/cmd/findcall/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/findcall/cmd/findcall/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/findcall/cmd/findcall/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -3128,7 +3385,7 @@ diff -urN b/go/analysis/passes/findcall/cmd/findcall/BUILD.bazel c/go/analysis/p + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/findcall/testdata/src/a/BUILD.bazel c/go/analysis/passes/findcall/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/findcall/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/findcall/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/findcall/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -3146,7 +3403,7 @@ diff -urN b/go/analysis/passes/findcall/testdata/src/a/BUILD.bazel c/go/analysis + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/framepointer/BUILD.bazel c/go/analysis/passes/framepointer/BUILD.bazel ---- b/go/analysis/passes/framepointer/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/framepointer/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/framepointer/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,27 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -3177,7 +3434,7 @@ diff -urN b/go/analysis/passes/framepointer/BUILD.bazel c/go/analysis/passes/fra + ], +) diff -urN b/go/analysis/passes/framepointer/testdata/src/a/BUILD.bazel c/go/analysis/passes/framepointer/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/framepointer/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/framepointer/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/framepointer/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3201,9 +3458,9 @@ diff -urN b/go/analysis/passes/framepointer/testdata/src/a/BUILD.bazel c/go/anal + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/httpresponse/BUILD.bazel c/go/analysis/passes/httpresponse/BUILD.bazel ---- b/go/analysis/passes/httpresponse/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/httpresponse/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/httpresponse/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -3231,10 +3488,11 @@ diff -urN b/go/analysis/passes/httpresponse/BUILD.bazel c/go/analysis/passes/htt + deps = [ + ":httpresponse", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/httpresponse/testdata/src/a/BUILD.bazel c/go/analysis/passes/httpresponse/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/httpresponse/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/httpresponse/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/httpresponse/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3251,10 +3509,28 @@ diff -urN b/go/analysis/passes/httpresponse/testdata/src/a/BUILD.bazel c/go/anal + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/httpresponse/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/httpresponse/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/httpresponse/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/httpresponse/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/httpresponse/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/ifaceassert/BUILD.bazel c/go/analysis/passes/ifaceassert/BUILD.bazel ---- b/go/analysis/passes/ifaceassert/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/ifaceassert/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/ifaceassert/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,28 @@ +@@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -3281,10 +3557,11 @@ diff -urN b/go/analysis/passes/ifaceassert/BUILD.bazel c/go/analysis/passes/ifac + deps = [ + ":ifaceassert", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/ifaceassert/cmd/ifaceassert/BUILD.bazel c/go/analysis/passes/ifaceassert/cmd/ifaceassert/BUILD.bazel ---- b/go/analysis/passes/ifaceassert/cmd/ifaceassert/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/ifaceassert/cmd/ifaceassert/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/ifaceassert/cmd/ifaceassert/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -3306,7 +3583,7 @@ diff -urN b/go/analysis/passes/ifaceassert/cmd/ifaceassert/BUILD.bazel c/go/anal + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/ifaceassert/testdata/src/a/BUILD.bazel c/go/analysis/passes/ifaceassert/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/ifaceassert/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/ifaceassert/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/ifaceassert/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3323,8 +3600,26 @@ diff -urN b/go/analysis/passes/ifaceassert/testdata/src/a/BUILD.bazel c/go/analy + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/ifaceassert/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/ifaceassert/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/ifaceassert/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/ifaceassert/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/ifaceassert/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/inspect/BUILD.bazel c/go/analysis/passes/inspect/BUILD.bazel ---- b/go/analysis/passes/inspect/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/inspect/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/inspect/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3346,10 +3641,10 @@ diff -urN b/go/analysis/passes/inspect/BUILD.bazel c/go/analysis/passes/inspect/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/internal/analysisutil/BUILD.bazel c/go/analysis/passes/internal/analysisutil/BUILD.bazel ---- b/go/analysis/passes/internal/analysisutil/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/internal/analysisutil/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/internal/analysisutil/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,14 @@ -+load("@io_bazel_rules_go//go:def.bzl", "go_library") +@@ -0,0 +1,23 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( + name = "analysisutil", @@ -3363,10 +3658,19 @@ diff -urN b/go/analysis/passes/internal/analysisutil/BUILD.bazel c/go/analysis/p + actual = ":analysisutil", + visibility = ["//go/analysis/passes:__subpackages__"], +) ++ ++go_test( ++ name = "analysisutil_test", ++ srcs = ["util_test.go"], ++ deps = [ ++ ":analysisutil", ++ "//internal/typeparams", ++ ], ++) diff -urN b/go/analysis/passes/loopclosure/BUILD.bazel c/go/analysis/passes/loopclosure/BUILD.bazel ---- b/go/analysis/passes/loopclosure/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/loopclosure/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/loopclosure/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -3394,10 +3698,11 @@ diff -urN b/go/analysis/passes/loopclosure/BUILD.bazel c/go/analysis/passes/loop + deps = [ + ":loopclosure", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/loopclosure/testdata/src/a/BUILD.bazel c/go/analysis/passes/loopclosure/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/loopclosure/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/loopclosure/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/loopclosure/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3416,7 +3721,7 @@ diff -urN b/go/analysis/passes/loopclosure/testdata/src/a/BUILD.bazel c/go/analy + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/loopclosure/testdata/src/golang.org/x/sync/errgroup/BUILD.bazel c/go/analysis/passes/loopclosure/testdata/src/golang.org/x/sync/errgroup/BUILD.bazel ---- b/go/analysis/passes/loopclosure/testdata/src/golang.org/x/sync/errgroup/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/loopclosure/testdata/src/golang.org/x/sync/errgroup/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/loopclosure/testdata/src/golang.org/x/sync/errgroup/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3433,10 +3738,29 @@ diff -urN b/go/analysis/passes/loopclosure/testdata/src/golang.org/x/sync/errgro + actual = ":errgroup", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/loopclosure/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/loopclosure/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/loopclosure/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/loopclosure/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,15 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/loopclosure/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++ deps = ["@org_golang_x_sync//errgroup:go_default_library"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/lostcancel/BUILD.bazel c/go/analysis/passes/lostcancel/BUILD.bazel ---- b/go/analysis/passes/lostcancel/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/lostcancel/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/lostcancel/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,30 @@ +@@ -0,0 +1,31 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -3465,10 +3789,11 @@ diff -urN b/go/analysis/passes/lostcancel/BUILD.bazel c/go/analysis/passes/lostc + deps = [ + ":lostcancel", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/lostcancel/cmd/lostcancel/BUILD.bazel c/go/analysis/passes/lostcancel/cmd/lostcancel/BUILD.bazel ---- b/go/analysis/passes/lostcancel/cmd/lostcancel/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/lostcancel/cmd/lostcancel/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/lostcancel/cmd/lostcancel/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -3490,7 +3815,7 @@ diff -urN b/go/analysis/passes/lostcancel/cmd/lostcancel/BUILD.bazel c/go/analys + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/lostcancel/testdata/src/a/BUILD.bazel c/go/analysis/passes/lostcancel/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/lostcancel/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/lostcancel/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/lostcancel/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3508,7 +3833,7 @@ diff -urN b/go/analysis/passes/lostcancel/testdata/src/a/BUILD.bazel c/go/analys + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/lostcancel/testdata/src/b/BUILD.bazel c/go/analysis/passes/lostcancel/testdata/src/b/BUILD.bazel ---- b/go/analysis/passes/lostcancel/testdata/src/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/lostcancel/testdata/src/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/lostcancel/testdata/src/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -3525,10 +3850,28 @@ diff -urN b/go/analysis/passes/lostcancel/testdata/src/b/BUILD.bazel c/go/analys + embed = [":b_lib"], + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/lostcancel/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/lostcancel/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/lostcancel/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/lostcancel/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/lostcancel/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/nilfunc/BUILD.bazel c/go/analysis/passes/nilfunc/BUILD.bazel ---- b/go/analysis/passes/nilfunc/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/nilfunc/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/nilfunc/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,28 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -3540,6 +3883,7 @@ diff -urN b/go/analysis/passes/nilfunc/BUILD.bazel c/go/analysis/passes/nilfunc/ + "//go/analysis", + "//go/analysis/passes/inspect", + "//go/ast/inspector", ++ "//internal/typeparams", + ], +) + @@ -3555,10 +3899,11 @@ diff -urN b/go/analysis/passes/nilfunc/BUILD.bazel c/go/analysis/passes/nilfunc/ + deps = [ + ":nilfunc", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/nilfunc/testdata/src/a/BUILD.bazel c/go/analysis/passes/nilfunc/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/nilfunc/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/nilfunc/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/nilfunc/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3575,8 +3920,26 @@ diff -urN b/go/analysis/passes/nilfunc/testdata/src/a/BUILD.bazel c/go/analysis/ + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/nilfunc/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/nilfunc/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/nilfunc/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/nilfunc/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/nilfunc/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/nilness/BUILD.bazel c/go/analysis/passes/nilness/BUILD.bazel ---- b/go/analysis/passes/nilness/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/nilness/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/nilness/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,31 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -3611,7 +3974,7 @@ diff -urN b/go/analysis/passes/nilness/BUILD.bazel c/go/analysis/passes/nilness/ + ], +) diff -urN b/go/analysis/passes/nilness/cmd/nilness/BUILD.bazel c/go/analysis/passes/nilness/cmd/nilness/BUILD.bazel ---- b/go/analysis/passes/nilness/cmd/nilness/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/nilness/cmd/nilness/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/nilness/cmd/nilness/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -3633,7 +3996,7 @@ diff -urN b/go/analysis/passes/nilness/cmd/nilness/BUILD.bazel c/go/analysis/pas + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/nilness/testdata/src/a/BUILD.bazel c/go/analysis/passes/nilness/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/nilness/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/nilness/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/nilness/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3651,7 +4014,7 @@ diff -urN b/go/analysis/passes/nilness/testdata/src/a/BUILD.bazel c/go/analysis/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/nilness/testdata/src/b/BUILD.bazel c/go/analysis/passes/nilness/testdata/src/b/BUILD.bazel ---- b/go/analysis/passes/nilness/testdata/src/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/nilness/testdata/src/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/nilness/testdata/src/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3669,7 +4032,7 @@ diff -urN b/go/analysis/passes/nilness/testdata/src/b/BUILD.bazel c/go/analysis/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/pkgfact/BUILD.bazel c/go/analysis/passes/pkgfact/BUILD.bazel ---- b/go/analysis/passes/pkgfact/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/pkgfact/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/pkgfact/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -3697,7 +4060,7 @@ diff -urN b/go/analysis/passes/pkgfact/BUILD.bazel c/go/analysis/passes/pkgfact/ + ], +) diff -urN b/go/analysis/passes/pkgfact/testdata/src/a/BUILD.bazel c/go/analysis/passes/pkgfact/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/pkgfact/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/pkgfact/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/pkgfact/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3715,7 +4078,7 @@ diff -urN b/go/analysis/passes/pkgfact/testdata/src/a/BUILD.bazel c/go/analysis/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/pkgfact/testdata/src/b/BUILD.bazel c/go/analysis/passes/pkgfact/testdata/src/b/BUILD.bazel ---- b/go/analysis/passes/pkgfact/testdata/src/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/pkgfact/testdata/src/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/pkgfact/testdata/src/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3733,7 +4096,7 @@ diff -urN b/go/analysis/passes/pkgfact/testdata/src/b/BUILD.bazel c/go/analysis/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/pkgfact/testdata/src/c/BUILD.bazel c/go/analysis/passes/pkgfact/testdata/src/c/BUILD.bazel ---- b/go/analysis/passes/pkgfact/testdata/src/c/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/pkgfact/testdata/src/c/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/pkgfact/testdata/src/c/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3751,9 +4114,9 @@ diff -urN b/go/analysis/passes/pkgfact/testdata/src/c/BUILD.bazel c/go/analysis/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/printf/BUILD.bazel c/go/analysis/passes/printf/BUILD.bazel ---- b/go/analysis/passes/printf/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/printf/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/printf/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,33 @@ +@@ -0,0 +1,35 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -3770,6 +4133,7 @@ diff -urN b/go/analysis/passes/printf/BUILD.bazel c/go/analysis/passes/printf/BU + "//go/analysis/passes/internal/analysisutil", + "//go/ast/inspector", + "//go/types/typeutil", ++ "//internal/typeparams", + ], +) + @@ -3785,10 +4149,11 @@ diff -urN b/go/analysis/passes/printf/BUILD.bazel c/go/analysis/passes/printf/BU + deps = [ + ":printf", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/printf/testdata/src/a/BUILD.bazel c/go/analysis/passes/printf/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/printf/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/printf/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/printf/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3806,7 +4171,7 @@ diff -urN b/go/analysis/passes/printf/testdata/src/a/BUILD.bazel c/go/analysis/p + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/printf/testdata/src/b/BUILD.bazel c/go/analysis/passes/printf/testdata/src/b/BUILD.bazel ---- b/go/analysis/passes/printf/testdata/src/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/printf/testdata/src/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/printf/testdata/src/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3824,7 +4189,7 @@ diff -urN b/go/analysis/passes/printf/testdata/src/b/BUILD.bazel c/go/analysis/p + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/printf/testdata/src/nofmt/BUILD.bazel c/go/analysis/passes/printf/testdata/src/nofmt/BUILD.bazel ---- b/go/analysis/passes/printf/testdata/src/nofmt/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/printf/testdata/src/nofmt/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/printf/testdata/src/nofmt/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3841,8 +4206,29 @@ diff -urN b/go/analysis/passes/printf/testdata/src/nofmt/BUILD.bazel c/go/analys + actual = ":nofmt", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/printf/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/printf/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/printf/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/printf/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,17 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = [ ++ "diagnostics.go", ++ "wrappers.go", ++ ], ++ importpath = "golang.org/x/tools/go/analysis/passes/printf/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/reflectvaluecompare/BUILD.bazel c/go/analysis/passes/reflectvaluecompare/BUILD.bazel ---- b/go/analysis/passes/reflectvaluecompare/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/reflectvaluecompare/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/reflectvaluecompare/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -3875,7 +4261,7 @@ diff -urN b/go/analysis/passes/reflectvaluecompare/BUILD.bazel c/go/analysis/pas + ], +) diff -urN b/go/analysis/passes/reflectvaluecompare/testdata/src/a/BUILD.bazel c/go/analysis/passes/reflectvaluecompare/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/reflectvaluecompare/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/reflectvaluecompare/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/reflectvaluecompare/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3893,7 +4279,7 @@ diff -urN b/go/analysis/passes/reflectvaluecompare/testdata/src/a/BUILD.bazel c/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/shadow/BUILD.bazel c/go/analysis/passes/shadow/BUILD.bazel ---- b/go/analysis/passes/shadow/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/shadow/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/shadow/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -3925,7 +4311,7 @@ diff -urN b/go/analysis/passes/shadow/BUILD.bazel c/go/analysis/passes/shadow/BU + ], +) diff -urN b/go/analysis/passes/shadow/cmd/shadow/BUILD.bazel c/go/analysis/passes/shadow/cmd/shadow/BUILD.bazel ---- b/go/analysis/passes/shadow/cmd/shadow/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/shadow/cmd/shadow/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/shadow/cmd/shadow/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -3947,7 +4333,7 @@ diff -urN b/go/analysis/passes/shadow/cmd/shadow/BUILD.bazel c/go/analysis/passe + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/shadow/testdata/src/a/BUILD.bazel c/go/analysis/passes/shadow/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/shadow/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/shadow/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/shadow/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -3965,9 +4351,9 @@ diff -urN b/go/analysis/passes/shadow/testdata/src/a/BUILD.bazel c/go/analysis/p + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/shift/BUILD.bazel c/go/analysis/passes/shift/BUILD.bazel ---- b/go/analysis/passes/shift/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/shift/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/shift/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,32 @@ +@@ -0,0 +1,34 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -3983,6 +4369,7 @@ diff -urN b/go/analysis/passes/shift/BUILD.bazel c/go/analysis/passes/shift/BUIL + "//go/analysis/passes/inspect", + "//go/analysis/passes/internal/analysisutil", + "//go/ast/inspector", ++ "//internal/typeparams", + ], +) + @@ -3998,10 +4385,11 @@ diff -urN b/go/analysis/passes/shift/BUILD.bazel c/go/analysis/passes/shift/BUIL + deps = [ + ":shift", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/shift/testdata/src/a/BUILD.bazel c/go/analysis/passes/shift/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/shift/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/shift/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/shift/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4018,8 +4406,26 @@ diff -urN b/go/analysis/passes/shift/testdata/src/a/BUILD.bazel c/go/analysis/pa + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/shift/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/shift/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/shift/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/shift/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/shift/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/sigchanyzer/BUILD.bazel c/go/analysis/passes/sigchanyzer/BUILD.bazel ---- b/go/analysis/passes/sigchanyzer/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/sigchanyzer/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/sigchanyzer/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -4051,7 +4457,7 @@ diff -urN b/go/analysis/passes/sigchanyzer/BUILD.bazel c/go/analysis/passes/sigc + ], +) diff -urN b/go/analysis/passes/sigchanyzer/testdata/src/a/BUILD.bazel c/go/analysis/passes/sigchanyzer/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/sigchanyzer/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/sigchanyzer/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/sigchanyzer/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4069,7 +4475,7 @@ diff -urN b/go/analysis/passes/sigchanyzer/testdata/src/a/BUILD.bazel c/go/analy + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/sortslice/BUILD.bazel c/go/analysis/passes/sortslice/BUILD.bazel ---- b/go/analysis/passes/sortslice/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/sortslice/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/sortslice/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -4102,7 +4508,7 @@ diff -urN b/go/analysis/passes/sortslice/BUILD.bazel c/go/analysis/passes/sortsl + ], +) diff -urN b/go/analysis/passes/sortslice/testdata/src/a/BUILD.bazel c/go/analysis/passes/sortslice/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/sortslice/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/sortslice/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/sortslice/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4120,9 +4526,9 @@ diff -urN b/go/analysis/passes/sortslice/testdata/src/a/BUILD.bazel c/go/analysi + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/stdmethods/BUILD.bazel c/go/analysis/passes/stdmethods/BUILD.bazel ---- b/go/analysis/passes/stdmethods/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/stdmethods/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/stdmethods/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,28 @@ +@@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -4149,10 +4555,11 @@ diff -urN b/go/analysis/passes/stdmethods/BUILD.bazel c/go/analysis/passes/stdme + deps = [ + ":stdmethods", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/stdmethods/testdata/src/a/BUILD.bazel c/go/analysis/passes/stdmethods/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/stdmethods/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/stdmethods/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/stdmethods/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4169,10 +4576,28 @@ diff -urN b/go/analysis/passes/stdmethods/testdata/src/a/BUILD.bazel c/go/analys + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/stdmethods/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/stdmethods/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/stdmethods/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/stdmethods/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/stdmethods/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/stringintconv/BUILD.bazel c/go/analysis/passes/stringintconv/BUILD.bazel ---- b/go/analysis/passes/stringintconv/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/stringintconv/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/stringintconv/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,28 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -4184,6 +4609,7 @@ diff -urN b/go/analysis/passes/stringintconv/BUILD.bazel c/go/analysis/passes/st + "//go/analysis", + "//go/analysis/passes/inspect", + "//go/ast/inspector", ++ "//internal/typeparams", + ], +) + @@ -4199,10 +4625,11 @@ diff -urN b/go/analysis/passes/stringintconv/BUILD.bazel c/go/analysis/passes/st + deps = [ + ":stringintconv", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/stringintconv/cmd/stringintconv/BUILD.bazel c/go/analysis/passes/stringintconv/cmd/stringintconv/BUILD.bazel ---- b/go/analysis/passes/stringintconv/cmd/stringintconv/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/stringintconv/cmd/stringintconv/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/stringintconv/cmd/stringintconv/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -4224,7 +4651,7 @@ diff -urN b/go/analysis/passes/stringintconv/cmd/stringintconv/BUILD.bazel c/go/ + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/stringintconv/testdata/src/a/BUILD.bazel c/go/analysis/passes/stringintconv/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/stringintconv/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/stringintconv/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/stringintconv/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4241,8 +4668,26 @@ diff -urN b/go/analysis/passes/stringintconv/testdata/src/a/BUILD.bazel c/go/ana + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/stringintconv/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/stringintconv/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/stringintconv/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/stringintconv/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/stringintconv/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/structtag/BUILD.bazel c/go/analysis/passes/structtag/BUILD.bazel ---- b/go/analysis/passes/structtag/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/structtag/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/structtag/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -4273,46 +4718,46 @@ diff -urN b/go/analysis/passes/structtag/BUILD.bazel c/go/analysis/passes/struct + "//go/analysis/analysistest", + ], +) -diff -urN b/go/analysis/passes/structtag/testdata/src/a/BUILD.bazel c/go/analysis/passes/structtag/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/structtag/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/go/analysis/passes/structtag/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +diff -urN b/go/analysis/passes/structtag/testdata/src/a/b/BUILD.bazel c/go/analysis/passes/structtag/testdata/src/a/b/BUILD.bazel +--- b/go/analysis/passes/structtag/testdata/src/a/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/structtag/testdata/src/a/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") + +go_library( -+ name = "a", -+ srcs = ["a.go"], -+ importpath = "golang.org/x/tools/go/analysis/passes/structtag/testdata/src/a", ++ name = "b", ++ srcs = ["b.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/structtag/testdata/src/a/b", + visibility = ["//visibility:public"], +) + +alias( + name = "go_default_library", -+ actual = ":a", ++ actual = ":b", + visibility = ["//visibility:public"], +) -diff -urN b/go/analysis/passes/structtag/testdata/src/a/b/BUILD.bazel c/go/analysis/passes/structtag/testdata/src/a/b/BUILD.bazel ---- b/go/analysis/passes/structtag/testdata/src/a/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/go/analysis/passes/structtag/testdata/src/a/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +diff -urN b/go/analysis/passes/structtag/testdata/src/a/BUILD.bazel c/go/analysis/passes/structtag/testdata/src/a/BUILD.bazel +--- b/go/analysis/passes/structtag/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/structtag/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") + +go_library( -+ name = "b", -+ srcs = ["b.go"], -+ importpath = "golang.org/x/tools/go/analysis/passes/structtag/testdata/src/a/b", ++ name = "a", ++ srcs = ["a.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/structtag/testdata/src/a", + visibility = ["//visibility:public"], +) + +alias( + name = "go_default_library", -+ actual = ":b", ++ actual = ":a", + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/testinggoroutine/BUILD.bazel c/go/analysis/passes/testinggoroutine/BUILD.bazel ---- b/go/analysis/passes/testinggoroutine/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/testinggoroutine/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/testinggoroutine/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,31 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -4325,6 +4770,7 @@ diff -urN b/go/analysis/passes/testinggoroutine/BUILD.bazel c/go/analysis/passes + "//go/analysis/passes/inspect", + "//go/analysis/passes/internal/analysisutil", + "//go/ast/inspector", ++ "//internal/typeparams", + ], +) + @@ -4340,10 +4786,11 @@ diff -urN b/go/analysis/passes/testinggoroutine/BUILD.bazel c/go/analysis/passes + deps = [ + ":testinggoroutine", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/testinggoroutine/testdata/src/a/BUILD.bazel c/go/analysis/passes/testinggoroutine/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/testinggoroutine/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/testinggoroutine/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/testinggoroutine/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4363,10 +4810,28 @@ diff -urN b/go/analysis/passes/testinggoroutine/testdata/src/a/BUILD.bazel c/go/ + actual = ":a", + visibility = ["//visibility:public"], +) -diff -urN b/go/analysis/passes/tests/BUILD.bazel c/go/analysis/passes/tests/BUILD.bazel ---- b/go/analysis/passes/tests/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/go/analysis/passes/tests/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,24 @@ +diff -urN b/go/analysis/passes/testinggoroutine/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/testinggoroutine/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/testinggoroutine/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/testinggoroutine/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/testinggoroutine/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) +diff -urN b/go/analysis/passes/tests/BUILD.bazel c/go/analysis/passes/tests/BUILD.bazel +--- b/go/analysis/passes/tests/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/tests/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -4374,7 +4839,10 @@ diff -urN b/go/analysis/passes/tests/BUILD.bazel c/go/analysis/passes/tests/BUIL + srcs = ["tests.go"], + importpath = "golang.org/x/tools/go/analysis/passes/tests", + visibility = ["//visibility:public"], -+ deps = ["//go/analysis"], ++ deps = [ ++ "//go/analysis", ++ "//internal/typeparams", ++ ], +) + +alias( @@ -4389,10 +4857,11 @@ diff -urN b/go/analysis/passes/tests/BUILD.bazel c/go/analysis/passes/tests/BUIL + deps = [ + ":tests", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/tests/testdata/src/a/BUILD.bazel c/go/analysis/passes/tests/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/tests/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/tests/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/tests/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,23 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -4419,7 +4888,7 @@ diff -urN b/go/analysis/passes/tests/testdata/src/a/BUILD.bazel c/go/analysis/pa + embed = [":a"], +) diff -urN b/go/analysis/passes/tests/testdata/src/b/BUILD.bazel c/go/analysis/passes/tests/testdata/src/b/BUILD.bazel ---- b/go/analysis/passes/tests/testdata/src/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/tests/testdata/src/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/tests/testdata/src/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4437,7 +4906,7 @@ diff -urN b/go/analysis/passes/tests/testdata/src/b/BUILD.bazel c/go/analysis/pa + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/tests/testdata/src/b_x_test/BUILD.bazel c/go/analysis/passes/tests/testdata/src/b_x_test/BUILD.bazel ---- b/go/analysis/passes/tests/testdata/src/b_x_test/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/tests/testdata/src/b_x_test/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/tests/testdata/src/b_x_test/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,6 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_test") @@ -4447,7 +4916,7 @@ diff -urN b/go/analysis/passes/tests/testdata/src/b_x_test/BUILD.bazel c/go/anal + srcs = ["b_test.go"], +) diff -urN b/go/analysis/passes/tests/testdata/src/divergent/BUILD.bazel c/go/analysis/passes/tests/testdata/src/divergent/BUILD.bazel ---- b/go/analysis/passes/tests/testdata/src/divergent/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/tests/testdata/src/divergent/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/tests/testdata/src/divergent/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -4470,10 +4939,34 @@ diff -urN b/go/analysis/passes/tests/testdata/src/divergent/BUILD.bazel c/go/ana + srcs = ["buf_test.go"], + embed = [":divergent"], +) +diff -urN b/go/analysis/passes/tests/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/tests/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/tests/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/tests/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,20 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/tests/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++go_test( ++ name = "typeparams_test", ++ srcs = ["typeparams_test.go"], ++ embed = [":typeparams"], ++) diff -urN b/go/analysis/passes/unmarshal/BUILD.bazel c/go/analysis/passes/unmarshal/BUILD.bazel ---- b/go/analysis/passes/unmarshal/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unmarshal/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unmarshal/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,31 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -4486,6 +4979,7 @@ diff -urN b/go/analysis/passes/unmarshal/BUILD.bazel c/go/analysis/passes/unmars + "//go/analysis/passes/inspect", + "//go/ast/inspector", + "//go/types/typeutil", ++ "//internal/typeparams", + ], +) + @@ -4501,10 +4995,11 @@ diff -urN b/go/analysis/passes/unmarshal/BUILD.bazel c/go/analysis/passes/unmars + deps = [ + ":unmarshal", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/unmarshal/cmd/unmarshal/BUILD.bazel c/go/analysis/passes/unmarshal/cmd/unmarshal/BUILD.bazel ---- b/go/analysis/passes/unmarshal/cmd/unmarshal/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unmarshal/cmd/unmarshal/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unmarshal/cmd/unmarshal/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -4526,7 +5021,7 @@ diff -urN b/go/analysis/passes/unmarshal/cmd/unmarshal/BUILD.bazel c/go/analysis + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/unmarshal/testdata/src/a/BUILD.bazel c/go/analysis/passes/unmarshal/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/unmarshal/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unmarshal/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unmarshal/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4543,8 +5038,26 @@ diff -urN b/go/analysis/passes/unmarshal/testdata/src/a/BUILD.bazel c/go/analysi + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/unmarshal/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/unmarshal/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/unmarshal/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/unmarshal/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/unmarshal/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/unreachable/BUILD.bazel c/go/analysis/passes/unreachable/BUILD.bazel ---- b/go/analysis/passes/unreachable/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unreachable/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unreachable/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -4576,7 +5089,7 @@ diff -urN b/go/analysis/passes/unreachable/BUILD.bazel c/go/analysis/passes/unre + ], +) diff -urN b/go/analysis/passes/unreachable/testdata/src/a/BUILD.bazel c/go/analysis/passes/unreachable/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/unreachable/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unreachable/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unreachable/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4594,9 +5107,9 @@ diff -urN b/go/analysis/passes/unreachable/testdata/src/a/BUILD.bazel c/go/analy + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/passes/unsafeptr/BUILD.bazel c/go/analysis/passes/unsafeptr/BUILD.bazel ---- b/go/analysis/passes/unsafeptr/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unsafeptr/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unsafeptr/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -4624,10 +5137,11 @@ diff -urN b/go/analysis/passes/unsafeptr/BUILD.bazel c/go/analysis/passes/unsafe + deps = [ + ":unsafeptr", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/unsafeptr/testdata/src/a/BUILD.bazel c/go/analysis/passes/unsafeptr/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/unsafeptr/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unsafeptr/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unsafeptr/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4647,10 +5161,28 @@ diff -urN b/go/analysis/passes/unsafeptr/testdata/src/a/BUILD.bazel c/go/analysi + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/unsafeptr/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/unsafeptr/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/unsafeptr/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/unsafeptr/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/unsafeptr/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/unusedresult/BUILD.bazel c/go/analysis/passes/unusedresult/BUILD.bazel ---- b/go/analysis/passes/unusedresult/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unusedresult/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unusedresult/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,31 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -4663,6 +5195,7 @@ diff -urN b/go/analysis/passes/unusedresult/BUILD.bazel c/go/analysis/passes/unu + "//go/analysis/passes/inspect", + "//go/analysis/passes/internal/analysisutil", + "//go/ast/inspector", ++ "//internal/typeparams", + ], +) + @@ -4678,10 +5211,11 @@ diff -urN b/go/analysis/passes/unusedresult/BUILD.bazel c/go/analysis/passes/unu + deps = [ + ":unusedresult", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/go/analysis/passes/unusedresult/testdata/src/a/BUILD.bazel c/go/analysis/passes/unusedresult/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/unusedresult/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unusedresult/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unusedresult/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4698,8 +5232,44 @@ diff -urN b/go/analysis/passes/unusedresult/testdata/src/a/BUILD.bazel c/go/anal + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/unusedresult/testdata/src/typeparams/BUILD.bazel c/go/analysis/passes/unusedresult/testdata/src/typeparams/BUILD.bazel +--- b/go/analysis/passes/unusedresult/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/unusedresult/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/unusedresult/testdata/src/typeparams", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//visibility:public"], ++) +diff -urN b/go/analysis/passes/unusedresult/testdata/src/typeparams/userdefs/BUILD.bazel c/go/analysis/passes/unusedresult/testdata/src/typeparams/userdefs/BUILD.bazel +--- b/go/analysis/passes/unusedresult/testdata/src/typeparams/userdefs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/unusedresult/testdata/src/typeparams/userdefs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "userdefs", ++ srcs = ["userdefs.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/unusedresult/testdata/src/typeparams/userdefs", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":userdefs", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/passes/unusedwrite/BUILD.bazel c/go/analysis/passes/unusedwrite/BUILD.bazel ---- b/go/analysis/passes/unusedwrite/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unusedwrite/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unusedwrite/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -4731,7 +5301,7 @@ diff -urN b/go/analysis/passes/unusedwrite/BUILD.bazel c/go/analysis/passes/unus + ], +) diff -urN b/go/analysis/passes/unusedwrite/testdata/src/a/BUILD.bazel c/go/analysis/passes/unusedwrite/testdata/src/a/BUILD.bazel ---- b/go/analysis/passes/unusedwrite/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/passes/unusedwrite/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/passes/unusedwrite/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4748,8 +5318,114 @@ diff -urN b/go/analysis/passes/unusedwrite/testdata/src/a/BUILD.bazel c/go/analy + actual = ":a", + visibility = ["//visibility:public"], +) +diff -urN b/go/analysis/passes/usesgenerics/BUILD.bazel c/go/analysis/passes/usesgenerics/BUILD.bazel +--- b/go/analysis/passes/usesgenerics/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/usesgenerics/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,30 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") ++ ++go_library( ++ name = "usesgenerics", ++ srcs = ["usesgenerics.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/usesgenerics", ++ visibility = ["//visibility:public"], ++ deps = [ ++ "//go/analysis", ++ "//go/analysis/passes/inspect", ++ "//go/ast/inspector", ++ "//internal/typeparams/genericfeatures", ++ ], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":usesgenerics", ++ visibility = ["//visibility:public"], ++) ++ ++go_test( ++ name = "usesgenerics_test", ++ srcs = ["usesgenerics_test.go"], ++ deps = [ ++ ":usesgenerics", ++ "//go/analysis/analysistest", ++ "//internal/typeparams", ++ ], ++) +diff -urN b/go/analysis/passes/usesgenerics/testdata/src/a/BUILD.bazel c/go/analysis/passes/usesgenerics/testdata/src/a/BUILD.bazel +--- b/go/analysis/passes/usesgenerics/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/usesgenerics/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "a", ++ srcs = ["a.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/usesgenerics/testdata/src/a", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":a", ++ visibility = ["//visibility:public"], ++) +diff -urN b/go/analysis/passes/usesgenerics/testdata/src/b/BUILD.bazel c/go/analysis/passes/usesgenerics/testdata/src/b/BUILD.bazel +--- b/go/analysis/passes/usesgenerics/testdata/src/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/usesgenerics/testdata/src/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "b", ++ srcs = ["b.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/usesgenerics/testdata/src/b", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":b", ++ visibility = ["//visibility:public"], ++) +diff -urN b/go/analysis/passes/usesgenerics/testdata/src/c/BUILD.bazel c/go/analysis/passes/usesgenerics/testdata/src/c/BUILD.bazel +--- b/go/analysis/passes/usesgenerics/testdata/src/c/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/usesgenerics/testdata/src/c/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "c", ++ srcs = ["c.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/usesgenerics/testdata/src/c", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":c", ++ visibility = ["//visibility:public"], ++) +diff -urN b/go/analysis/passes/usesgenerics/testdata/src/d/BUILD.bazel c/go/analysis/passes/usesgenerics/testdata/src/d/BUILD.bazel +--- b/go/analysis/passes/usesgenerics/testdata/src/d/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/analysis/passes/usesgenerics/testdata/src/d/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "d", ++ srcs = ["d.go"], ++ importpath = "golang.org/x/tools/go/analysis/passes/usesgenerics/testdata/src/d", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":d", ++ visibility = ["//visibility:public"], ++) diff -urN b/go/analysis/singlechecker/BUILD.bazel c/go/analysis/singlechecker/BUILD.bazel ---- b/go/analysis/singlechecker/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/singlechecker/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/singlechecker/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4773,9 +5449,9 @@ diff -urN b/go/analysis/singlechecker/BUILD.bazel c/go/analysis/singlechecker/BU + visibility = ["//visibility:public"], +) diff -urN b/go/analysis/unitchecker/BUILD.bazel c/go/analysis/unitchecker/BUILD.bazel ---- b/go/analysis/unitchecker/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/analysis/unitchecker/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/analysis/unitchecker/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,33 @@ +@@ -0,0 +1,34 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -4790,6 +5466,7 @@ diff -urN b/go/analysis/unitchecker/BUILD.bazel c/go/analysis/unitchecker/BUILD. + "//go/analysis", + "//go/analysis/internal/analysisflags", + "//go/analysis/internal/facts", ++ "//internal/typeparams", + ], +) + @@ -4810,7 +5487,7 @@ diff -urN b/go/analysis/unitchecker/BUILD.bazel c/go/analysis/unitchecker/BUILD. + ], +) diff -urN b/go/ast/astutil/BUILD.bazel c/go/ast/astutil/BUILD.bazel ---- b/go/ast/astutil/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ast/astutil/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ast/astutil/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,31 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -4845,9 +5522,9 @@ diff -urN b/go/ast/astutil/BUILD.bazel c/go/ast/astutil/BUILD.bazel + deps = ["//internal/typeparams"], +) diff -urN b/go/ast/inspector/BUILD.bazel c/go/ast/inspector/BUILD.bazel ---- b/go/ast/inspector/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ast/inspector/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ast/inspector/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,23 @@ +@@ -0,0 +1,27 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -4858,6 +5535,7 @@ diff -urN b/go/ast/inspector/BUILD.bazel c/go/ast/inspector/BUILD.bazel + ], + importpath = "golang.org/x/tools/go/ast/inspector", + visibility = ["//visibility:public"], ++ deps = ["//internal/typeparams"], +) + +alias( @@ -4869,10 +5547,13 @@ diff -urN b/go/ast/inspector/BUILD.bazel c/go/ast/inspector/BUILD.bazel +go_test( + name = "inspector_test", + srcs = ["inspector_test.go"], -+ deps = [":inspector"], ++ deps = [ ++ ":inspector", ++ "//internal/typeparams", ++ ], +) diff -urN b/go/buildutil/BUILD.bazel c/go/buildutil/BUILD.bazel ---- b/go/buildutil/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/buildutil/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/buildutil/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,35 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -4911,7 +5592,7 @@ diff -urN b/go/buildutil/BUILD.bazel c/go/buildutil/BUILD.bazel + ], +) diff -urN b/go/callgraph/BUILD.bazel c/go/callgraph/BUILD.bazel ---- b/go/callgraph/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/callgraph/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/callgraph/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -4933,7 +5614,7 @@ diff -urN b/go/callgraph/BUILD.bazel c/go/callgraph/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/go/callgraph/cha/BUILD.bazel c/go/callgraph/cha/BUILD.bazel ---- b/go/callgraph/cha/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/callgraph/cha/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/callgraph/cha/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,106 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5043,7 +5724,7 @@ diff -urN b/go/callgraph/cha/BUILD.bazel c/go/callgraph/cha/BUILD.bazel + }), +) diff -urN b/go/callgraph/cha/testdata/BUILD.bazel c/go/callgraph/cha/testdata/BUILD.bazel ---- b/go/callgraph/cha/testdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/callgraph/cha/testdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/callgraph/cha/testdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -5061,7 +5742,7 @@ diff -urN b/go/callgraph/cha/testdata/BUILD.bazel c/go/callgraph/cha/testdata/BU + visibility = ["//visibility:public"], +) diff -urN b/go/callgraph/rta/BUILD.bazel c/go/callgraph/rta/BUILD.bazel ---- b/go/callgraph/rta/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/callgraph/rta/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/callgraph/rta/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,119 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5184,7 +5865,7 @@ diff -urN b/go/callgraph/rta/BUILD.bazel c/go/callgraph/rta/BUILD.bazel + }), +) diff -urN b/go/callgraph/static/BUILD.bazel c/go/callgraph/static/BUILD.bazel ---- b/go/callgraph/static/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/callgraph/static/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/callgraph/static/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5218,9 +5899,9 @@ diff -urN b/go/callgraph/static/BUILD.bazel c/go/callgraph/static/BUILD.bazel + ], +) diff -urN b/go/callgraph/vta/BUILD.bazel c/go/callgraph/vta/BUILD.bazel ---- b/go/callgraph/vta/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/callgraph/vta/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/callgraph/vta/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,44 @@ +@@ -0,0 +1,45 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -5235,6 +5916,7 @@ diff -urN b/go/callgraph/vta/BUILD.bazel c/go/callgraph/vta/BUILD.bazel + visibility = ["//visibility:public"], + deps = [ + "//go/callgraph", ++ "//go/callgraph/vta/internal/trie", + "//go/ssa", + "//go/types/typeutil", + ], @@ -5265,8 +5947,41 @@ diff -urN b/go/callgraph/vta/BUILD.bazel c/go/callgraph/vta/BUILD.bazel + "//go/types/typeutil", + ], +) +diff -urN b/go/callgraph/vta/internal/trie/BUILD.bazel c/go/callgraph/vta/internal/trie/BUILD.bazel +--- b/go/callgraph/vta/internal/trie/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/go/callgraph/vta/internal/trie/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,29 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") ++ ++go_library( ++ name = "trie", ++ srcs = [ ++ "bits.go", ++ "builder.go", ++ "scope.go", ++ "trie.go", ++ ], ++ importpath = "golang.org/x/tools/go/callgraph/vta/internal/trie", ++ visibility = ["//go/callgraph/vta:__subpackages__"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":trie", ++ visibility = ["//go/callgraph/vta:__subpackages__"], ++) ++ ++go_test( ++ name = "trie_test", ++ srcs = [ ++ "bits_test.go", ++ "op_test.go", ++ "trie_test.go", ++ ], ++ embed = [":trie"], ++) diff -urN b/go/callgraph/vta/testdata/BUILD.bazel c/go/callgraph/vta/testdata/BUILD.bazel ---- b/go/callgraph/vta/testdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/callgraph/vta/testdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/callgraph/vta/testdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,44 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5314,7 +6029,7 @@ diff -urN b/go/callgraph/vta/testdata/BUILD.bazel c/go/callgraph/vta/testdata/BU + visibility = ["//visibility:public"], +) diff -urN b/go/cfg/BUILD.bazel c/go/cfg/BUILD.bazel ---- b/go/cfg/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/cfg/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/cfg/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,23 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5341,7 +6056,7 @@ diff -urN b/go/cfg/BUILD.bazel c/go/cfg/BUILD.bazel + embed = [":cfg"], +) diff -urN b/go/expect/BUILD.bazel c/go/expect/BUILD.bazel ---- b/go/expect/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/expect/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/expect/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5369,7 +6084,7 @@ diff -urN b/go/expect/BUILD.bazel c/go/expect/BUILD.bazel + deps = [":expect"], +) diff -urN b/go/expect/testdata/BUILD.bazel c/go/expect/testdata/BUILD.bazel ---- b/go/expect/testdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/expect/testdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/expect/testdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5387,7 +6102,7 @@ diff -urN b/go/expect/testdata/BUILD.bazel c/go/expect/testdata/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/go/gccgoexportdata/BUILD.bazel c/go/gccgoexportdata/BUILD.bazel ---- b/go/gccgoexportdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/gccgoexportdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/gccgoexportdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,22 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5413,7 +6128,7 @@ diff -urN b/go/gccgoexportdata/BUILD.bazel c/go/gccgoexportdata/BUILD.bazel + deps = [":gccgoexportdata"], +) diff -urN b/go/gcexportdata/BUILD.bazel c/go/gcexportdata/BUILD.bazel ---- b/go/gcexportdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/gcexportdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/gcexportdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5445,7 +6160,7 @@ diff -urN b/go/gcexportdata/BUILD.bazel c/go/gcexportdata/BUILD.bazel + deps = [":gcexportdata"], +) diff -urN b/go/internal/cgo/BUILD.bazel c/go/internal/cgo/BUILD.bazel ---- b/go/internal/cgo/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/internal/cgo/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/internal/cgo/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5467,7 +6182,7 @@ diff -urN b/go/internal/cgo/BUILD.bazel c/go/internal/cgo/BUILD.bazel + visibility = ["//go:__subpackages__"], +) diff -urN b/go/internal/gccgoimporter/BUILD.bazel c/go/internal/gccgoimporter/BUILD.bazel ---- b/go/internal/gccgoimporter/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/internal/gccgoimporter/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/internal/gccgoimporter/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,35 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5506,9 +6221,9 @@ diff -urN b/go/internal/gccgoimporter/BUILD.bazel c/go/internal/gccgoimporter/BU + embed = [":gccgoimporter"], +) diff -urN b/go/internal/gcimporter/BUILD.bazel c/go/internal/gcimporter/BUILD.bazel ---- b/go/internal/gcimporter/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/internal/gcimporter/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/internal/gcimporter/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,42 @@ +@@ -0,0 +1,47 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -5523,6 +6238,7 @@ diff -urN b/go/internal/gcimporter/BUILD.bazel c/go/internal/gcimporter/BUILD.ba + "newInterface10.go", + "newInterface11.go", + "support_go117.go", ++ "support_go118.go", + ], + importpath = "golang.org/x/tools/go/internal/gcimporter", + visibility = ["//go:__subpackages__"], @@ -5540,19 +6256,23 @@ diff -urN b/go/internal/gcimporter/BUILD.bazel c/go/internal/gcimporter/BUILD.ba + srcs = [ + "bexport_test.go", + "gcimporter_test.go", ++ "iexport_common_test.go", ++ "iexport_go118_test.go", + "iexport_test.go", + "israce_test.go", + ], + embed = [":gcimporter"], + deps = [ ++ "//go/ast/inspector", + "//go/buildutil", + "//go/loader", + "//internal/testenv", + "//internal/typeparams", ++ "//internal/typeparams/genericfeatures", + ], +) diff -urN b/go/internal/gcimporter/testdata/versions/BUILD.bazel c/go/internal/gcimporter/testdata/versions/BUILD.bazel ---- b/go/internal/gcimporter/testdata/versions/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/internal/gcimporter/testdata/versions/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/internal/gcimporter/testdata/versions/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5570,7 +6290,7 @@ diff -urN b/go/internal/gcimporter/testdata/versions/BUILD.bazel c/go/internal/g + visibility = ["//go:__subpackages__"], +) diff -urN b/go/internal/packagesdriver/BUILD.bazel c/go/internal/packagesdriver/BUILD.bazel ---- b/go/internal/packagesdriver/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/internal/packagesdriver/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/internal/packagesdriver/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5589,7 +6309,7 @@ diff -urN b/go/internal/packagesdriver/BUILD.bazel c/go/internal/packagesdriver/ + visibility = ["//go:__subpackages__"], +) diff -urN b/go/loader/BUILD.bazel c/go/loader/BUILD.bazel ---- b/go/loader/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/loader/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/loader/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,36 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5629,7 +6349,7 @@ diff -urN b/go/loader/BUILD.bazel c/go/loader/BUILD.bazel + ], +) diff -urN b/go/loader/testdata/BUILD.bazel c/go/loader/testdata/BUILD.bazel ---- b/go/loader/testdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/loader/testdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/loader/testdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5651,7 +6371,7 @@ diff -urN b/go/loader/testdata/BUILD.bazel c/go/loader/testdata/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/go/loader/testdata/issue46877/BUILD.bazel c/go/loader/testdata/issue46877/BUILD.bazel ---- b/go/loader/testdata/issue46877/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/loader/testdata/issue46877/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/loader/testdata/issue46877/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5673,9 +6393,9 @@ diff -urN b/go/loader/testdata/issue46877/BUILD.bazel c/go/loader/testdata/issue + visibility = ["//visibility:public"], +) diff -urN b/go/packages/BUILD.bazel c/go/packages/BUILD.bazel ---- b/go/packages/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,47 @@ +@@ -0,0 +1,48 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -5696,6 +6416,7 @@ diff -urN b/go/packages/BUILD.bazel c/go/packages/BUILD.bazel + "//go/internal/packagesdriver", + "//internal/gocommand", + "//internal/packagesinternal", ++ "//internal/typeparams", + "//internal/typesinternal", + "@org_golang_x_sys//execabs:go_default_library", + "@org_golang_x_xerrors//:go_default_library", @@ -5724,7 +6445,7 @@ diff -urN b/go/packages/BUILD.bazel c/go/packages/BUILD.bazel + ], +) diff -urN b/go/packages/gopackages/BUILD.bazel c/go/packages/gopackages/BUILD.bazel ---- b/go/packages/gopackages/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/gopackages/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/gopackages/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,19 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -5747,7 +6468,7 @@ diff -urN b/go/packages/gopackages/BUILD.bazel c/go/packages/gopackages/BUILD.ba + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/BUILD.bazel c/go/packages/packagestest/BUILD.bazel ---- b/go/packages/packagestest/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,46 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5797,7 +6518,7 @@ diff -urN b/go/packages/packagestest/BUILD.bazel c/go/packages/packagestest/BUIL + ], +) diff -urN b/go/packages/packagestest/testdata/BUILD.bazel c/go/packages/packagestest/testdata/BUILD.bazel ---- b/go/packages/packagestest/testdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,23 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -5824,7 +6545,7 @@ diff -urN b/go/packages/packagestest/testdata/BUILD.bazel c/go/packages/packages + embed = [":testdata"], +) diff -urN b/go/packages/packagestest/testdata/groups/one/modules/example.com/extra/BUILD.bazel c/go/packages/packagestest/testdata/groups/one/modules/example.com/extra/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/one/modules/example.com/extra/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/one/modules/example.com/extra/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/one/modules/example.com/extra/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5842,7 +6563,7 @@ diff -urN b/go/packages/packagestest/testdata/groups/one/modules/example.com/ext + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/testdata/groups/one/primarymod/BUILD.bazel c/go/packages/packagestest/testdata/groups/one/primarymod/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/one/primarymod/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/one/primarymod/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/one/primarymod/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5860,7 +6581,7 @@ diff -urN b/go/packages/packagestest/testdata/groups/one/primarymod/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/BUILD.bazel c/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5878,7 +6599,7 @@ diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/ext + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/geez/BUILD.bazel c/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/geez/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/geez/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/geez/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/geez/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5896,7 +6617,7 @@ diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/ext + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/v2/BUILD.bazel c/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/v2/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/v2/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/v2/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/v2/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5914,7 +6635,7 @@ diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/ext + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/v2/geez/BUILD.bazel c/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/v2/geez/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/v2/geez/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/v2/geez/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/two/modules/example.com/extra/v2/geez/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5932,7 +6653,7 @@ diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/ext + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/tempmod/BUILD.bazel c/go/packages/packagestest/testdata/groups/two/modules/example.com/tempmod/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/two/modules/example.com/tempmod/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/two/modules/example.com/tempmod/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/two/modules/example.com/tempmod/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5950,7 +6671,7 @@ diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/tem + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/what@v1.0.0/BUILD.bazel c/go/packages/packagestest/testdata/groups/two/modules/example.com/what@v1.0.0/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/two/modules/example.com/what@v1.0.0/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/two/modules/example.com/what@v1.0.0/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/two/modules/example.com/what@v1.0.0/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5968,7 +6689,7 @@ diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/wha + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/what@v1.1.0/BUILD.bazel c/go/packages/packagestest/testdata/groups/two/modules/example.com/what@v1.1.0/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/two/modules/example.com/what@v1.1.0/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/two/modules/example.com/what@v1.1.0/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/two/modules/example.com/what@v1.1.0/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -5986,7 +6707,7 @@ diff -urN b/go/packages/packagestest/testdata/groups/two/modules/example.com/wha + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/testdata/groups/two/primarymod/BUILD.bazel c/go/packages/packagestest/testdata/groups/two/primarymod/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/two/primarymod/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/two/primarymod/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/two/primarymod/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6004,7 +6725,7 @@ diff -urN b/go/packages/packagestest/testdata/groups/two/primarymod/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/go/packages/packagestest/testdata/groups/two/primarymod/expect/BUILD.bazel c/go/packages/packagestest/testdata/groups/two/primarymod/expect/BUILD.bazel ---- b/go/packages/packagestest/testdata/groups/two/primarymod/expect/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/packages/packagestest/testdata/groups/two/primarymod/expect/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/packages/packagestest/testdata/groups/two/primarymod/expect/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,19 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -6027,9 +6748,9 @@ diff -urN b/go/packages/packagestest/testdata/groups/two/primarymod/expect/BUILD + srcs = ["yo_test.go"], +) diff -urN b/go/pointer/BUILD.bazel c/go/pointer/BUILD.bazel ---- b/go/pointer/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/pointer/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/pointer/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,122 @@ +@@ -0,0 +1,109 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -6085,75 +6806,62 @@ diff -urN b/go/pointer/BUILD.bazel c/go/pointer/BUILD.bazel + "//go/ssa/ssautil", + ] + select({ + "@io_bazel_rules_go//go/platform:aix": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:darwin": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:dragonfly": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:freebsd": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:illumos": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:ios": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:js": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:linux": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:netbsd": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:openbsd": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:plan9": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:solaris": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "@io_bazel_rules_go//go/platform:windows": [ -+ "//go/buildutil", ++ "//go/packages", + "//go/types/typeutil", -+ "//internal/testenv", + ], + "//conditions:default": [], + }), +) diff -urN b/go/pointer/testdata/BUILD.bazel c/go/pointer/testdata/BUILD.bazel ---- b/go/pointer/testdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/pointer/testdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/pointer/testdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -6175,9 +6883,9 @@ diff -urN b/go/pointer/testdata/BUILD.bazel c/go/pointer/testdata/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/BUILD.bazel c/go/ssa/BUILD.bazel ---- b/go/ssa/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,116 @@ +@@ -0,0 +1,127 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -6201,7 +6909,6 @@ diff -urN b/go/ssa/BUILD.bazel c/go/ssa/BUILD.bazel + "sanity.go", + "source.go", + "ssa.go", -+ "testmain.go", + "util.go", + "wrappers.go", + ], @@ -6228,7 +6935,6 @@ diff -urN b/go/ssa/BUILD.bazel c/go/ssa/BUILD.bazel + "identical_test.go", + "source_test.go", + "stdlib_test.go", -+ "testmain_test.go", + ], + data = glob(["testdata/**"]), + deps = [ @@ -6240,62 +6946,75 @@ diff -urN b/go/ssa/BUILD.bazel c/go/ssa/BUILD.bazel + "//go/ssa/ssautil", + ] + select({ + "@io_bazel_rules_go//go/platform:aix": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:darwin": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:dragonfly": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:freebsd": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:illumos": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:ios": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:js": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:linux": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:netbsd": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:openbsd": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:plan9": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:solaris": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "@io_bazel_rules_go//go/platform:windows": [ -+ "//go/buildutil", ++ "//go/ast/inspector", + "//internal/testenv", ++ "//internal/typeparams/genericfeatures", + ], + "//conditions:default": [], + }), +) diff -urN b/go/ssa/interp/BUILD.bazel c/go/ssa/interp/BUILD.bazel ---- b/go/ssa/interp/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,39 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -6338,7 +7057,7 @@ diff -urN b/go/ssa/interp/BUILD.bazel c/go/ssa/interp/BUILD.bazel + ], +) diff -urN b/go/ssa/interp/testdata/BUILD.bazel c/go/ssa/interp/testdata/BUILD.bazel ---- b/go/ssa/interp/testdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -6372,7 +7091,7 @@ diff -urN b/go/ssa/interp/testdata/BUILD.bazel c/go/ssa/interp/testdata/BUILD.ba + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/interp/testdata/src/errors/BUILD.bazel c/go/ssa/interp/testdata/src/errors/BUILD.bazel ---- b/go/ssa/interp/testdata/src/errors/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/src/errors/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/src/errors/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6390,7 +7109,7 @@ diff -urN b/go/ssa/interp/testdata/src/errors/BUILD.bazel c/go/ssa/interp/testda + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/interp/testdata/src/fmt/BUILD.bazel c/go/ssa/interp/testdata/src/fmt/BUILD.bazel ---- b/go/ssa/interp/testdata/src/fmt/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/src/fmt/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/src/fmt/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6408,7 +7127,7 @@ diff -urN b/go/ssa/interp/testdata/src/fmt/BUILD.bazel c/go/ssa/interp/testdata/ + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/interp/testdata/src/math/BUILD.bazel c/go/ssa/interp/testdata/src/math/BUILD.bazel ---- b/go/ssa/interp/testdata/src/math/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/src/math/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/src/math/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6426,7 +7145,7 @@ diff -urN b/go/ssa/interp/testdata/src/math/BUILD.bazel c/go/ssa/interp/testdata + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/interp/testdata/src/os/BUILD.bazel c/go/ssa/interp/testdata/src/os/BUILD.bazel ---- b/go/ssa/interp/testdata/src/os/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/src/os/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/src/os/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6444,7 +7163,7 @@ diff -urN b/go/ssa/interp/testdata/src/os/BUILD.bazel c/go/ssa/interp/testdata/s + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/interp/testdata/src/reflect/BUILD.bazel c/go/ssa/interp/testdata/src/reflect/BUILD.bazel ---- b/go/ssa/interp/testdata/src/reflect/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/src/reflect/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/src/reflect/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6462,7 +7181,7 @@ diff -urN b/go/ssa/interp/testdata/src/reflect/BUILD.bazel c/go/ssa/interp/testd + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/interp/testdata/src/runtime/BUILD.bazel c/go/ssa/interp/testdata/src/runtime/BUILD.bazel ---- b/go/ssa/interp/testdata/src/runtime/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/src/runtime/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/src/runtime/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6480,7 +7199,7 @@ diff -urN b/go/ssa/interp/testdata/src/runtime/BUILD.bazel c/go/ssa/interp/testd + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/interp/testdata/src/strings/BUILD.bazel c/go/ssa/interp/testdata/src/strings/BUILD.bazel ---- b/go/ssa/interp/testdata/src/strings/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/src/strings/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/src/strings/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6498,7 +7217,7 @@ diff -urN b/go/ssa/interp/testdata/src/strings/BUILD.bazel c/go/ssa/interp/testd + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/interp/testdata/src/time/BUILD.bazel c/go/ssa/interp/testdata/src/time/BUILD.bazel ---- b/go/ssa/interp/testdata/src/time/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/src/time/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/src/time/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6516,7 +7235,7 @@ diff -urN b/go/ssa/interp/testdata/src/time/BUILD.bazel c/go/ssa/interp/testdata + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/interp/testdata/src/unicode/utf8/BUILD.bazel c/go/ssa/interp/testdata/src/unicode/utf8/BUILD.bazel ---- b/go/ssa/interp/testdata/src/unicode/utf8/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/src/unicode/utf8/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/src/unicode/utf8/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6534,7 +7253,7 @@ diff -urN b/go/ssa/interp/testdata/src/unicode/utf8/BUILD.bazel c/go/ssa/interp/ + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/interp/testdata/src/unsafe/BUILD.bazel c/go/ssa/interp/testdata/src/unsafe/BUILD.bazel ---- b/go/ssa/interp/testdata/src/unsafe/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/interp/testdata/src/unsafe/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/interp/testdata/src/unsafe/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6552,7 +7271,7 @@ diff -urN b/go/ssa/interp/testdata/src/unsafe/BUILD.bazel c/go/ssa/interp/testda + visibility = ["//visibility:public"], +) diff -urN b/go/ssa/ssautil/BUILD.bazel c/go/ssa/ssautil/BUILD.bazel ---- b/go/ssa/ssautil/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/ssa/ssautil/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/ssa/ssautil/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,91 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -6647,9 +7366,9 @@ diff -urN b/go/ssa/ssautil/BUILD.bazel c/go/ssa/ssautil/BUILD.bazel + }), +) diff -urN b/go/types/objectpath/BUILD.bazel c/go/types/objectpath/BUILD.bazel ---- b/go/types/objectpath/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/types/objectpath/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/types/objectpath/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,25 @@ +@@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -6657,6 +7376,7 @@ diff -urN b/go/types/objectpath/BUILD.bazel c/go/types/objectpath/BUILD.bazel + srcs = ["objectpath.go"], + importpath = "golang.org/x/tools/go/types/objectpath", + visibility = ["//visibility:public"], ++ deps = ["//internal/typeparams"], +) + +alias( @@ -6667,7 +7387,10 @@ diff -urN b/go/types/objectpath/BUILD.bazel c/go/types/objectpath/BUILD.bazel + +go_test( + name = "objectpath_test", -+ srcs = ["objectpath_test.go"], ++ srcs = [ ++ "objectpath_go118_test.go", ++ "objectpath_test.go", ++ ], + deps = [ + ":objectpath", + "//go/buildutil", @@ -6676,9 +7399,9 @@ diff -urN b/go/types/objectpath/BUILD.bazel c/go/types/objectpath/BUILD.bazel + ], +) diff -urN b/go/types/typeutil/BUILD.bazel c/go/types/typeutil/BUILD.bazel ---- b/go/types/typeutil/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/types/typeutil/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/types/typeutil/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,33 @@ +@@ -0,0 +1,39 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -6692,7 +7415,10 @@ diff -urN b/go/types/typeutil/BUILD.bazel c/go/types/typeutil/BUILD.bazel + ], + importpath = "golang.org/x/tools/go/types/typeutil", + visibility = ["//visibility:public"], -+ deps = ["//go/ast/astutil"], ++ deps = [ ++ "//go/ast/astutil", ++ "//internal/typeparams", ++ ], +) + +alias( @@ -6710,10 +7436,13 @@ diff -urN b/go/types/typeutil/BUILD.bazel c/go/types/typeutil/BUILD.bazel + "map_test.go", + "ui_test.go", + ], -+ deps = [":typeutil"], ++ deps = [ ++ ":typeutil", ++ "//internal/typeparams", ++ ], +) diff -urN b/go/vcs/BUILD.bazel c/go/vcs/BUILD.bazel ---- b/go/vcs/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/go/vcs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/go/vcs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,26 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -6742,8 +7471,29 @@ diff -urN b/go/vcs/BUILD.bazel c/go/vcs/BUILD.bazel + srcs = ["vcs_test.go"], + embed = [":vcs"], +) +diff -urN b/godoc/analysis/BUILD.bazel c/godoc/analysis/BUILD.bazel +--- b/godoc/analysis/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/godoc/analysis/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,17 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "analysis", ++ srcs = [ ++ "analysis.go", ++ "json.go", ++ ], ++ importpath = "golang.org/x/tools/godoc/analysis", ++ visibility = ["//visibility:public"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":analysis", ++ visibility = ["//visibility:public"], ++) diff -urN b/godoc/BUILD.bazel c/godoc/BUILD.bazel ---- b/godoc/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/godoc/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/godoc/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,62 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -6808,41 +7558,8 @@ diff -urN b/godoc/BUILD.bazel c/godoc/BUILD.bazel + "//godoc/vfs/mapfs", + ], +) -diff -urN b/godoc/analysis/BUILD.bazel c/godoc/analysis/BUILD.bazel ---- b/godoc/analysis/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/godoc/analysis/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ -+load("@io_bazel_rules_go//go:def.bzl", "go_library") -+ -+go_library( -+ name = "analysis", -+ srcs = [ -+ "analysis.go", -+ "callgraph.go", -+ "implements.go", -+ "json.go", -+ "peers.go", -+ "typeinfo.go", -+ ], -+ importpath = "golang.org/x/tools/godoc/analysis", -+ visibility = ["//visibility:public"], -+ deps = [ -+ "//go/callgraph", -+ "//go/loader", -+ "//go/pointer", -+ "//go/ssa", -+ "//go/ssa/ssautil", -+ "//go/types/typeutil", -+ ], -+) -+ -+alias( -+ name = "go_default_library", -+ actual = ":analysis", -+ visibility = ["//visibility:public"], -+) diff -urN b/godoc/redirect/BUILD.bazel c/godoc/redirect/BUILD.bazel ---- b/godoc/redirect/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/godoc/redirect/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/godoc/redirect/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,25 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -6871,7 +7588,7 @@ diff -urN b/godoc/redirect/BUILD.bazel c/godoc/redirect/BUILD.bazel + embed = [":redirect"], +) diff -urN b/godoc/static/BUILD.bazel c/godoc/static/BUILD.bazel ---- b/godoc/static/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/godoc/static/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/godoc/static/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -6899,7 +7616,7 @@ diff -urN b/godoc/static/BUILD.bazel c/godoc/static/BUILD.bazel + embed = [":static"], +) diff -urN b/godoc/util/BUILD.bazel c/godoc/util/BUILD.bazel ---- b/godoc/util/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/godoc/util/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/godoc/util/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -6921,7 +7638,7 @@ diff -urN b/godoc/util/BUILD.bazel c/godoc/util/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/godoc/vfs/BUILD.bazel c/godoc/vfs/BUILD.bazel ---- b/godoc/vfs/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/godoc/vfs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/godoc/vfs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,32 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -6957,7 +7674,7 @@ diff -urN b/godoc/vfs/BUILD.bazel c/godoc/vfs/BUILD.bazel + ], +) diff -urN b/godoc/vfs/gatefs/BUILD.bazel c/godoc/vfs/gatefs/BUILD.bazel ---- b/godoc/vfs/gatefs/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/godoc/vfs/gatefs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/godoc/vfs/gatefs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -6985,7 +7702,7 @@ diff -urN b/godoc/vfs/gatefs/BUILD.bazel c/godoc/vfs/gatefs/BUILD.bazel + ], +) diff -urN b/godoc/vfs/httpfs/BUILD.bazel c/godoc/vfs/httpfs/BUILD.bazel ---- b/godoc/vfs/httpfs/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/godoc/vfs/httpfs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/godoc/vfs/httpfs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7004,7 +7721,7 @@ diff -urN b/godoc/vfs/httpfs/BUILD.bazel c/godoc/vfs/httpfs/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/godoc/vfs/mapfs/BUILD.bazel c/godoc/vfs/mapfs/BUILD.bazel ---- b/godoc/vfs/mapfs/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/godoc/vfs/mapfs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/godoc/vfs/mapfs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,21 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7029,7 +7746,7 @@ diff -urN b/godoc/vfs/mapfs/BUILD.bazel c/godoc/vfs/mapfs/BUILD.bazel + embed = [":mapfs"], +) diff -urN b/godoc/vfs/zipfs/BUILD.bazel c/godoc/vfs/zipfs/BUILD.bazel ---- b/godoc/vfs/zipfs/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/godoc/vfs/zipfs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/godoc/vfs/zipfs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,22 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7055,7 +7772,7 @@ diff -urN b/godoc/vfs/zipfs/BUILD.bazel c/godoc/vfs/zipfs/BUILD.bazel + deps = ["//godoc/vfs"], +) diff -urN b/imports/BUILD.bazel c/imports/BUILD.bazel ---- b/imports/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/imports/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/imports/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7077,7 +7794,7 @@ diff -urN b/imports/BUILD.bazel c/imports/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/internal/analysisinternal/BUILD.bazel c/internal/analysisinternal/BUILD.bazel ---- b/internal/analysisinternal/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/analysisinternal/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/analysisinternal/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7099,7 +7816,7 @@ diff -urN b/internal/analysisinternal/BUILD.bazel c/internal/analysisinternal/BU + visibility = ["//:__subpackages__"], +) diff -urN b/internal/apidiff/BUILD.bazel c/internal/apidiff/BUILD.bazel ---- b/internal/apidiff/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/apidiff/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/apidiff/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7133,7 +7850,7 @@ diff -urN b/internal/apidiff/BUILD.bazel c/internal/apidiff/BUILD.bazel + ], +) diff -urN b/internal/apidiff/testdata/BUILD.bazel c/internal/apidiff/testdata/BUILD.bazel ---- b/internal/apidiff/testdata/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/apidiff/testdata/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/apidiff/testdata/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7151,7 +7868,7 @@ diff -urN b/internal/apidiff/testdata/BUILD.bazel c/internal/apidiff/testdata/BU + visibility = ["//:__subpackages__"], +) diff -urN b/internal/apidiff/testdata/exported_fields/BUILD.bazel c/internal/apidiff/testdata/exported_fields/BUILD.bazel ---- b/internal/apidiff/testdata/exported_fields/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/apidiff/testdata/exported_fields/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/apidiff/testdata/exported_fields/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7169,7 +7886,7 @@ diff -urN b/internal/apidiff/testdata/exported_fields/BUILD.bazel c/internal/api + visibility = ["//:__subpackages__"], +) diff -urN b/internal/event/BUILD.bazel c/internal/event/BUILD.bazel ---- b/internal/event/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/event/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/event/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,34 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7207,7 +7924,7 @@ diff -urN b/internal/event/BUILD.bazel c/internal/event/BUILD.bazel + ], +) diff -urN b/internal/event/core/BUILD.bazel c/internal/event/core/BUILD.bazel ---- b/internal/event/core/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/event/core/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/event/core/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,22 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7233,7 +7950,7 @@ diff -urN b/internal/event/core/BUILD.bazel c/internal/event/core/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/internal/event/export/BUILD.bazel c/internal/event/export/BUILD.bazel ---- b/internal/event/export/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/event/export/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/event/export/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,38 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7275,7 +7992,7 @@ diff -urN b/internal/event/export/BUILD.bazel c/internal/event/export/BUILD.baze + ], +) diff -urN b/internal/event/export/eventtest/BUILD.bazel c/internal/event/export/eventtest/BUILD.bazel ---- b/internal/event/export/eventtest/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/event/export/eventtest/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/event/export/eventtest/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7299,7 +8016,7 @@ diff -urN b/internal/event/export/eventtest/BUILD.bazel c/internal/event/export/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/event/export/metric/BUILD.bazel c/internal/event/export/metric/BUILD.bazel ---- b/internal/event/export/metric/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/event/export/metric/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/event/export/metric/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7327,7 +8044,7 @@ diff -urN b/internal/event/export/metric/BUILD.bazel c/internal/event/export/met + visibility = ["//:__subpackages__"], +) diff -urN b/internal/event/export/ocagent/BUILD.bazel c/internal/event/export/ocagent/BUILD.bazel ---- b/internal/event/export/ocagent/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/event/export/ocagent/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/event/export/ocagent/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,44 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7375,7 +8092,7 @@ diff -urN b/internal/event/export/ocagent/BUILD.bazel c/internal/event/export/oc + ], +) diff -urN b/internal/event/export/ocagent/wire/BUILD.bazel c/internal/event/export/ocagent/wire/BUILD.bazel ---- b/internal/event/export/ocagent/wire/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/event/export/ocagent/wire/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/event/export/ocagent/wire/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,25 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7404,7 +8121,7 @@ diff -urN b/internal/event/export/ocagent/wire/BUILD.bazel c/internal/event/expo + embed = [":wire"], +) diff -urN b/internal/event/export/prometheus/BUILD.bazel c/internal/event/export/prometheus/BUILD.bazel ---- b/internal/event/export/prometheus/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/event/export/prometheus/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/event/export/prometheus/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7428,7 +8145,7 @@ diff -urN b/internal/event/export/prometheus/BUILD.bazel c/internal/event/export + visibility = ["//:__subpackages__"], +) diff -urN b/internal/event/keys/BUILD.bazel c/internal/event/keys/BUILD.bazel ---- b/internal/event/keys/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/event/keys/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/event/keys/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7450,7 +8167,7 @@ diff -urN b/internal/event/keys/BUILD.bazel c/internal/event/keys/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/internal/event/label/BUILD.bazel c/internal/event/label/BUILD.bazel ---- b/internal/event/label/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/event/label/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/event/label/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,23 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7477,7 +8194,7 @@ diff -urN b/internal/event/label/BUILD.bazel c/internal/event/label/BUILD.bazel + ], +) diff -urN b/internal/fakenet/BUILD.bazel c/internal/fakenet/BUILD.bazel ---- b/internal/fakenet/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/fakenet/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/fakenet/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7495,7 +8212,7 @@ diff -urN b/internal/fakenet/BUILD.bazel c/internal/fakenet/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/internal/fastwalk/BUILD.bazel c/internal/fastwalk/BUILD.bazel ---- b/internal/fastwalk/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/fastwalk/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/fastwalk/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7527,7 +8244,7 @@ diff -urN b/internal/fastwalk/BUILD.bazel c/internal/fastwalk/BUILD.bazel + deps = [":fastwalk"], +) diff -urN b/internal/gocommand/BUILD.bazel c/internal/gocommand/BUILD.bazel ---- b/internal/gocommand/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/gocommand/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/gocommand/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7560,7 +8277,7 @@ diff -urN b/internal/gocommand/BUILD.bazel c/internal/gocommand/BUILD.bazel + deps = [":gocommand"], +) diff -urN b/internal/gopathwalk/BUILD.bazel c/internal/gopathwalk/BUILD.bazel ---- b/internal/gopathwalk/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/gopathwalk/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/gopathwalk/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,21 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7585,7 +8302,7 @@ diff -urN b/internal/gopathwalk/BUILD.bazel c/internal/gopathwalk/BUILD.bazel + embed = [":gopathwalk"], +) diff -urN b/internal/imports/BUILD.bazel c/internal/imports/BUILD.bazel ---- b/internal/imports/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/imports/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/imports/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,48 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7637,7 +8354,7 @@ diff -urN b/internal/imports/BUILD.bazel c/internal/imports/BUILD.bazel + ], +) diff -urN b/internal/jsonrpc2/BUILD.bazel c/internal/jsonrpc2/BUILD.bazel ---- b/internal/jsonrpc2/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/jsonrpc2/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/jsonrpc2/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,42 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7683,7 +8400,7 @@ diff -urN b/internal/jsonrpc2/BUILD.bazel c/internal/jsonrpc2/BUILD.bazel + ], +) diff -urN b/internal/jsonrpc2/servertest/BUILD.bazel c/internal/jsonrpc2/servertest/BUILD.bazel ---- b/internal/jsonrpc2/servertest/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/jsonrpc2/servertest/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/jsonrpc2/servertest/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,22 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7709,7 +8426,7 @@ diff -urN b/internal/jsonrpc2/servertest/BUILD.bazel c/internal/jsonrpc2/servert + deps = ["//internal/jsonrpc2"], +) diff -urN b/internal/jsonrpc2_v2/BUILD.bazel c/internal/jsonrpc2_v2/BUILD.bazel ---- b/internal/jsonrpc2_v2/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/jsonrpc2_v2/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/jsonrpc2_v2/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,43 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -7755,95 +8472,10 @@ diff -urN b/internal/jsonrpc2_v2/BUILD.bazel c/internal/jsonrpc2_v2/BUILD.bazel + "@org_golang_x_xerrors//:go_default_library", + ], +) -diff -urN b/internal/lsp/BUILD.bazel c/internal/lsp/BUILD.bazel ---- b/internal/lsp/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/internal/lsp/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,81 @@ -+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") -+ -+go_library( -+ name = "lsp", -+ srcs = [ -+ "call_hierarchy.go", -+ "code_action.go", -+ "code_lens.go", -+ "command.go", -+ "completion.go", -+ "debounce.go", -+ "definition.go", -+ "diagnostics.go", -+ "folding_range.go", -+ "format.go", -+ "general.go", -+ "highlight.go", -+ "hover.go", -+ "implementation.go", -+ "link.go", -+ "references.go", -+ "rename.go", -+ "semantic.go", -+ "server.go", -+ "server_gen.go", -+ "signature_help.go", -+ "symbols.go", -+ "text_synchronization.go", -+ "workspace.go", -+ "workspace_symbol.go", -+ ], -+ importpath = "golang.org/x/tools/internal/lsp", -+ visibility = ["//:__subpackages__"], -+ deps = [ -+ "//internal/event", -+ "//internal/gocommand", -+ "//internal/imports", -+ "//internal/jsonrpc2", -+ "//internal/lsp/command", -+ "//internal/lsp/debug", -+ "//internal/lsp/debug/log", -+ "//internal/lsp/debug/tag", -+ "//internal/lsp/mod", -+ "//internal/lsp/progress", -+ "//internal/lsp/protocol", -+ "//internal/lsp/source", -+ "//internal/lsp/source/completion", -+ "//internal/lsp/template", -+ "//internal/span", -+ "//internal/xcontext", -+ "@org_golang_x_mod//modfile:go_default_library", -+ "@org_golang_x_xerrors//:go_default_library", -+ ], -+) -+ -+alias( -+ name = "go_default_library", -+ actual = ":lsp", -+ visibility = ["//:__subpackages__"], -+) -+ -+go_test( -+ name = "lsp_test", -+ srcs = [ -+ "completion_test.go", -+ "debounce_test.go", -+ "lsp_test.go", -+ ], -+ embed = [":lsp"], -+ deps = [ -+ "//internal/lsp/cache", -+ "//internal/lsp/command", -+ "//internal/lsp/diff", -+ "//internal/lsp/diff/myers", -+ "//internal/lsp/protocol", -+ "//internal/lsp/source", -+ "//internal/lsp/tests", -+ "//internal/span", -+ "//internal/testenv", -+ ], -+) diff -urN b/internal/lsp/analysis/fillreturns/BUILD.bazel c/internal/lsp/analysis/fillreturns/BUILD.bazel ---- b/internal/lsp/analysis/fillreturns/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/fillreturns/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/fillreturns/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,28 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -7855,6 +8487,7 @@ diff -urN b/internal/lsp/analysis/fillreturns/BUILD.bazel c/internal/lsp/analysi + "//go/analysis", + "//go/ast/astutil", + "//internal/analysisinternal", ++ "//internal/typeparams", + ], +) + @@ -7870,10 +8503,11 @@ diff -urN b/internal/lsp/analysis/fillreturns/BUILD.bazel c/internal/lsp/analysi + deps = [ + ":fillreturns", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/internal/lsp/analysis/fillreturns/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/fillreturns/testdata/src/a/BUILD.bazel ---- b/internal/lsp/analysis/fillreturns/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/fillreturns/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/fillreturns/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7890,10 +8524,28 @@ diff -urN b/internal/lsp/analysis/fillreturns/testdata/src/a/BUILD.bazel c/inter + actual = ":a", + visibility = ["//:__subpackages__"], +) +diff -urN b/internal/lsp/analysis/fillreturns/testdata/src/a/typeparams/BUILD.bazel c/internal/lsp/analysis/fillreturns/testdata/src/a/typeparams/BUILD.bazel +--- b/internal/lsp/analysis/fillreturns/testdata/src/a/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/analysis/fillreturns/testdata/src/a/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["a.go"], ++ importpath = "golang.org/x/tools/internal/lsp/analysis/fillreturns/testdata/src/a/typeparams", ++ visibility = ["//:__subpackages__"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//:__subpackages__"], ++) diff -urN b/internal/lsp/analysis/fillstruct/BUILD.bazel c/internal/lsp/analysis/fillstruct/BUILD.bazel ---- b/internal/lsp/analysis/fillstruct/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/fillstruct/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/fillstruct/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,31 @@ +@@ -0,0 +1,33 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -7908,6 +8560,7 @@ diff -urN b/internal/lsp/analysis/fillstruct/BUILD.bazel c/internal/lsp/analysis + "//go/ast/inspector", + "//internal/analysisinternal", + "//internal/span", ++ "//internal/typeparams", + ], +) + @@ -7923,10 +8576,11 @@ diff -urN b/internal/lsp/analysis/fillstruct/BUILD.bazel c/internal/lsp/analysis + deps = [ + ":fillstruct", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/internal/lsp/analysis/fillstruct/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/fillstruct/testdata/src/a/BUILD.bazel ---- b/internal/lsp/analysis/fillstruct/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/fillstruct/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/fillstruct/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7944,7 +8598,7 @@ diff -urN b/internal/lsp/analysis/fillstruct/testdata/src/a/BUILD.bazel c/intern + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/analysis/fillstruct/testdata/src/b/BUILD.bazel c/internal/lsp/analysis/fillstruct/testdata/src/b/BUILD.bazel ---- b/internal/lsp/analysis/fillstruct/testdata/src/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/fillstruct/testdata/src/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/fillstruct/testdata/src/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -7961,10 +8615,107 @@ diff -urN b/internal/lsp/analysis/fillstruct/testdata/src/b/BUILD.bazel c/intern + actual = ":b", + visibility = ["//:__subpackages__"], +) +diff -urN b/internal/lsp/analysis/fillstruct/testdata/src/typeparams/BUILD.bazel c/internal/lsp/analysis/fillstruct/testdata/src/typeparams/BUILD.bazel +--- b/internal/lsp/analysis/fillstruct/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/analysis/fillstruct/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/internal/lsp/analysis/fillstruct/testdata/src/typeparams", ++ visibility = ["//:__subpackages__"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//:__subpackages__"], ++) +diff -urN b/internal/lsp/analysis/infertypeargs/BUILD.bazel c/internal/lsp/analysis/infertypeargs/BUILD.bazel +--- b/internal/lsp/analysis/infertypeargs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/analysis/infertypeargs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,35 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") ++ ++go_library( ++ name = "infertypeargs", ++ srcs = [ ++ "infertypeargs.go", ++ "run_go117.go", ++ "run_go118.go", ++ ], ++ importpath = "golang.org/x/tools/internal/lsp/analysis/infertypeargs", ++ visibility = ["//:__subpackages__"], ++ deps = [ ++ "//go/analysis", ++ "//go/analysis/passes/inspect", ++ "//go/ast/inspector", ++ "//internal/typeparams", ++ ], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":infertypeargs", ++ visibility = ["//:__subpackages__"], ++) ++ ++go_test( ++ name = "infertypeargs_test", ++ srcs = ["infertypeargs_test.go"], ++ deps = [ ++ ":infertypeargs", ++ "//go/analysis/analysistest", ++ "//internal/testenv", ++ "//internal/typeparams", ++ ], ++) +diff -urN b/internal/lsp/analysis/infertypeargs/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/infertypeargs/testdata/src/a/BUILD.bazel +--- b/internal/lsp/analysis/infertypeargs/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/analysis/infertypeargs/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,18 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "a", ++ srcs = [ ++ "basic.go", ++ "imported.go", ++ "notypechange.go", ++ ], ++ importpath = "golang.org/x/tools/internal/lsp/analysis/infertypeargs/testdata/src/a", ++ visibility = ["//:__subpackages__"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":a", ++ visibility = ["//:__subpackages__"], ++) +diff -urN b/internal/lsp/analysis/infertypeargs/testdata/src/a/imported/BUILD.bazel c/internal/lsp/analysis/infertypeargs/testdata/src/a/imported/BUILD.bazel +--- b/internal/lsp/analysis/infertypeargs/testdata/src/a/imported/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/analysis/infertypeargs/testdata/src/a/imported/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "imported", ++ srcs = ["imported.go"], ++ importpath = "golang.org/x/tools/internal/lsp/analysis/infertypeargs/testdata/src/a/imported", ++ visibility = ["//:__subpackages__"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":imported", ++ visibility = ["//:__subpackages__"], ++) diff -urN b/internal/lsp/analysis/nonewvars/BUILD.bazel c/internal/lsp/analysis/nonewvars/BUILD.bazel ---- b/internal/lsp/analysis/nonewvars/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/nonewvars/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/nonewvars/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -7992,10 +8743,11 @@ diff -urN b/internal/lsp/analysis/nonewvars/BUILD.bazel c/internal/lsp/analysis/ + deps = [ + ":nonewvars", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/internal/lsp/analysis/nonewvars/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/nonewvars/testdata/src/a/BUILD.bazel ---- b/internal/lsp/analysis/nonewvars/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/nonewvars/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/nonewvars/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8012,10 +8764,28 @@ diff -urN b/internal/lsp/analysis/nonewvars/testdata/src/a/BUILD.bazel c/interna + actual = ":a", + visibility = ["//:__subpackages__"], +) +diff -urN b/internal/lsp/analysis/nonewvars/testdata/src/typeparams/BUILD.bazel c/internal/lsp/analysis/nonewvars/testdata/src/typeparams/BUILD.bazel +--- b/internal/lsp/analysis/nonewvars/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/analysis/nonewvars/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["a.go"], ++ importpath = "golang.org/x/tools/internal/lsp/analysis/nonewvars/testdata/src/typeparams", ++ visibility = ["//:__subpackages__"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//:__subpackages__"], ++) diff -urN b/internal/lsp/analysis/noresultvalues/BUILD.bazel c/internal/lsp/analysis/noresultvalues/BUILD.bazel ---- b/internal/lsp/analysis/noresultvalues/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/noresultvalues/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/noresultvalues/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,29 @@ +@@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -8043,10 +8813,11 @@ diff -urN b/internal/lsp/analysis/noresultvalues/BUILD.bazel c/internal/lsp/anal + deps = [ + ":noresultvalues", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/internal/lsp/analysis/noresultvalues/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/noresultvalues/testdata/src/a/BUILD.bazel ---- b/internal/lsp/analysis/noresultvalues/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/noresultvalues/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/noresultvalues/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8063,8 +8834,26 @@ diff -urN b/internal/lsp/analysis/noresultvalues/testdata/src/a/BUILD.bazel c/in + actual = ":a", + visibility = ["//:__subpackages__"], +) +diff -urN b/internal/lsp/analysis/noresultvalues/testdata/src/typeparams/BUILD.bazel c/internal/lsp/analysis/noresultvalues/testdata/src/typeparams/BUILD.bazel +--- b/internal/lsp/analysis/noresultvalues/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/analysis/noresultvalues/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["a.go"], ++ importpath = "golang.org/x/tools/internal/lsp/analysis/noresultvalues/testdata/src/typeparams", ++ visibility = ["//:__subpackages__"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//:__subpackages__"], ++) diff -urN b/internal/lsp/analysis/simplifycompositelit/BUILD.bazel c/internal/lsp/analysis/simplifycompositelit/BUILD.bazel ---- b/internal/lsp/analysis/simplifycompositelit/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/simplifycompositelit/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/simplifycompositelit/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8096,7 +8885,7 @@ diff -urN b/internal/lsp/analysis/simplifycompositelit/BUILD.bazel c/internal/ls + ], +) diff -urN b/internal/lsp/analysis/simplifycompositelit/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/simplifycompositelit/testdata/src/a/BUILD.bazel ---- b/internal/lsp/analysis/simplifycompositelit/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/simplifycompositelit/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/simplifycompositelit/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8114,7 +8903,7 @@ diff -urN b/internal/lsp/analysis/simplifycompositelit/testdata/src/a/BUILD.baze + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/analysis/simplifyrange/BUILD.bazel c/internal/lsp/analysis/simplifyrange/BUILD.bazel ---- b/internal/lsp/analysis/simplifyrange/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/simplifyrange/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/simplifyrange/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8146,7 +8935,7 @@ diff -urN b/internal/lsp/analysis/simplifyrange/BUILD.bazel c/internal/lsp/analy + ], +) diff -urN b/internal/lsp/analysis/simplifyrange/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/simplifyrange/testdata/src/a/BUILD.bazel ---- b/internal/lsp/analysis/simplifyrange/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/simplifyrange/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/simplifyrange/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8164,9 +8953,9 @@ diff -urN b/internal/lsp/analysis/simplifyrange/testdata/src/a/BUILD.bazel c/int + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/analysis/simplifyslice/BUILD.bazel c/internal/lsp/analysis/simplifyslice/BUILD.bazel ---- b/internal/lsp/analysis/simplifyslice/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/simplifyslice/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/simplifyslice/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,28 @@ +@@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -8193,10 +8982,11 @@ diff -urN b/internal/lsp/analysis/simplifyslice/BUILD.bazel c/internal/lsp/analy + deps = [ + ":simplifyslice", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/internal/lsp/analysis/simplifyslice/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/simplifyslice/testdata/src/a/BUILD.bazel ---- b/internal/lsp/analysis/simplifyslice/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/simplifyslice/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/simplifyslice/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8213,8 +9003,26 @@ diff -urN b/internal/lsp/analysis/simplifyslice/testdata/src/a/BUILD.bazel c/int + actual = ":a", + visibility = ["//:__subpackages__"], +) +diff -urN b/internal/lsp/analysis/simplifyslice/testdata/src/typeparams/BUILD.bazel c/internal/lsp/analysis/simplifyslice/testdata/src/typeparams/BUILD.bazel +--- b/internal/lsp/analysis/simplifyslice/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/analysis/simplifyslice/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/internal/lsp/analysis/simplifyslice/testdata/src/typeparams", ++ visibility = ["//:__subpackages__"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//:__subpackages__"], ++) diff -urN b/internal/lsp/analysis/undeclaredname/BUILD.bazel c/internal/lsp/analysis/undeclaredname/BUILD.bazel ---- b/internal/lsp/analysis/undeclaredname/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/undeclaredname/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/undeclaredname/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8247,7 +9055,7 @@ diff -urN b/internal/lsp/analysis/undeclaredname/BUILD.bazel c/internal/lsp/anal + ], +) diff -urN b/internal/lsp/analysis/undeclaredname/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/undeclaredname/testdata/src/a/BUILD.bazel ---- b/internal/lsp/analysis/undeclaredname/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/undeclaredname/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/undeclaredname/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,25 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8276,9 +9084,9 @@ diff -urN b/internal/lsp/analysis/undeclaredname/testdata/src/a/BUILD.bazel c/in + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/analysis/unusedparams/BUILD.bazel c/internal/lsp/analysis/unusedparams/BUILD.bazel ---- b/internal/lsp/analysis/unusedparams/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/unusedparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/unusedparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,28 @@ +@@ -0,0 +1,29 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -8305,10 +9113,11 @@ diff -urN b/internal/lsp/analysis/unusedparams/BUILD.bazel c/internal/lsp/analys + deps = [ + ":unusedparams", + "//go/analysis/analysistest", ++ "//internal/typeparams", + ], +) diff -urN b/internal/lsp/analysis/unusedparams/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/unusedparams/testdata/src/a/BUILD.bazel ---- b/internal/lsp/analysis/unusedparams/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/unusedparams/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/unusedparams/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8325,8 +9134,26 @@ diff -urN b/internal/lsp/analysis/unusedparams/testdata/src/a/BUILD.bazel c/inte + actual = ":a", + visibility = ["//:__subpackages__"], +) +diff -urN b/internal/lsp/analysis/unusedparams/testdata/src/typeparams/BUILD.bazel c/internal/lsp/analysis/unusedparams/testdata/src/typeparams/BUILD.bazel +--- b/internal/lsp/analysis/unusedparams/testdata/src/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/analysis/unusedparams/testdata/src/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "typeparams", ++ srcs = ["typeparams.go"], ++ importpath = "golang.org/x/tools/internal/lsp/analysis/unusedparams/testdata/src/typeparams", ++ visibility = ["//:__subpackages__"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":typeparams", ++ visibility = ["//:__subpackages__"], ++) diff -urN b/internal/lsp/analysis/useany/BUILD.bazel c/internal/lsp/analysis/useany/BUILD.bazel ---- b/internal/lsp/analysis/useany/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/useany/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/useany/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8360,7 +9187,7 @@ diff -urN b/internal/lsp/analysis/useany/BUILD.bazel c/internal/lsp/analysis/use + ], +) diff -urN b/internal/lsp/analysis/useany/testdata/src/a/BUILD.bazel c/internal/lsp/analysis/useany/testdata/src/a/BUILD.bazel ---- b/internal/lsp/analysis/useany/testdata/src/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/analysis/useany/testdata/src/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/analysis/useany/testdata/src/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8378,7 +9205,7 @@ diff -urN b/internal/lsp/analysis/useany/testdata/src/a/BUILD.bazel c/internal/l + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/browser/BUILD.bazel c/internal/lsp/browser/BUILD.bazel ---- b/internal/lsp/browser/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/browser/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/browser/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8396,8 +9223,94 @@ diff -urN b/internal/lsp/browser/BUILD.bazel c/internal/lsp/browser/BUILD.bazel + actual = ":browser", + visibility = ["//:__subpackages__"], +) +diff -urN b/internal/lsp/BUILD.bazel c/internal/lsp/BUILD.bazel +--- b/internal/lsp/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,82 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") ++ ++go_library( ++ name = "lsp", ++ srcs = [ ++ "call_hierarchy.go", ++ "code_action.go", ++ "code_lens.go", ++ "command.go", ++ "completion.go", ++ "debounce.go", ++ "definition.go", ++ "diagnostics.go", ++ "folding_range.go", ++ "format.go", ++ "general.go", ++ "highlight.go", ++ "hover.go", ++ "implementation.go", ++ "link.go", ++ "references.go", ++ "rename.go", ++ "semantic.go", ++ "server.go", ++ "server_gen.go", ++ "signature_help.go", ++ "symbols.go", ++ "text_synchronization.go", ++ "workspace.go", ++ "workspace_symbol.go", ++ ], ++ importpath = "golang.org/x/tools/internal/lsp", ++ visibility = ["//:__subpackages__"], ++ deps = [ ++ "//internal/event", ++ "//internal/gocommand", ++ "//internal/imports", ++ "//internal/jsonrpc2", ++ "//internal/lsp/command", ++ "//internal/lsp/debug", ++ "//internal/lsp/debug/log", ++ "//internal/lsp/debug/tag", ++ "//internal/lsp/mod", ++ "//internal/lsp/progress", ++ "//internal/lsp/protocol", ++ "//internal/lsp/source", ++ "//internal/lsp/source/completion", ++ "//internal/lsp/template", ++ "//internal/span", ++ "//internal/typeparams", ++ "//internal/xcontext", ++ "@org_golang_x_mod//modfile:go_default_library", ++ "@org_golang_x_xerrors//:go_default_library", ++ ], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":lsp", ++ visibility = ["//:__subpackages__"], ++) ++ ++go_test( ++ name = "lsp_test", ++ srcs = [ ++ "completion_test.go", ++ "debounce_test.go", ++ "lsp_test.go", ++ ], ++ embed = [":lsp"], ++ deps = [ ++ "//internal/lsp/cache", ++ "//internal/lsp/command", ++ "//internal/lsp/diff", ++ "//internal/lsp/diff/myers", ++ "//internal/lsp/protocol", ++ "//internal/lsp/source", ++ "//internal/lsp/tests", ++ "//internal/span", ++ "//internal/testenv", ++ ], ++) diff -urN b/internal/lsp/cache/BUILD.bazel c/internal/lsp/cache/BUILD.bazel ---- b/internal/lsp/cache/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/cache/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/cache/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,83 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8484,7 +9397,7 @@ diff -urN b/internal/lsp/cache/BUILD.bazel c/internal/lsp/cache/BUILD.bazel + ], +) diff -urN b/internal/lsp/cmd/BUILD.bazel c/internal/lsp/cmd/BUILD.bazel ---- b/internal/lsp/cmd/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/cmd/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/cmd/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,74 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8562,7 +9475,7 @@ diff -urN b/internal/lsp/cmd/BUILD.bazel c/internal/lsp/cmd/BUILD.bazel + ], +) diff -urN b/internal/lsp/cmd/test/BUILD.bazel c/internal/lsp/cmd/test/BUILD.bazel ---- b/internal/lsp/cmd/test/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/cmd/test/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/cmd/test/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,49 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8615,7 +9528,7 @@ diff -urN b/internal/lsp/cmd/test/BUILD.bazel c/internal/lsp/cmd/test/BUILD.baze + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/command/BUILD.bazel c/internal/lsp/command/BUILD.bazel ---- b/internal/lsp/command/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/command/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/command/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8647,7 +9560,7 @@ diff -urN b/internal/lsp/command/BUILD.bazel c/internal/lsp/command/BUILD.bazel + ], +) diff -urN b/internal/lsp/command/commandmeta/BUILD.bazel c/internal/lsp/command/commandmeta/BUILD.bazel ---- b/internal/lsp/command/commandmeta/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/command/commandmeta/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/command/commandmeta/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,19 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8670,7 +9583,7 @@ diff -urN b/internal/lsp/command/commandmeta/BUILD.bazel c/internal/lsp/command/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/command/gen/BUILD.bazel c/internal/lsp/command/gen/BUILD.bazel ---- b/internal/lsp/command/gen/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/command/gen/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/command/gen/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8692,7 +9605,7 @@ diff -urN b/internal/lsp/command/gen/BUILD.bazel c/internal/lsp/command/gen/BUIL + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/debug/BUILD.bazel c/internal/lsp/debug/BUILD.bazel ---- b/internal/lsp/debug/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/debug/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/debug/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,36 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8732,7 +9645,7 @@ diff -urN b/internal/lsp/debug/BUILD.bazel c/internal/lsp/debug/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/debug/log/BUILD.bazel c/internal/lsp/debug/log/BUILD.bazel ---- b/internal/lsp/debug/log/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/debug/log/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/debug/log/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,19 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8755,7 +9668,7 @@ diff -urN b/internal/lsp/debug/log/BUILD.bazel c/internal/lsp/debug/log/BUILD.ba + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/debug/tag/BUILD.bazel c/internal/lsp/debug/tag/BUILD.bazel ---- b/internal/lsp/debug/tag/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/debug/tag/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/debug/tag/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8774,7 +9687,7 @@ diff -urN b/internal/lsp/debug/tag/BUILD.bazel c/internal/lsp/debug/tag/BUILD.ba + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/diff/BUILD.bazel c/internal/lsp/diff/BUILD.bazel ---- b/internal/lsp/diff/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/diff/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/diff/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8806,7 +9719,7 @@ diff -urN b/internal/lsp/diff/BUILD.bazel c/internal/lsp/diff/BUILD.bazel + ], +) diff -urN b/internal/lsp/diff/difftest/BUILD.bazel c/internal/lsp/diff/difftest/BUILD.bazel ---- b/internal/lsp/diff/difftest/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/diff/difftest/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/diff/difftest/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,27 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8837,7 +9750,7 @@ diff -urN b/internal/lsp/diff/difftest/BUILD.bazel c/internal/lsp/diff/difftest/ + ], +) diff -urN b/internal/lsp/diff/myers/BUILD.bazel c/internal/lsp/diff/myers/BUILD.bazel ---- b/internal/lsp/diff/myers/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/diff/myers/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/diff/myers/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,27 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8868,7 +9781,7 @@ diff -urN b/internal/lsp/diff/myers/BUILD.bazel c/internal/lsp/diff/myers/BUILD. + ], +) diff -urN b/internal/lsp/fake/BUILD.bazel c/internal/lsp/fake/BUILD.bazel ---- b/internal/lsp/fake/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/fake/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/fake/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,44 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8916,7 +9829,7 @@ diff -urN b/internal/lsp/fake/BUILD.bazel c/internal/lsp/fake/BUILD.bazel + deps = ["//internal/lsp/protocol"], +) diff -urN b/internal/lsp/fuzzy/BUILD.bazel c/internal/lsp/fuzzy/BUILD.bazel ---- b/internal/lsp/fuzzy/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/fuzzy/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/fuzzy/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -8948,7 +9861,7 @@ diff -urN b/internal/lsp/fuzzy/BUILD.bazel c/internal/lsp/fuzzy/BUILD.bazel + deps = [":fuzzy"], +) diff -urN b/internal/lsp/helper/BUILD.bazel c/internal/lsp/helper/BUILD.bazel ---- b/internal/lsp/helper/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/helper/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/helper/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -8966,7 +9879,7 @@ diff -urN b/internal/lsp/helper/BUILD.bazel c/internal/lsp/helper/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/lsppos/BUILD.bazel c/internal/lsp/lsppos/BUILD.bazel ---- b/internal/lsp/lsppos/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/lsppos/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/lsppos/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -8984,7 +9897,7 @@ diff -urN b/internal/lsp/lsppos/BUILD.bazel c/internal/lsp/lsppos/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/lsprpc/BUILD.bazel c/internal/lsp/lsprpc/BUILD.bazel ---- b/internal/lsp/lsprpc/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/lsprpc/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/lsprpc/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,61 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -9049,7 +9962,7 @@ diff -urN b/internal/lsp/lsprpc/BUILD.bazel c/internal/lsp/lsprpc/BUILD.bazel + ], +) diff -urN b/internal/lsp/mod/BUILD.bazel c/internal/lsp/mod/BUILD.bazel ---- b/internal/lsp/mod/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/mod/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/mod/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,42 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -9095,7 +10008,7 @@ diff -urN b/internal/lsp/mod/BUILD.bazel c/internal/lsp/mod/BUILD.bazel + ], +) diff -urN b/internal/lsp/mod/testdata/unchanged/BUILD.bazel c/internal/lsp/mod/testdata/unchanged/BUILD.bazel ---- b/internal/lsp/mod/testdata/unchanged/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/mod/testdata/unchanged/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/mod/testdata/unchanged/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9113,7 +10026,7 @@ diff -urN b/internal/lsp/mod/testdata/unchanged/BUILD.bazel c/internal/lsp/mod/t + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/progress/BUILD.bazel c/internal/lsp/progress/BUILD.bazel ---- b/internal/lsp/progress/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/progress/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/progress/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -9145,7 +10058,7 @@ diff -urN b/internal/lsp/progress/BUILD.bazel c/internal/lsp/progress/BUILD.baze + deps = ["//internal/lsp/protocol"], +) diff -urN b/internal/lsp/protocol/BUILD.bazel c/internal/lsp/protocol/BUILD.bazel ---- b/internal/lsp/protocol/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/protocol/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/protocol/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,36 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9185,7 +10098,7 @@ diff -urN b/internal/lsp/protocol/BUILD.bazel c/internal/lsp/protocol/BUILD.baze + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/regtest/BUILD.bazel c/internal/lsp/regtest/BUILD.bazel ---- b/internal/lsp/regtest/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/regtest/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/regtest/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,45 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -9234,7 +10147,7 @@ diff -urN b/internal/lsp/regtest/BUILD.bazel c/internal/lsp/regtest/BUILD.bazel + deps = ["//internal/lsp/protocol"], +) diff -urN b/internal/lsp/snippet/BUILD.bazel c/internal/lsp/snippet/BUILD.bazel ---- b/internal/lsp/snippet/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/snippet/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/snippet/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -9258,9 +10171,9 @@ diff -urN b/internal/lsp/snippet/BUILD.bazel c/internal/lsp/snippet/BUILD.bazel + embed = [":snippet"], +) diff -urN b/internal/lsp/source/BUILD.bazel c/internal/lsp/source/BUILD.bazel ---- b/internal/lsp/source/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/source/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/source/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,132 @@ +@@ -0,0 +1,135 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -9337,6 +10250,7 @@ diff -urN b/internal/lsp/source/BUILD.bazel c/internal/lsp/source/BUILD.bazel + "//internal/imports", + "//internal/lsp/analysis/fillreturns", + "//internal/lsp/analysis/fillstruct", ++ "//internal/lsp/analysis/infertypeargs", + "//internal/lsp/analysis/nonewvars", + "//internal/lsp/analysis/noresultvalues", + "//internal/lsp/analysis/simplifycompositelit", @@ -9375,12 +10289,14 @@ diff -urN b/internal/lsp/source/BUILD.bazel c/internal/lsp/source/BUILD.bazel + "comment_test.go", + "format_test.go", + "identifier_test.go", ++ "offset_test.go", + "options_test.go", + "source_test.go", + "workspace_symbol_test.go", + ], + embed = [":source"], + deps = [ ++ "//go/packages", + "//internal/lsp/cache", + "//internal/lsp/diff", + "//internal/lsp/diff/myers", @@ -9394,7 +10310,7 @@ diff -urN b/internal/lsp/source/BUILD.bazel c/internal/lsp/source/BUILD.bazel + ], +) diff -urN b/internal/lsp/source/completion/BUILD.bazel c/internal/lsp/source/completion/BUILD.bazel ---- b/internal/lsp/source/completion/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/source/completion/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/source/completion/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,53 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -9451,7 +10367,7 @@ diff -urN b/internal/lsp/source/completion/BUILD.bazel c/internal/lsp/source/com + embed = [":completion"], +) diff -urN b/internal/lsp/template/BUILD.bazel c/internal/lsp/template/BUILD.bazel ---- b/internal/lsp/template/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/template/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/template/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,37 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -9491,26 +10407,8 @@ diff -urN b/internal/lsp/template/BUILD.bazel c/internal/lsp/template/BUILD.baze + embed = [":template"], + deps = ["//internal/lsp/protocol"], +) -diff -urN b/internal/lsp/testdata/%percent/BUILD.bazel c/internal/lsp/testdata/%percent/BUILD.bazel ---- b/internal/lsp/testdata/%percent/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/internal/lsp/testdata/%percent/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,14 @@ -+load("@io_bazel_rules_go//go:def.bzl", "go_library") -+ -+go_library( -+ name = "%percent", -+ srcs = ["perc%ent.go"], -+ importpath = "golang.org/x/tools/internal/lsp/testdata/%percent", -+ visibility = ["//:__subpackages__"], -+) -+ -+alias( -+ name = "go_default_library", -+ actual = ":%percent", -+ visibility = ["//:__subpackages__"], -+) diff -urN b/internal/lsp/testdata/address/BUILD.bazel c/internal/lsp/testdata/address/BUILD.bazel ---- b/internal/lsp/testdata/address/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/address/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/address/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9528,7 +10426,7 @@ diff -urN b/internal/lsp/testdata/address/BUILD.bazel c/internal/lsp/testdata/ad + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/analyzer/BUILD.bazel c/internal/lsp/testdata/analyzer/BUILD.bazel ---- b/internal/lsp/testdata/analyzer/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/analyzer/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/analyzer/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,6 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_test") @@ -9538,7 +10436,7 @@ diff -urN b/internal/lsp/testdata/analyzer/BUILD.bazel c/internal/lsp/testdata/a + srcs = ["bad_test.go"], +) diff -urN b/internal/lsp/testdata/append/BUILD.bazel c/internal/lsp/testdata/append/BUILD.bazel ---- b/internal/lsp/testdata/append/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/append/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/append/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9556,7 +10454,7 @@ diff -urN b/internal/lsp/testdata/append/BUILD.bazel c/internal/lsp/testdata/app + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/assign/internal/secret/BUILD.bazel c/internal/lsp/testdata/assign/internal/secret/BUILD.bazel ---- b/internal/lsp/testdata/assign/internal/secret/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/assign/internal/secret/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/assign/internal/secret/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9574,7 +10472,7 @@ diff -urN b/internal/lsp/testdata/assign/internal/secret/BUILD.bazel c/internal/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/bad/BUILD.bazel c/internal/lsp/testdata/bad/BUILD.bazel ---- b/internal/lsp/testdata/bad/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/bad/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/bad/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9595,7 +10493,7 @@ diff -urN b/internal/lsp/testdata/bad/BUILD.bazel c/internal/lsp/testdata/bad/BU + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/basiclit/BUILD.bazel c/internal/lsp/testdata/basiclit/BUILD.bazel ---- b/internal/lsp/testdata/basiclit/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/basiclit/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/basiclit/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9613,7 +10511,7 @@ diff -urN b/internal/lsp/testdata/basiclit/BUILD.bazel c/internal/lsp/testdata/b + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/builtins/BUILD.bazel c/internal/lsp/testdata/builtins/BUILD.bazel ---- b/internal/lsp/testdata/builtins/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/builtins/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/builtins/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,19 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9636,7 +10534,7 @@ diff -urN b/internal/lsp/testdata/builtins/BUILD.bazel c/internal/lsp/testdata/b + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/callhierarchy/BUILD.bazel c/internal/lsp/testdata/callhierarchy/BUILD.bazel ---- b/internal/lsp/testdata/callhierarchy/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/callhierarchy/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/callhierarchy/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9654,7 +10552,7 @@ diff -urN b/internal/lsp/testdata/callhierarchy/BUILD.bazel c/internal/lsp/testd + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/callhierarchy/incoming/BUILD.bazel c/internal/lsp/testdata/callhierarchy/incoming/BUILD.bazel ---- b/internal/lsp/testdata/callhierarchy/incoming/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/callhierarchy/incoming/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/callhierarchy/incoming/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9672,7 +10570,7 @@ diff -urN b/internal/lsp/testdata/callhierarchy/incoming/BUILD.bazel c/internal/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/callhierarchy/outgoing/BUILD.bazel c/internal/lsp/testdata/callhierarchy/outgoing/BUILD.bazel ---- b/internal/lsp/testdata/callhierarchy/outgoing/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/callhierarchy/outgoing/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/callhierarchy/outgoing/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9690,7 +10588,7 @@ diff -urN b/internal/lsp/testdata/callhierarchy/outgoing/BUILD.bazel c/internal/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/casesensitive/BUILD.bazel c/internal/lsp/testdata/casesensitive/BUILD.bazel ---- b/internal/lsp/testdata/casesensitive/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/casesensitive/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/casesensitive/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9708,7 +10606,7 @@ diff -urN b/internal/lsp/testdata/casesensitive/BUILD.bazel c/internal/lsp/testd + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/cgo/BUILD.bazel c/internal/lsp/testdata/cgo/BUILD.bazel ---- b/internal/lsp/testdata/cgo/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/cgo/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/cgo/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9730,7 +10628,7 @@ diff -urN b/internal/lsp/testdata/cgo/BUILD.bazel c/internal/lsp/testdata/cgo/BU + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/channel/BUILD.bazel c/internal/lsp/testdata/channel/BUILD.bazel ---- b/internal/lsp/testdata/channel/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/channel/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/channel/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9748,7 +10646,7 @@ diff -urN b/internal/lsp/testdata/channel/BUILD.bazel c/internal/lsp/testdata/ch + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/codelens/BUILD.bazel c/internal/lsp/testdata/codelens/BUILD.bazel ---- b/internal/lsp/testdata/codelens/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/codelens/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/codelens/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,6 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_test") @@ -9758,7 +10656,7 @@ diff -urN b/internal/lsp/testdata/codelens/BUILD.bazel c/internal/lsp/testdata/c + srcs = ["codelens_test.go"], +) diff -urN b/internal/lsp/testdata/constant/BUILD.bazel c/internal/lsp/testdata/constant/BUILD.bazel ---- b/internal/lsp/testdata/constant/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/constant/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/constant/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9776,7 +10674,7 @@ diff -urN b/internal/lsp/testdata/constant/BUILD.bazel c/internal/lsp/testdata/c + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/danglingstmt/BUILD.bazel c/internal/lsp/testdata/danglingstmt/BUILD.bazel ---- b/internal/lsp/testdata/danglingstmt/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/danglingstmt/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/danglingstmt/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,28 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9808,7 +10706,7 @@ diff -urN b/internal/lsp/testdata/danglingstmt/BUILD.bazel c/internal/lsp/testda + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/deep/BUILD.bazel c/internal/lsp/testdata/deep/BUILD.bazel ---- b/internal/lsp/testdata/deep/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/deep/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/deep/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9826,7 +10724,7 @@ diff -urN b/internal/lsp/testdata/deep/BUILD.bazel c/internal/lsp/testdata/deep/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/errors/BUILD.bazel c/internal/lsp/testdata/errors/BUILD.bazel ---- b/internal/lsp/testdata/errors/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/errors/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/errors/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9844,7 +10742,7 @@ diff -urN b/internal/lsp/testdata/errors/BUILD.bazel c/internal/lsp/testdata/err + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/extract/extract_function/BUILD.bazel c/internal/lsp/testdata/extract/extract_function/BUILD.bazel ---- b/internal/lsp/testdata/extract/extract_function/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/extract/extract_function/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/extract/extract_function/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,32 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9880,7 +10778,7 @@ diff -urN b/internal/lsp/testdata/extract/extract_function/BUILD.bazel c/interna + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/extract/extract_method/BUILD.bazel c/internal/lsp/testdata/extract/extract_method/BUILD.bazel ---- b/internal/lsp/testdata/extract/extract_method/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/extract/extract_method/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/extract/extract_method/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9898,7 +10796,7 @@ diff -urN b/internal/lsp/testdata/extract/extract_method/BUILD.bazel c/internal/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/extract/extract_variable/BUILD.bazel c/internal/lsp/testdata/extract/extract_variable/BUILD.bazel ---- b/internal/lsp/testdata/extract/extract_variable/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/extract/extract_variable/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/extract/extract_variable/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9920,7 +10818,7 @@ diff -urN b/internal/lsp/testdata/extract/extract_variable/BUILD.bazel c/interna + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/fieldlist/BUILD.bazel c/internal/lsp/testdata/fieldlist/BUILD.bazel ---- b/internal/lsp/testdata/fieldlist/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/fieldlist/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/fieldlist/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9938,7 +10836,7 @@ diff -urN b/internal/lsp/testdata/fieldlist/BUILD.bazel c/internal/lsp/testdata/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/fillstruct/BUILD.bazel c/internal/lsp/testdata/fillstruct/BUILD.bazel ---- b/internal/lsp/testdata/fillstruct/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/fillstruct/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/fillstruct/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,25 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9967,7 +10865,7 @@ diff -urN b/internal/lsp/testdata/fillstruct/BUILD.bazel c/internal/lsp/testdata + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/fillstruct/data/BUILD.bazel c/internal/lsp/testdata/fillstruct/data/BUILD.bazel ---- b/internal/lsp/testdata/fillstruct/data/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/fillstruct/data/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/fillstruct/data/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -9985,7 +10883,7 @@ diff -urN b/internal/lsp/testdata/fillstruct/data/BUILD.bazel c/internal/lsp/tes + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/folding/BUILD.bazel c/internal/lsp/testdata/folding/BUILD.bazel ---- b/internal/lsp/testdata/folding/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/folding/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/folding/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10003,7 +10901,7 @@ diff -urN b/internal/lsp/testdata/folding/BUILD.bazel c/internal/lsp/testdata/fo + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/foo/BUILD.bazel c/internal/lsp/testdata/foo/BUILD.bazel ---- b/internal/lsp/testdata/foo/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/foo/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/foo/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10021,7 +10919,7 @@ diff -urN b/internal/lsp/testdata/foo/BUILD.bazel c/internal/lsp/testdata/foo/BU + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/format/BUILD.bazel c/internal/lsp/testdata/format/BUILD.bazel ---- b/internal/lsp/testdata/format/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/format/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/format/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10039,7 +10937,7 @@ diff -urN b/internal/lsp/testdata/format/BUILD.bazel c/internal/lsp/testdata/for + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/funcsig/BUILD.bazel c/internal/lsp/testdata/funcsig/BUILD.bazel ---- b/internal/lsp/testdata/funcsig/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/funcsig/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/funcsig/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10057,7 +10955,7 @@ diff -urN b/internal/lsp/testdata/funcsig/BUILD.bazel c/internal/lsp/testdata/fu + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/funcvalue/BUILD.bazel c/internal/lsp/testdata/funcvalue/BUILD.bazel ---- b/internal/lsp/testdata/funcvalue/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/funcvalue/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/funcvalue/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10075,7 +10973,7 @@ diff -urN b/internal/lsp/testdata/funcvalue/BUILD.bazel c/internal/lsp/testdata/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/fuzzymatch/BUILD.bazel c/internal/lsp/testdata/fuzzymatch/BUILD.bazel ---- b/internal/lsp/testdata/fuzzymatch/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/fuzzymatch/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/fuzzymatch/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10093,7 +10991,7 @@ diff -urN b/internal/lsp/testdata/fuzzymatch/BUILD.bazel c/internal/lsp/testdata + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/generate/BUILD.bazel c/internal/lsp/testdata/generate/BUILD.bazel ---- b/internal/lsp/testdata/generate/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/generate/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/generate/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10111,7 +11009,7 @@ diff -urN b/internal/lsp/testdata/generate/BUILD.bazel c/internal/lsp/testdata/g + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/generated/BUILD.bazel c/internal/lsp/testdata/generated/BUILD.bazel ---- b/internal/lsp/testdata/generated/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/generated/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/generated/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10132,7 +11030,7 @@ diff -urN b/internal/lsp/testdata/generated/BUILD.bazel c/internal/lsp/testdata/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/godef/a/BUILD.bazel c/internal/lsp/testdata/godef/a/BUILD.bazel ---- b/internal/lsp/testdata/godef/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/godef/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/godef/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,30 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -10166,7 +11064,7 @@ diff -urN b/internal/lsp/testdata/godef/a/BUILD.bazel c/internal/lsp/testdata/go + embed = [":a"], +) diff -urN b/internal/lsp/testdata/godef/b/BUILD.bazel c/internal/lsp/testdata/godef/b/BUILD.bazel ---- b/internal/lsp/testdata/godef/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/godef/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/godef/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,19 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10189,7 +11087,7 @@ diff -urN b/internal/lsp/testdata/godef/b/BUILD.bazel c/internal/lsp/testdata/go + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/godef/infer_generics/BUILD.bazel c/internal/lsp/testdata/godef/infer_generics/BUILD.bazel ---- b/internal/lsp/testdata/godef/infer_generics/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/godef/infer_generics/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/godef/infer_generics/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10207,7 +11105,7 @@ diff -urN b/internal/lsp/testdata/godef/infer_generics/BUILD.bazel c/internal/ls + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/good/BUILD.bazel c/internal/lsp/testdata/good/BUILD.bazel ---- b/internal/lsp/testdata/good/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/good/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/good/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10228,7 +11126,7 @@ diff -urN b/internal/lsp/testdata/good/BUILD.bazel c/internal/lsp/testdata/good/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/highlights/BUILD.bazel c/internal/lsp/testdata/highlights/BUILD.bazel ---- b/internal/lsp/testdata/highlights/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/highlights/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/highlights/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10246,7 +11144,7 @@ diff -urN b/internal/lsp/testdata/highlights/BUILD.bazel c/internal/lsp/testdata + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/implementation/BUILD.bazel c/internal/lsp/testdata/implementation/BUILD.bazel ---- b/internal/lsp/testdata/implementation/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/implementation/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/implementation/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10264,7 +11162,7 @@ diff -urN b/internal/lsp/testdata/implementation/BUILD.bazel c/internal/lsp/test + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/implementation/other/BUILD.bazel c/internal/lsp/testdata/implementation/other/BUILD.bazel ---- b/internal/lsp/testdata/implementation/other/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/implementation/other/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/implementation/other/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -10288,7 +11186,7 @@ diff -urN b/internal/lsp/testdata/implementation/other/BUILD.bazel c/internal/ls + embed = [":other"], +) diff -urN b/internal/lsp/testdata/index/BUILD.bazel c/internal/lsp/testdata/index/BUILD.bazel ---- b/internal/lsp/testdata/index/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/index/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/index/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10306,7 +11204,7 @@ diff -urN b/internal/lsp/testdata/index/BUILD.bazel c/internal/lsp/testdata/inde + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/interfacerank/BUILD.bazel c/internal/lsp/testdata/interfacerank/BUILD.bazel ---- b/internal/lsp/testdata/interfacerank/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/interfacerank/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/interfacerank/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10324,7 +11222,7 @@ diff -urN b/internal/lsp/testdata/interfacerank/BUILD.bazel c/internal/lsp/testd + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/keywords/BUILD.bazel c/internal/lsp/testdata/keywords/BUILD.bazel ---- b/internal/lsp/testdata/keywords/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/keywords/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/keywords/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10346,7 +11244,7 @@ diff -urN b/internal/lsp/testdata/keywords/BUILD.bazel c/internal/lsp/testdata/k + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/labels/BUILD.bazel c/internal/lsp/testdata/labels/BUILD.bazel ---- b/internal/lsp/testdata/labels/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/labels/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/labels/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10364,7 +11262,7 @@ diff -urN b/internal/lsp/testdata/labels/BUILD.bazel c/internal/lsp/testdata/lab + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/links/BUILD.bazel c/internal/lsp/testdata/links/BUILD.bazel ---- b/internal/lsp/testdata/links/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/links/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/links/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10382,7 +11280,7 @@ diff -urN b/internal/lsp/testdata/links/BUILD.bazel c/internal/lsp/testdata/link + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/missingfunction/BUILD.bazel c/internal/lsp/testdata/missingfunction/BUILD.bazel ---- b/internal/lsp/testdata/missingfunction/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/missingfunction/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/missingfunction/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10410,7 +11308,7 @@ diff -urN b/internal/lsp/testdata/missingfunction/BUILD.bazel c/internal/lsp/tes + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/nodisk/BUILD.bazel c/internal/lsp/testdata/nodisk/BUILD.bazel ---- b/internal/lsp/testdata/nodisk/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/nodisk/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/nodisk/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10427,8 +11325,26 @@ diff -urN b/internal/lsp/testdata/nodisk/BUILD.bazel c/internal/lsp/testdata/nod + actual = ":nodisk", + visibility = ["//:__subpackages__"], +) +diff -urN b/internal/lsp/testdata/%percent/BUILD.bazel c/internal/lsp/testdata/%percent/BUILD.bazel +--- b/internal/lsp/testdata/%percent/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/testdata/%percent/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,14 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "%percent", ++ srcs = ["perc%ent.go"], ++ importpath = "golang.org/x/tools/internal/lsp/testdata/%percent", ++ visibility = ["//:__subpackages__"], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":%percent", ++ visibility = ["//:__subpackages__"], ++) diff -urN b/internal/lsp/testdata/printf/BUILD.bazel c/internal/lsp/testdata/printf/BUILD.bazel ---- b/internal/lsp/testdata/printf/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/printf/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/printf/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10446,7 +11362,7 @@ diff -urN b/internal/lsp/testdata/printf/BUILD.bazel c/internal/lsp/testdata/pri + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/rank/BUILD.bazel c/internal/lsp/testdata/rank/BUILD.bazel ---- b/internal/lsp/testdata/rank/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/rank/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/rank/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10464,7 +11380,7 @@ diff -urN b/internal/lsp/testdata/rank/BUILD.bazel c/internal/lsp/testdata/rank/ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/rank/struct/BUILD.bazel c/internal/lsp/testdata/rank/struct/BUILD.bazel ---- b/internal/lsp/testdata/rank/struct/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/rank/struct/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/rank/struct/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10481,18 +11397,8 @@ diff -urN b/internal/lsp/testdata/rank/struct/BUILD.bazel c/internal/lsp/testdat + actual = ":struct", + visibility = ["//:__subpackages__"], +) -diff -urN b/internal/lsp/testdata/references/BUILD.bazel c/internal/lsp/testdata/references/BUILD.bazel ---- b/internal/lsp/testdata/references/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/internal/lsp/testdata/references/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,6 @@ -+load("@io_bazel_rules_go//go:def.bzl", "go_test") -+ -+go_test( -+ name = "references_test", -+ srcs = ["refs_test.go"], -+) diff -urN b/internal/lsp/testdata/references/another/BUILD.bazel c/internal/lsp/testdata/references/another/BUILD.bazel ---- b/internal/lsp/testdata/references/another/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/references/another/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/references/another/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10509,8 +11415,18 @@ diff -urN b/internal/lsp/testdata/references/another/BUILD.bazel c/internal/lsp/ + actual = ":another", + visibility = ["//:__subpackages__"], +) +diff -urN b/internal/lsp/testdata/references/BUILD.bazel c/internal/lsp/testdata/references/BUILD.bazel +--- b/internal/lsp/testdata/references/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/testdata/references/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,6 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_test") ++ ++go_test( ++ name = "references_test", ++ srcs = ["refs_test.go"], ++) diff -urN b/internal/lsp/testdata/references/interfaces/BUILD.bazel c/internal/lsp/testdata/references/interfaces/BUILD.bazel ---- b/internal/lsp/testdata/references/interfaces/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/references/interfaces/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/references/interfaces/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10528,7 +11444,7 @@ diff -urN b/internal/lsp/testdata/references/interfaces/BUILD.bazel c/internal/l + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/references/other/BUILD.bazel c/internal/lsp/testdata/references/other/BUILD.bazel ---- b/internal/lsp/testdata/references/other/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/references/other/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/references/other/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10546,7 +11462,7 @@ diff -urN b/internal/lsp/testdata/references/other/BUILD.bazel c/internal/lsp/te + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/rename/b/BUILD.bazel c/internal/lsp/testdata/rename/b/BUILD.bazel ---- b/internal/lsp/testdata/rename/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/rename/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/rename/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10564,7 +11480,7 @@ diff -urN b/internal/lsp/testdata/rename/b/BUILD.bazel c/internal/lsp/testdata/r + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/rename/c/BUILD.bazel c/internal/lsp/testdata/rename/c/BUILD.bazel ---- b/internal/lsp/testdata/rename/c/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/rename/c/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/rename/c/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10584,44 +11500,44 @@ diff -urN b/internal/lsp/testdata/rename/c/BUILD.bazel c/internal/lsp/testdata/r + actual = ":c", + visibility = ["//:__subpackages__"], +) -diff -urN b/internal/lsp/testdata/rename/crosspkg/BUILD.bazel c/internal/lsp/testdata/rename/crosspkg/BUILD.bazel ---- b/internal/lsp/testdata/rename/crosspkg/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/internal/lsp/testdata/rename/crosspkg/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +diff -urN b/internal/lsp/testdata/rename/crosspkg/another/BUILD.bazel c/internal/lsp/testdata/rename/crosspkg/another/BUILD.bazel +--- b/internal/lsp/testdata/rename/crosspkg/another/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/testdata/rename/crosspkg/another/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") + +go_library( -+ name = "crosspkg", -+ srcs = ["crosspkg.go"], -+ importpath = "golang.org/x/tools/internal/lsp/testdata/rename/crosspkg", ++ name = "another", ++ srcs = ["another.go"], ++ importpath = "golang.org/x/tools/internal/lsp/testdata/rename/crosspkg/another", + visibility = ["//:__subpackages__"], +) + +alias( + name = "go_default_library", -+ actual = ":crosspkg", ++ actual = ":another", + visibility = ["//:__subpackages__"], +) -diff -urN b/internal/lsp/testdata/rename/crosspkg/another/BUILD.bazel c/internal/lsp/testdata/rename/crosspkg/another/BUILD.bazel ---- b/internal/lsp/testdata/rename/crosspkg/another/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/internal/lsp/testdata/rename/crosspkg/another/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +diff -urN b/internal/lsp/testdata/rename/crosspkg/BUILD.bazel c/internal/lsp/testdata/rename/crosspkg/BUILD.bazel +--- b/internal/lsp/testdata/rename/crosspkg/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/testdata/rename/crosspkg/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") + +go_library( -+ name = "another", -+ srcs = ["another.go"], -+ importpath = "golang.org/x/tools/internal/lsp/testdata/rename/crosspkg/another", ++ name = "crosspkg", ++ srcs = ["crosspkg.go"], ++ importpath = "golang.org/x/tools/internal/lsp/testdata/rename/crosspkg", + visibility = ["//:__subpackages__"], +) + +alias( + name = "go_default_library", -+ actual = ":another", ++ actual = ":crosspkg", + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/rename/crosspkg/other/BUILD.bazel c/internal/lsp/testdata/rename/crosspkg/other/BUILD.bazel ---- b/internal/lsp/testdata/rename/crosspkg/other/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/rename/crosspkg/other/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/rename/crosspkg/other/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10639,7 +11555,7 @@ diff -urN b/internal/lsp/testdata/rename/crosspkg/other/BUILD.bazel c/internal/l + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/rename/issue42134/BUILD.bazel c/internal/lsp/testdata/rename/issue42134/BUILD.bazel ---- b/internal/lsp/testdata/rename/issue42134/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/rename/issue42134/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/rename/issue42134/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,19 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10662,7 +11578,7 @@ diff -urN b/internal/lsp/testdata/rename/issue42134/BUILD.bazel c/internal/lsp/t + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/rename/shadow/BUILD.bazel c/internal/lsp/testdata/rename/shadow/BUILD.bazel ---- b/internal/lsp/testdata/rename/shadow/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/rename/shadow/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/rename/shadow/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10680,7 +11596,7 @@ diff -urN b/internal/lsp/testdata/rename/shadow/BUILD.bazel c/internal/lsp/testd + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/rename/testy/BUILD.bazel c/internal/lsp/testdata/rename/testy/BUILD.bazel ---- b/internal/lsp/testdata/rename/testy/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/rename/testy/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/rename/testy/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -10704,7 +11620,7 @@ diff -urN b/internal/lsp/testdata/rename/testy/BUILD.bazel c/internal/lsp/testda + embed = [":testy"], +) diff -urN b/internal/lsp/testdata/semantic/BUILD.bazel c/internal/lsp/testdata/semantic/BUILD.bazel ---- b/internal/lsp/testdata/semantic/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/semantic/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/semantic/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,23 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -10731,7 +11647,7 @@ diff -urN b/internal/lsp/testdata/semantic/BUILD.bazel c/internal/lsp/testdata/s + embed = [":semantic"], +) diff -urN b/internal/lsp/testdata/signature/BUILD.bazel c/internal/lsp/testdata/signature/BUILD.bazel ---- b/internal/lsp/testdata/signature/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/signature/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/signature/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,19 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -10754,7 +11670,7 @@ diff -urN b/internal/lsp/testdata/signature/BUILD.bazel c/internal/lsp/testdata/ + srcs = ["signature_test.go"], +) diff -urN b/internal/lsp/testdata/snippets/BUILD.bazel c/internal/lsp/testdata/snippets/BUILD.bazel ---- b/internal/lsp/testdata/snippets/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/snippets/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/snippets/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,17 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10775,7 +11691,7 @@ diff -urN b/internal/lsp/testdata/snippets/BUILD.bazel c/internal/lsp/testdata/s + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/statements/BUILD.bazel c/internal/lsp/testdata/statements/BUILD.bazel ---- b/internal/lsp/testdata/statements/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/statements/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/statements/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -10803,7 +11719,7 @@ diff -urN b/internal/lsp/testdata/statements/BUILD.bazel c/internal/lsp/testdata + embed = [":statements"], +) diff -urN b/internal/lsp/testdata/suggestedfix/BUILD.bazel c/internal/lsp/testdata/suggestedfix/BUILD.bazel ---- b/internal/lsp/testdata/suggestedfix/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/suggestedfix/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/suggestedfix/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10821,7 +11737,7 @@ diff -urN b/internal/lsp/testdata/suggestedfix/BUILD.bazel c/internal/lsp/testda + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/symbols/BUILD.bazel c/internal/lsp/testdata/symbols/BUILD.bazel ---- b/internal/lsp/testdata/symbols/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/symbols/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/symbols/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -10839,7 +11755,7 @@ diff -urN b/internal/lsp/testdata/symbols/BUILD.bazel c/internal/lsp/testdata/sy + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/testy/BUILD.bazel c/internal/lsp/testdata/testy/BUILD.bazel ---- b/internal/lsp/testdata/testy/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/testy/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/testy/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -10863,7 +11779,7 @@ diff -urN b/internal/lsp/testdata/testy/BUILD.bazel c/internal/lsp/testdata/test + embed = [":testy"], +) diff -urN b/internal/lsp/testdata/typdef/BUILD.bazel c/internal/lsp/testdata/typdef/BUILD.bazel ---- b/internal/lsp/testdata/typdef/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/typdef/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/typdef/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10881,7 +11797,7 @@ diff -urN b/internal/lsp/testdata/typdef/BUILD.bazel c/internal/lsp/testdata/typ + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/typeassert/BUILD.bazel c/internal/lsp/testdata/typeassert/BUILD.bazel ---- b/internal/lsp/testdata/typeassert/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/typeassert/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/typeassert/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10899,7 +11815,7 @@ diff -urN b/internal/lsp/testdata/typeassert/BUILD.bazel c/internal/lsp/testdata + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/typeerrors/BUILD.bazel c/internal/lsp/testdata/typeerrors/BUILD.bazel ---- b/internal/lsp/testdata/typeerrors/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/typeerrors/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/typeerrors/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10917,7 +11833,7 @@ diff -urN b/internal/lsp/testdata/typeerrors/BUILD.bazel c/internal/lsp/testdata + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/typemods/BUILD.bazel c/internal/lsp/testdata/typemods/BUILD.bazel ---- b/internal/lsp/testdata/typemods/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/typemods/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/typemods/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10935,7 +11851,7 @@ diff -urN b/internal/lsp/testdata/typemods/BUILD.bazel c/internal/lsp/testdata/t + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/types/BUILD.bazel c/internal/lsp/testdata/types/BUILD.bazel ---- b/internal/lsp/testdata/types/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/types/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/types/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10953,7 +11869,7 @@ diff -urN b/internal/lsp/testdata/types/BUILD.bazel c/internal/lsp/testdata/type + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/undeclared/BUILD.bazel c/internal/lsp/testdata/undeclared/BUILD.bazel ---- b/internal/lsp/testdata/undeclared/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/undeclared/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/undeclared/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -10971,7 +11887,7 @@ diff -urN b/internal/lsp/testdata/undeclared/BUILD.bazel c/internal/lsp/testdata + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/unimported/BUILD.bazel c/internal/lsp/testdata/unimported/BUILD.bazel ---- b/internal/lsp/testdata/unimported/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/unimported/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/unimported/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,23 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -10998,7 +11914,7 @@ diff -urN b/internal/lsp/testdata/unimported/BUILD.bazel c/internal/lsp/testdata + embed = [":unimported"], +) diff -urN b/internal/lsp/testdata/unsafe/BUILD.bazel c/internal/lsp/testdata/unsafe/BUILD.bazel ---- b/internal/lsp/testdata/unsafe/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/unsafe/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/unsafe/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11016,7 +11932,7 @@ diff -urN b/internal/lsp/testdata/unsafe/BUILD.bazel c/internal/lsp/testdata/uns + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/testdata/variadic/BUILD.bazel c/internal/lsp/testdata/variadic/BUILD.bazel ---- b/internal/lsp/testdata/variadic/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/variadic/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/variadic/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11033,30 +11949,8 @@ diff -urN b/internal/lsp/testdata/variadic/BUILD.bazel c/internal/lsp/testdata/v + actual = ":variadic", + visibility = ["//:__subpackages__"], +) -diff -urN b/internal/lsp/testdata/workspacesymbol/BUILD.bazel c/internal/lsp/testdata/workspacesymbol/BUILD.bazel ---- b/internal/lsp/testdata/workspacesymbol/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/internal/lsp/testdata/workspacesymbol/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,18 @@ -+load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") -+ -+go_library( -+ name = "workspacesymbol_lib", -+ srcs = [ -+ "issue44806.go", -+ "main.go", -+ "query.go", -+ ], -+ importpath = "golang.org/x/tools/internal/lsp/testdata/workspacesymbol", -+ visibility = ["//visibility:private"], -+) -+ -+go_binary( -+ name = "workspacesymbol", -+ embed = [":workspacesymbol_lib"], -+ visibility = ["//:__subpackages__"], -+) diff -urN b/internal/lsp/testdata/workspacesymbol/a/BUILD.bazel c/internal/lsp/testdata/workspacesymbol/a/BUILD.bazel ---- b/internal/lsp/testdata/workspacesymbol/a/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/workspacesymbol/a/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/workspacesymbol/a/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,23 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -11083,7 +11977,7 @@ diff -urN b/internal/lsp/testdata/workspacesymbol/a/BUILD.bazel c/internal/lsp/t + embed = [":a"], +) diff -urN b/internal/lsp/testdata/workspacesymbol/b/BUILD.bazel c/internal/lsp/testdata/workspacesymbol/b/BUILD.bazel ---- b/internal/lsp/testdata/workspacesymbol/b/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/workspacesymbol/b/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/workspacesymbol/b/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11100,8 +11994,30 @@ diff -urN b/internal/lsp/testdata/workspacesymbol/b/BUILD.bazel c/internal/lsp/t + actual = ":b", + visibility = ["//:__subpackages__"], +) +diff -urN b/internal/lsp/testdata/workspacesymbol/BUILD.bazel c/internal/lsp/testdata/workspacesymbol/BUILD.bazel +--- b/internal/lsp/testdata/workspacesymbol/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/lsp/testdata/workspacesymbol/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,18 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") ++ ++go_library( ++ name = "workspacesymbol_lib", ++ srcs = [ ++ "issue44806.go", ++ "main.go", ++ "query.go", ++ ], ++ importpath = "golang.org/x/tools/internal/lsp/testdata/workspacesymbol", ++ visibility = ["//visibility:private"], ++) ++ ++go_binary( ++ name = "workspacesymbol", ++ embed = [":workspacesymbol_lib"], ++ visibility = ["//:__subpackages__"], ++) diff -urN b/internal/lsp/testdata/workspacesymbol/p/BUILD.bazel c/internal/lsp/testdata/workspacesymbol/p/BUILD.bazel ---- b/internal/lsp/testdata/workspacesymbol/p/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/testdata/workspacesymbol/p/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/testdata/workspacesymbol/p/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11119,7 +12035,7 @@ diff -urN b/internal/lsp/testdata/workspacesymbol/p/BUILD.bazel c/internal/lsp/t + visibility = ["//:__subpackages__"], +) diff -urN b/internal/lsp/tests/BUILD.bazel c/internal/lsp/tests/BUILD.bazel ---- b/internal/lsp/tests/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/lsp/tests/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/lsp/tests/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,33 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11156,7 +12072,7 @@ diff -urN b/internal/lsp/tests/BUILD.bazel c/internal/lsp/tests/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/internal/memoize/BUILD.bazel c/internal/memoize/BUILD.bazel ---- b/internal/memoize/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/memoize/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/memoize/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,21 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -11181,7 +12097,7 @@ diff -urN b/internal/memoize/BUILD.bazel c/internal/memoize/BUILD.bazel + deps = [":memoize"], +) diff -urN b/internal/mod/lazyregexp/BUILD.bazel c/internal/mod/lazyregexp/BUILD.bazel ---- b/internal/mod/lazyregexp/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/mod/lazyregexp/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/mod/lazyregexp/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11199,7 +12115,7 @@ diff -urN b/internal/mod/lazyregexp/BUILD.bazel c/internal/mod/lazyregexp/BUILD. + visibility = ["//:__subpackages__"], +) diff -urN b/internal/mod/modfile/BUILD.bazel c/internal/mod/modfile/BUILD.bazel ---- b/internal/mod/modfile/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/mod/modfile/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/mod/modfile/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,22 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11225,7 +12141,7 @@ diff -urN b/internal/mod/modfile/BUILD.bazel c/internal/mod/modfile/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/internal/packagesinternal/BUILD.bazel c/internal/packagesinternal/BUILD.bazel ---- b/internal/packagesinternal/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/packagesinternal/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/packagesinternal/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11244,7 +12160,7 @@ diff -urN b/internal/packagesinternal/BUILD.bazel c/internal/packagesinternal/BU + visibility = ["//:__subpackages__"], +) diff -urN b/internal/proxydir/BUILD.bazel c/internal/proxydir/BUILD.bazel ---- b/internal/proxydir/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/proxydir/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/proxydir/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,21 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -11269,7 +12185,7 @@ diff -urN b/internal/proxydir/BUILD.bazel c/internal/proxydir/BUILD.bazel + embed = [":proxydir"], +) diff -urN b/internal/span/BUILD.bazel c/internal/span/BUILD.bazel ---- b/internal/span/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/span/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/span/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,34 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -11307,7 +12223,7 @@ diff -urN b/internal/span/BUILD.bazel c/internal/span/BUILD.bazel + deps = [":span"], +) diff -urN b/internal/stack/BUILD.bazel c/internal/stack/BUILD.bazel ---- b/internal/stack/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/stack/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/stack/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,24 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -11335,7 +12251,7 @@ diff -urN b/internal/stack/BUILD.bazel c/internal/stack/BUILD.bazel + deps = [":stack"], +) diff -urN b/internal/stack/gostacks/BUILD.bazel c/internal/stack/gostacks/BUILD.bazel ---- b/internal/stack/gostacks/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/stack/gostacks/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/stack/gostacks/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") @@ -11354,7 +12270,7 @@ diff -urN b/internal/stack/gostacks/BUILD.bazel c/internal/stack/gostacks/BUILD. + visibility = ["//:__subpackages__"], +) diff -urN b/internal/stack/stacktest/BUILD.bazel c/internal/stack/stacktest/BUILD.bazel ---- b/internal/stack/stacktest/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/stack/stacktest/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/stack/stacktest/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,15 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11373,7 +12289,7 @@ diff -urN b/internal/stack/stacktest/BUILD.bazel c/internal/stack/stacktest/BUIL + visibility = ["//:__subpackages__"], +) diff -urN b/internal/testenv/BUILD.bazel c/internal/testenv/BUILD.bazel ---- b/internal/testenv/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/testenv/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/testenv/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11395,7 +12311,7 @@ diff -urN b/internal/testenv/BUILD.bazel c/internal/testenv/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/internal/tool/BUILD.bazel c/internal/tool/BUILD.bazel ---- b/internal/tool/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/tool/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/tool/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11413,9 +12329,9 @@ diff -urN b/internal/tool/BUILD.bazel c/internal/tool/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/internal/typeparams/BUILD.bazel c/internal/typeparams/BUILD.bazel ---- b/internal/typeparams/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/typeparams/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/typeparams/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -0,0 +1,24 @@ +@@ -0,0 +1,37 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") + +go_library( @@ -11423,7 +12339,12 @@ diff -urN b/internal/typeparams/BUILD.bazel c/internal/typeparams/BUILD.bazel + srcs = [ + "common.go", + "enabled_go117.go", ++ "enabled_go118.go", ++ "normalize.go", ++ "termlist.go", + "typeparams_go117.go", ++ "typeparams_go118.go", ++ "typeterm.go", + ], + importpath = "golang.org/x/tools/internal/typeparams", + visibility = ["//:__subpackages__"], @@ -11437,11 +12358,41 @@ diff -urN b/internal/typeparams/BUILD.bazel c/internal/typeparams/BUILD.bazel + +go_test( + name = "typeparams_test", -+ srcs = ["common_test.go"], -+ deps = [":typeparams"], ++ srcs = [ ++ "common_test.go", ++ "normalize_test.go", ++ "typeparams_test.go", ++ ], ++ deps = [ ++ ":typeparams", ++ "//internal/apidiff", ++ "//internal/testenv", ++ ], ++) +diff -urN b/internal/typeparams/genericfeatures/BUILD.bazel c/internal/typeparams/genericfeatures/BUILD.bazel +--- b/internal/typeparams/genericfeatures/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 ++++ c/internal/typeparams/genericfeatures/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 +@@ -0,0 +1,18 @@ ++load("@io_bazel_rules_go//go:def.bzl", "go_library") ++ ++go_library( ++ name = "genericfeatures", ++ srcs = ["features.go"], ++ importpath = "golang.org/x/tools/internal/typeparams/genericfeatures", ++ visibility = ["//:__subpackages__"], ++ deps = [ ++ "//go/ast/inspector", ++ "//internal/typeparams", ++ ], ++) ++ ++alias( ++ name = "go_default_library", ++ actual = ":genericfeatures", ++ visibility = ["//:__subpackages__"], +) diff -urN b/internal/typesinternal/BUILD.bazel c/internal/typesinternal/BUILD.bazel ---- b/internal/typesinternal/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/typesinternal/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/typesinternal/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11463,7 +12414,7 @@ diff -urN b/internal/typesinternal/BUILD.bazel c/internal/typesinternal/BUILD.ba + visibility = ["//:__subpackages__"], +) diff -urN b/internal/xcontext/BUILD.bazel c/internal/xcontext/BUILD.bazel ---- b/internal/xcontext/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/internal/xcontext/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/internal/xcontext/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11481,7 +12432,7 @@ diff -urN b/internal/xcontext/BUILD.bazel c/internal/xcontext/BUILD.bazel + visibility = ["//:__subpackages__"], +) diff -urN b/playground/BUILD.bazel c/playground/BUILD.bazel ---- b/playground/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/playground/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/playground/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,14 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11499,7 +12450,7 @@ diff -urN b/playground/BUILD.bazel c/playground/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/playground/socket/BUILD.bazel c/playground/socket/BUILD.bazel ---- b/playground/socket/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/playground/socket/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/playground/socket/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,25 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -11528,7 +12479,7 @@ diff -urN b/playground/socket/BUILD.bazel c/playground/socket/BUILD.bazel + embed = [":socket"], +) diff -urN b/present/BUILD.bazel c/present/BUILD.bazel ---- b/present/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/present/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/present/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,44 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -11576,7 +12527,7 @@ diff -urN b/present/BUILD.bazel c/present/BUILD.bazel + embed = [":present"], +) diff -urN b/refactor/eg/BUILD.bazel c/refactor/eg/BUILD.bazel ---- b/refactor/eg/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/refactor/eg/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/refactor/eg/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,93 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -11673,7 +12624,7 @@ diff -urN b/refactor/eg/BUILD.bazel c/refactor/eg/BUILD.bazel + }), +) diff -urN b/refactor/importgraph/BUILD.bazel c/refactor/importgraph/BUILD.bazel ---- b/refactor/importgraph/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/refactor/importgraph/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/refactor/importgraph/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,75 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -11752,7 +12703,7 @@ diff -urN b/refactor/importgraph/BUILD.bazel c/refactor/importgraph/BUILD.bazel + }), +) diff -urN b/refactor/rename/BUILD.bazel c/refactor/rename/BUILD.bazel ---- b/refactor/rename/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/refactor/rename/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/refactor/rename/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,42 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") @@ -11798,7 +12749,7 @@ diff -urN b/refactor/rename/BUILD.bazel c/refactor/rename/BUILD.bazel + ], +) diff -urN b/refactor/satisfy/BUILD.bazel c/refactor/satisfy/BUILD.bazel ---- b/refactor/satisfy/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/refactor/satisfy/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/refactor/satisfy/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,18 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library") @@ -11820,7 +12771,7 @@ diff -urN b/refactor/satisfy/BUILD.bazel c/refactor/satisfy/BUILD.bazel + visibility = ["//visibility:public"], +) diff -urN b/txtar/BUILD.bazel c/txtar/BUILD.bazel ---- b/txtar/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 +--- b/txtar/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100 +++ c/txtar/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 @@ -0,0 +1,20 @@ +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") diff --git a/third_party/org_golang_x_tools-public-visibility.patch b/third_party/org_golang_x_tools-public-visibility.patch deleted file mode 100644 index 22ff46c4e8..0000000000 --- a/third_party/org_golang_x_tools-public-visibility.patch +++ /dev/null @@ -1,21 +0,0 @@ -diff -urN b/go/analysis/internal/facts/BUILD.bazel c/go/analysis/internal/facts/BUILD.bazel ---- b/go/analysis/internal/facts/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800 -+++ c/go/analysis/internal/facts/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000 -@@ -7,7 +7,7 @@ - "imports.go", - ], - importpath = "golang.org/x/tools/go/analysis/internal/facts", -- visibility = ["//go/analysis:__subpackages__"], -+ visibility = ["//visibility:public"], - deps = [ - "//go/analysis", - "//go/types/objectpath", -@@ -17,7 +17,7 @@ - alias( - name = "go_default_library", - actual = ":facts", -- visibility = ["//go/analysis:__subpackages__"], -+ visibility = ["//visibility:public"], - ) - - go_test(