From 22e9f75748c94e6d79dd5c2eb451858b98793979 Mon Sep 17 00:00:00 2001 From: Matias Perez Date: Tue, 9 Jan 2024 15:45:01 -0300 Subject: [PATCH 1/2] bugfix and some ui corrections --- .../src/components/debugger/visualizer/index.tsx | 5 +++++ .../components/debugger/visualizer/visualizer.module.scss | 7 ++++++- scrollytelling/src/util/emmiter.ts | 6 +++++- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/scrollytelling/src/components/debugger/visualizer/index.tsx b/scrollytelling/src/components/debugger/visualizer/index.tsx index 9e6ef9c..9f225f6 100644 --- a/scrollytelling/src/components/debugger/visualizer/index.tsx +++ b/scrollytelling/src/components/debugger/visualizer/index.tsx @@ -470,6 +470,11 @@ export const Visualizer = () => { }); }, []); + useEffect(() => { + // Force refresh on mount + internalEventEmmiter.emit("timeline:refresh"); + }, []); + if (dismiss) return <>; return ( diff --git a/scrollytelling/src/components/debugger/visualizer/visualizer.module.scss b/scrollytelling/src/components/debugger/visualizer/visualizer.module.scss index 59cf989..fa48e9d 100644 --- a/scrollytelling/src/components/debugger/visualizer/visualizer.module.scss +++ b/scrollytelling/src/components/debugger/visualizer/visualizer.module.scss @@ -57,7 +57,11 @@ align-items: center; .button { - padding: 4px; + color: var(--color-white); + display: flex; + align-items: center; + height: 24px; + padding: 0px 4px; border-radius: 4px; background: var(--color-gray); border: 1px solid var(--color-gray-light); @@ -305,6 +309,7 @@ appearance: none; cursor: pointer; background: var(--color-gray); + color: var(--color-white); border: 1px solid var(--color-gray-light); height: 24px; border-radius: 4px; diff --git a/scrollytelling/src/util/emmiter.ts b/scrollytelling/src/util/emmiter.ts index 10219d5..9d91c2a 100644 --- a/scrollytelling/src/util/emmiter.ts +++ b/scrollytelling/src/util/emmiter.ts @@ -20,10 +20,14 @@ export class Emitter { // Return an unsubscribe function return () => { - this.events[event] = this.events[event]?.filter((i) => cb !== i) ?? []; + this.off(event, cb); }; } + off(event: string, cb: Callback) { + this.events[event] = this.events[event]?.filter((i) => cb !== i) ?? []; + } + destroy() { this.events = {}; } From fd8a06672decc7c707646407deb4a6bb3324388f Mon Sep 17 00:00:00 2001 From: Julian Benegas Date: Tue, 9 Jan 2024 17:38:25 -0300 Subject: [PATCH 2/2] Create tender-items-grin.md --- .changeset/tender-items-grin.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tender-items-grin.md diff --git a/.changeset/tender-items-grin.md b/.changeset/tender-items-grin.md new file mode 100644 index 0000000..01e383f --- /dev/null +++ b/.changeset/tender-items-grin.md @@ -0,0 +1,5 @@ +--- +"@bsmnt/scrollytelling": patch +--- + +Visualizer bugfixing & UI corrections