-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dotenv 3.1.5 breaks kamal deploy #1294
Comments
An issue is already open in dotenv repo bkeepers/dotenv#518 |
How did you fix, this completely broke my entire CI/CD workflow |
Install dotenv pinned to the previous version before Kamal
|
@marciotoshio thanks for pointing this out! I have been debugging my Github Action the whole morning and finally came to the conclusion something in Kamal or it's dependencies was broken. Will lock dotenv for now. |
The issue is because https://github.com/bkeepers/dotenv/blob/962641232d379472af77908dfed3f2f0a5c234dc/lib/dotenv/parser.rb#L56 is executed for environment variables that are already set. Seems like Kamal is using it incorrectly somehow as it expected that to be replaced. |
@djmb thank you! |
Big +1, thank you |
Maybe not a kamal problem but I'd like to let people aware, my latest deploys were broken and seems like the culprit is the new version of dotenv.
I installed the previous gem version
3.1.4
before installing kamal in the CIThe text was updated successfully, but these errors were encountered: