Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate functools.walk() #1422

Closed
bartfeenstra opened this issue Apr 27, 2024 · 0 comments · Fixed by #1459
Closed

Deprecate functools.walk() #1422

bartfeenstra opened this issue Apr 27, 2024 · 0 comments · Fixed by #1459
Labels
enhancement New feature or request python Pull requests that update Python code
Milestone
0.3.x

Comments

@bartfeenstra
Copy link
Owner

bartfeenstra commented Apr 27, 2024 •
edited
Loading

functools.walk() is hard to define and not specific enough. If similar functionality is still needed, provide it in the form of traversing a single attribute of a single expected type. Do not mix plain attribute and iterator access.

Proposals

  • add Person.ancestors and Person.descendants?
@bartfeenstra bartfeenstra added enhancement New feature or request python Pull requests that update Python code labels Apr 27, 2024
@bartfeenstra bartfeenstra added this to the 0.3.x milestone Apr 27, 2024
@bartfeenstra bartfeenstra mentioned this issue May 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
0.3.x
Development

Successfully merging a pull request may close this issue.

Deprecate betty.functools.walk() bartfeenstra/betty
1 participant
@bartfeenstra