Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subroutine qad #13

Open
piyueh opened this issue Dec 5, 2018 · 1 comment
Open

Subroutine qad #13

piyueh opened this issue Dec 5, 2018 · 1 comment
Labels
question Further information is requested

Comments

@piyueh
Copy link
Member

piyueh commented Dec 5, 2018

It seems the subroutine qad (in src/2d/shallow/qad.f) is doing something I don't understand. The comment shows some remarks like need to fix someday from upstream GeoClaw code. I doubt this has something to do with that, in coarse grids, the fluid will penetrate the hydro regions by two cells. The expected behavior is only penetrating one cell. Though for the fine grids, they are not affected.
@piyueh piyueh added the question Further information is requested label Dec 5, 2018
@mandli
Copy link
Collaborator

mandli commented Dec 6, 2018

That routine is a conservative fix-up around the boundaries of a grid patch as described in [1]. The "need to fix someday" was fixed (hence the commented out return statement) but the source terms are not evaluated as there isn't an idea of what the right thing to do is there.

  1. Berger, M. J. & LeVeque, R. J. Adaptive Mesh Refinement Using Wave-Propagation Algorithms for Hyperbolic Systems. 35, 2298–2316 (1998).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mandli @piyueh