Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve teams colour code and re-enble dark mode #5

Closed
bapairaew opened this issue Jul 19, 2021 · 0 comments
Closed

Improve teams colour code and re-enble dark mode #5

bapairaew opened this issue Jul 19, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@bapairaew
Copy link
Owner

Some teams have to the same colour codes (e.g. MUN and LIV) which makes it harder for user to distinguish them at a glance. The colour codes are current extracted from https://teamcolorcodes.com/soccer/premier-league-color-codes/ which is introduced this issue and moreover the data is. already outdated.

Might be better to just hard code these values base on their current year kit colour since they are changed only once a year.


Also somewhat related issue: dark mode was disabled because FPL colour codes and team colour codes worked quite baldly with base Chakra UI dark theme. Since FPL colour codes should be simple to adjust so once team colour is fixed this should be very trivial to fix. If not, create another issue to enable the dark mode.

@bapairaew bapairaew added the enhancement New feature or request label Jul 19, 2021
@bapairaew bapairaew self-assigned this Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant