You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Substantial work has been made on this already compared to where it was, but the script still has a few points where sleeping is used. Waiting for the page to load with a real time sleep is bad for at least two big reasons on each end of the spectrum:
Wait too long and the script is slower without needing to be.
Wait too little and the page will not have loaded, probably crashing the script.
The better approach would be to keep trying to find the appropriate element with a small delay in between each attempt, catching the exception when it hasn't yet loaded. There is a decorator in util for this already, but it doesn't play with generators very nice. The success condition is also quite strange, expecting each function to return None on failure.
Breaking all of the navigation functions into smaller pieces would likely still be good for this.
The text was updated successfully, but these errors were encountered:
Substantial work has been made on this already compared to where it was, but the script still has a few points where sleeping is used. Waiting for the page to load with a real time sleep is bad for at least two big reasons on each end of the spectrum:
The better approach would be to keep trying to find the appropriate element with a small delay in between each attempt, catching the exception when it hasn't yet loaded. There is a decorator in
util
for this already, but it doesn't play with generators very nice. The success condition is also quite strange, expecting each function to returnNone
on failure.Breaking all of the navigation functions into smaller pieces would likely still be good for this.
The text was updated successfully, but these errors were encountered: