-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't find subject list with IDs turned off #11
Comments
Of the above, I think 3 is the most promising. On my LMS (staff and student) I can be reliably reach this tab via the direct link:
(c.f. home page link which is the same but has |
Also, I would just like to say the control structures in use in this 'find the subject links' section of the code are labyrinthine. I'm looking forward to a much neater solution after a rewrite! |
I agree, option 3 seems the best. Even if the subjects page would generally be less subject to change than the home page, I do agree that the student should still have the option to hide the IDs regardless. The logic is definitely more complex than it should be. |
During the semester for aesthetic purposes I leave 'Subject id' display turned off in my LMS homepage subject list. Here's what it looks like:
With this setting, the script was not finding my list of subjects. Understandably! The getSubjectList function assumes all subject names will be formatted as if the setting is on, as shown here:
To support both modes will require a way to find the links without the IDs there, or a completely alternative approach. I have a few thoughts, will post below.
The text was updated successfully, but these errors were encountered: