diff --git a/api/secrets-manager-api/src/test/java/co/com/bancolombia/secretsmanager/api/exceptionsTest.java b/api/secrets-manager-api/src/test/java/co/com/bancolombia/secretsmanager/api/ExceptionsTest.java similarity index 86% rename from api/secrets-manager-api/src/test/java/co/com/bancolombia/secretsmanager/api/exceptionsTest.java rename to api/secrets-manager-api/src/test/java/co/com/bancolombia/secretsmanager/api/ExceptionsTest.java index be7c012..019d40c 100644 --- a/api/secrets-manager-api/src/test/java/co/com/bancolombia/secretsmanager/api/exceptionsTest.java +++ b/api/secrets-manager-api/src/test/java/co/com/bancolombia/secretsmanager/api/ExceptionsTest.java @@ -5,10 +5,10 @@ import static org.junit.jupiter.api.Assertions.assertEquals; -class exceptionsTest { +class ExceptionsTest { @Test - void generateExpetion() { + void generateException() { SecretException ex = new SecretException("My error"); assertEquals("My error", ex.getMessage()); } diff --git a/async/aws-parameter-store-manager-async/src/main/java/co/com/bancolombia/secretsmanager/connector/AWSParameterStoreConnectorAsync.java b/async/aws-parameter-store-manager-async/src/main/java/co/com/bancolombia/secretsmanager/connector/AWSParameterStoreConnectorAsync.java index a0abf5a..2108ec7 100644 --- a/async/aws-parameter-store-manager-async/src/main/java/co/com/bancolombia/secretsmanager/connector/AWSParameterStoreConnectorAsync.java +++ b/async/aws-parameter-store-manager-async/src/main/java/co/com/bancolombia/secretsmanager/connector/AWSParameterStoreConnectorAsync.java @@ -57,9 +57,7 @@ private Mono getSecretValue(String secretName) { } return Mono.error(new SecretException("Secret value is not a String")); }) - .doOnError((err) -> { - logger.warning("Error retrieving the secret: " + err.getMessage()); - }); + .doOnError(err -> logger.warning("Error retrieving the secret: " + err.getMessage())); } private SsmAsyncClient buildClient(SsmAsyncClientBuilder builder) { diff --git a/async/aws-secrets-manager-async/src/main/java/co/com/bancolombia/secretsmanager/connector/AWSSecretManagerConnectorAsync.java b/async/aws-secrets-manager-async/src/main/java/co/com/bancolombia/secretsmanager/connector/AWSSecretManagerConnectorAsync.java index f3007f8..5d5ba35 100644 --- a/async/aws-secrets-manager-async/src/main/java/co/com/bancolombia/secretsmanager/connector/AWSSecretManagerConnectorAsync.java +++ b/async/aws-secrets-manager-async/src/main/java/co/com/bancolombia/secretsmanager/connector/AWSSecretManagerConnectorAsync.java @@ -50,7 +50,7 @@ public Mono getSecret(String secretName) { public Mono getSecret(String secretName, Class cls) { return this.getSecret(secretName) .flatMap((data -> Mono.just(GsonUtils.getInstance().stringToModel(data, cls)))) - .onErrorMap((e) -> new SecretException(e.getMessage())); + .onErrorMap(e -> new SecretException(e.getMessage())); } @@ -67,9 +67,7 @@ private Mono getSecretValue(String secretName) { } return Mono.error(new SecretException("Secret value is not a String")); }) - .doOnError((err) -> { - logger.warning("Error retrieving the secret: " + err.getMessage()); - }); + .doOnError(err -> logger.warning("Error retrieving the secret: " + err.getMessage())); } /** diff --git a/sync/aws-parameter-store-manager-sync/src/test/java/co/com/bancolombia/secretsmanager/connector/AWSParameterStoreConnectorTest.java b/sync/aws-parameter-store-manager-sync/src/test/java/co/com/bancolombia/secretsmanager/connector/AWSParameterStoreConnectorTest.java index b002842..e5ceb97 100644 --- a/sync/aws-parameter-store-manager-sync/src/test/java/co/com/bancolombia/secretsmanager/connector/AWSParameterStoreConnectorTest.java +++ b/sync/aws-parameter-store-manager-sync/src/test/java/co/com/bancolombia/secretsmanager/connector/AWSParameterStoreConnectorTest.java @@ -31,7 +31,7 @@ void shouldGetStringSecretWithEndpoint() throws SecretException { prepareClient("secretValue", true); connector = new AWSParameterStoreConnector("us-east-1", "http://localhost:8080"); String secretValue = connector.getSecret("secretName"); - assertEquals(secretValue, "secretValue"); + assertEquals("secretValue", secretValue); } @Test diff --git a/sync/aws-secrets-manager-sync/src/test/java/co/com/bancolombia/secretsmanager/connector/AWSSecretManagerConnectorTest.java b/sync/aws-secrets-manager-sync/src/test/java/co/com/bancolombia/secretsmanager/connector/AWSSecretManagerConnectorTest.java index a18dc09..95ce3d5 100644 --- a/sync/aws-secrets-manager-sync/src/test/java/co/com/bancolombia/secretsmanager/connector/AWSSecretManagerConnectorTest.java +++ b/sync/aws-secrets-manager-sync/src/test/java/co/com/bancolombia/secretsmanager/connector/AWSSecretManagerConnectorTest.java @@ -53,7 +53,7 @@ void shouldConversionOk() throws SecretException { } @Test - void shouldConversionFail() throws Exception { + void shouldConversionFail() { prepareClient("test", true); connector = new AWSSecretManagerConnector("us-east-1", builder); assertThrows(SecretException.class, () -> connector.getSecret("SecretDBFailMock", AWSSecretDBModel.class)); diff --git a/sync/file-secrets-manager/src/main/java/co/com/bancolombia/secretsmanager/connector/FileConnector.java b/sync/file-secrets-manager/src/main/java/co/com/bancolombia/secretsmanager/connector/FileConnector.java index 1eadbc2..4c396ad 100644 --- a/sync/file-secrets-manager/src/main/java/co/com/bancolombia/secretsmanager/connector/FileConnector.java +++ b/sync/file-secrets-manager/src/main/java/co/com/bancolombia/secretsmanager/connector/FileConnector.java @@ -2,6 +2,7 @@ import co.com.bancolombia.secretsmanager.api.GenericManager; import co.com.bancolombia.secretsmanager.api.exceptions.SecretException; +import lombok.Getter; import java.nio.charset.StandardCharsets; import java.nio.file.Files; @@ -12,10 +13,11 @@ * * @author Andrés Mauricio Gómez P. */ +@Getter public class FileConnector implements GenericManager { - public static final String PATH_DOCKER_LINUX = "/run/secrets/"; - public static final String PATH_DOCKER_WINDOWS = "C:\\ProgramData\\Docker\\secrets"; + public static final String PATH_DOCKER_LINUX = "/run/secrets/"; // NOSONAR + public static final String PATH_DOCKER_WINDOWS = "C:\\ProgramData\\Docker\\secrets"; // NOSONAR private String path; @@ -23,10 +25,6 @@ public FileConnector(String path) { setPath(path); } - public String getPath() { - return path; - } - /** * It sets path of secrets directory. * diff --git a/sync/vault-commons/src/main/java/co/com/bancolombia/secretsmanager/vault/config/VaultSecretsManagerProperties.java b/sync/vault-commons/src/main/java/co/com/bancolombia/secretsmanager/vault/config/VaultSecretsManagerProperties.java index bdab1eb..c265883 100644 --- a/sync/vault-commons/src/main/java/co/com/bancolombia/secretsmanager/vault/config/VaultSecretsManagerProperties.java +++ b/sync/vault-commons/src/main/java/co/com/bancolombia/secretsmanager/vault/config/VaultSecretsManagerProperties.java @@ -52,10 +52,10 @@ public class VaultSecretsManagerProperties { private CacheProperties secretsCacheProperties= CacheProperties.builder().expireAfter(600).maxSize(100).build(); @Builder.Default - private String appRoleAuthPath = "/auth/approle/login"; + private String appRoleAuthPath = "/auth/approle/login"; // NOSONAR @Builder.Default - private String k8sAuthPath = "/auth/kubernetes/login"; + private String k8sAuthPath = "/auth/kubernetes/login"; // NOSONAR public String buildUrl() { return String.format("%s://%s:%d%s", ssl ? "https" : "http", host, port, baseApi);