Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model.prior_predictive() does not check if the model was built #595

Closed
tomicapretto opened this issue Nov 25, 2022 · 0 comments · Fixed by #605
Closed

Model.prior_predictive() does not check if the model was built #595

tomicapretto opened this issue Nov 25, 2022 · 0 comments · Fixed by #605

Comments

@tomicapretto
Copy link
Collaborator

If you build the model using a certain set of priors, and then update the priors, Model.prior_predictive() will work with the first set of priors, ignoring the updated version. This is because the underlying PyMC model still keeps the original priors. I think prior_predictive() should check whether Model.built is True as it happens with Model.plot_priors().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant