Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly builds #1101

Open
manuranga opened this issue Oct 21, 2022 · 2 comments
Open

Fix nightly builds #1101

manuranga opened this issue Oct 21, 2022 · 2 comments
Assignees

Comments

@manuranga
Copy link
Contributor

Screenshot 2022-10-21 at 1 23 08 PM

@manuranga manuranga self-assigned this Oct 21, 2022
@manuranga manuranga changed the title xtv Fix nightly builds Oct 21, 2022
@manuranga
Copy link
Contributor Author

Looks like ballerina-distribution/daily-build-2201.0.x.yml is deleted and ballerina-distribution/daily-build-2201.1.x.yml has been failing for a month. So no point of having these at our end.

@keizer619 Please provide us a list of ballerina-distribution workflows to rely on.

In absence of the correct versions, these two builds are currently running on some random build form dist, which happens to be ballerina-2201.2.2-SNAPSHOT-swan-lake-linux-x64, with following error.

[fail] typeTests#'int.typetest#6':

something impossible happened (unreached in semTypeFromSexpr for sexpr:["!",["int",[8,8]]])

	at wso2.nballerina.comm.err.0:impossible(err.bal:37)
	wso2.nballerina.types.sexpr.0:semTypeFromSexpr(convert.bal:64)
	wso2.nballerina.types.sexpr.0:semTypeFromSexpr(convert.bal:39)
	wso2.nballerina.types.sexpr$test.0.tests.typeTest:typeTests(tests/typeTest.bal:51)

Sent a PR for this #1102.

Attempting to reproduce this error locally, I tested with a ballerina-2201.2.2-SNAPSHOT-swan-lake but it is giving me a different (more severe) error.

ballerina-platform/ballerina-lang#38339

I couldn't test the PR locally due to above, when I tried to test it in GitHub actions, it gave yet another error:
ERROR [tests/exprBinaryDiv.bal:(29:55,29:74)] '9223372036854775808' is out of range for 'int'

@manuranga
Copy link
Contributor Author

Had a chat with @keizer619 We decided test nBallerina during daily full build of jBallerina. Please add following steps to the build

git clone --depth=1 git@github.com:ballerina-platform/nballerina.git
(cd nballerina/compiler && path/to/newly/created/bal test)

I will send a PR to remove Validate on jBallerina 2201.0.x nightly Validate on jBallerina 2201.1.x nightly.

I am still planing to keep Validate on jBallerina nightly as a final check, but with this approach it should never fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants