Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate context.add function #2476

Closed
ThisaruGuruge opened this issue Dec 9, 2021 · 0 comments · Fixed by ballerina-platform/module-ballerina-graphql#515
Closed

Deprecate context.add function #2476

ThisaruGuruge opened this issue Dec 9, 2021 · 0 comments · Fixed by ballerina-platform/module-ballerina-graphql#515
Assignees
Labels
module/graphql Issues related to Ballerina GraphQL module Points/0.5 Team/PCM Protocol connector packages related issues Type/Improvement

Comments

@ThisaruGuruge
Copy link
Member

Description:
In the graphql:Context object, there is an add function to add attributes to the context. But as per the convention, (similar to http package), the function name should be set instead of add.

Since this change will be a breaking change, the add function have to be deprecated and the set function should be introduced. In a later release, the add function can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/graphql Issues related to Ballerina GraphQL module Points/0.5 Team/PCM Protocol connector packages related issues Type/Improvement
Projects
None yet
1 participant