From e451cacded06b4152ddc34048c675fa8f2ffdf59 Mon Sep 17 00:00:00 2001
From: myarmolinsky <yarmolinskymatthew@gmail.com>
Date: Tue, 22 Oct 2024 12:44:23 -0400
Subject: [PATCH] DownloadImageDialog: Update Version dropdown styling to match
 the UI's

Change-type: patch
---
 .../DownloadImageDialog/ImageForm.tsx         | 114 ++++++++++--------
 1 file changed, 64 insertions(+), 50 deletions(-)

diff --git a/src/components/DownloadImageDialog/ImageForm.tsx b/src/components/DownloadImageDialog/ImageForm.tsx
index fa570e4..7e893ea 100644
--- a/src/components/DownloadImageDialog/ImageForm.tsx
+++ b/src/components/DownloadImageDialog/ImageForm.tsx
@@ -20,6 +20,8 @@ import {
 	Typography,
 	IconButton,
 	Autocomplete,
+	useTheme,
+	Stack,
 } from '@mui/material';
 import HelpIcon from '@mui/icons-material/Help';
 import { memo, useCallback, useEffect, useMemo, useState } from 'react';
@@ -40,6 +42,9 @@ import { DeviceType, Dictionary, OsVersionsByDeviceType } from './models';
 import { Visibility, VisibilityOff } from '@mui/icons-material';
 import { FALLBACK_LOGO_UNKNOWN_DEVICE } from './utils';
 import { ChipProps } from '../Chip';
+import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
+import { faTriangleExclamation } from '@fortawesome/free-solid-svg-icons';
+import { Callout } from '../Callout';
 
 const POLL_INTERVAL_DOCS =
 	'https://www.balena.io/docs/reference/supervisor/bandwidth-reduction/#side-effects--warnings';
@@ -108,6 +113,8 @@ export const ImageForm: React.FC<ImageFormProps> = memo(
 		onSelectedDeviceTypeChange,
 		onChange,
 	}) => {
+		const theme = useTheme();
+
 		const [showAdvancedSettings, setShowAdvancedSettings] = useState(false);
 		const [showPassword, setShowPassword] = useState(false);
 		const [version, setVersion] = useState<
@@ -199,6 +206,12 @@ export const ImageForm: React.FC<ImageFormProps> = memo(
 			}
 		}, [version, variant, onChange, versionSelectionOpts]);
 
+		const selectedOSVersion = useMemo(
+			() =>
+				versionSelectionOpts.find((version) => version.value === model.version),
+			[model.version, versionSelectionOpts],
+		);
+
 		return (
 			<Box
 				action={downloadUrl}
@@ -300,33 +313,41 @@ export const ImageForm: React.FC<ImageFormProps> = memo(
 							>
 								Select version
 							</InputLabel>
-							<Select
+							<Autocomplete
 								fullWidth
 								id="e2e-download-image-versions-list"
-								value={model.version}
-								inputProps={{
-									name: 'version',
-								}}
-								onChange={(event) => {
-									const version = versionSelectionOpts.find(
-										(v) => v.value === event.target.value,
-									);
+								value={selectedOSVersion}
+								getOptionLabel={(option) => option.value}
+								options={versionSelectionOpts}
+								onChange={(_event, version) => {
 									setVersion(version);
 									onChange('version', version?.value);
 								}}
 								placeholder="Choose a version..."
-								renderValue={() => {
-									return <VersionSelectItem option={version} />;
-								}}
-							>
-								{versionSelectionOpts?.map((option, index) => {
-									return (
-										<MenuItem key={index} value={option.value}>
-											<VersionSelectItem option={option} />
-										</MenuItem>
-									);
-								})}
-							</Select>
+								renderOption={(props, option) => (
+									<Box component="li" {...props}>
+										<VersionSelectItem option={option} />
+									</Box>
+								)}
+								renderInput={({ InputProps, ...params }) => (
+									<TextField
+										{...params}
+										InputProps={{
+											...InputProps,
+											name: 'version',
+											endAdornment: !!selectedOSVersion?.knownIssueList && (
+												<Tooltip title={selectedOSVersion.knownIssueList}>
+													<FontAwesomeIcon
+														icon={faTriangleExclamation}
+														color={theme.palette.warning.main}
+													/>
+												</Tooltip>
+											),
+										}}
+									/>
+								)}
+								disableClearable
+							/>
 						</Box>
 						{showAllVersionsToggle && (
 							<Box
@@ -523,36 +544,29 @@ const DeviceTypeItem: React.FC<{ deviceType: DeviceType }> = ({
 	);
 };
 
-export const VersionSelectItem = ({ option }: any) => {
+// TODO: We need a better way than just copying the styling. Consider creating a component to export
+export const VersionSelectItem = ({
+	option,
+}: {
+	option: {
+		title: string;
+		isRecommended?: boolean;
+		knownIssueList: string | null;
+	};
+}) => {
 	return (
-		<Tooltip title={option.knownIssueList ?? undefined}>
-			<Box
-				display="flex"
-				alignItems="center"
-				gap={2}
-				flexWrap="nowrap"
-				maxWidth="100%"
-			>
-				<Box>{option.title}</Box>
-				{!!option.line && (
-					<Chip label={option.line} color={lineMap[option.line]} />
-				)}
-				{!!option.isRecommended && (
-					<Chip
-						label="recommended"
-						sx={{
-							height: 20,
-							backgroundColor: '#CAFECD',
-						}}
-					/>
+		<Stack direction="column" flexWrap="wrap" maxWidth="100%" rowGap={1}>
+			<Typography noWrap maxWidth="100%" variant="titleSm">
+				{option.title}
+				{option.isRecommended && (
+					<Chip sx={{ ml: 1 }} color="green" label="recommended" />
 				)}
-				{!!option.knownIssueList && (
-					<Box alignItems="center" flex={1} display="contents">
-						<WarningAmberIcon color="warning" />
-						<Typography noWrap>{option.knownIssueList}</Typography>
-					</Box>
-				)}
-			</Box>
-		</Tooltip>
+			</Typography>
+			{!!option.knownIssueList && (
+				<Callout severity="warning" size="sm">
+					{option.knownIssueList}
+				</Callout>
+			)}
+		</Stack>
 	);
 };