Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider restricting network driver_opts to string values #18

Open
pipex opened this issue Nov 7, 2022 · 1 comment
Open

Consider restricting network driver_opts to string values #18

pipex opened this issue Nov 7, 2022 · 1 comment

Comments

@pipex
Copy link
Contributor

pipex commented Nov 7, 2022

While the docker-compose specification accepts both strings and numbers, using a number seems to be rejected on the engine with a JSON unmarshaling error

(HTTP code 400) unexpected - json: cannot unmarshal number into Go struct field NetworkCreateRequest.Options of type string

This after pushing this valid network configuration

networks:
  default:
    driver_opts:
      com.docker.network.driver.mtu: 1420

Leaving this as an issue for discussion

@jellyfish-bot
Copy link

[pipex] This has attached https://jel.ly.fish/cb692d35-d429-4120-acad-915644b94aee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants