Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace superseded functions #6

Closed
arisp99 opened this issue Nov 30, 2021 · 0 comments · Fixed by #11
Closed

Replace superseded functions #6

arisp99 opened this issue Nov 30, 2021 · 0 comments · Fixed by #11
Labels
maintenance 🛠️ code maintenance, clarity, styling, etc.
Milestone
1.0.0

Comments

@arisp99
Copy link
Member

arisp99 commented Nov 30, 2021

In some locations, we use superseded functions to accomplish tasks. These function calls should be replaced with their newer equivalents. A couple of examples where we use superseded functions are below:

coiaf/R/sensitivity.R

Line 254 in 857cb41

dplyr::select_if(function(x) dplyr::n_distinct(x) > 1)

coiaf/R/sensitivity.R

Line 461 in 857cb41

dplyr::select_if(function(x) dplyr::n_distinct(x) > 1)

@arisp99 arisp99 added the maintenance 🛠️ code maintenance, clarity, styling, etc. label Nov 30, 2021
@arisp99 arisp99 added this to the 1.0.0 milestone Nov 30, 2021
@arisp99 arisp99 mentioned this issue Dec 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance 🛠️ code maintenance, clarity, styling, etc.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Replace superseded functions bailey-lab/coiaf
1 participant
@arisp99