Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup message "is responding with HTTP status code NaN" #349

Closed
MikeMcC399 opened this issue Jan 31, 2023 · 5 comments
Closed

Startup message "is responding with HTTP status code NaN" #349

MikeMcC399 opened this issue Jan 31, 2023 · 5 comments
Labels

Comments

@MikeMcC399
Copy link

Bug report

Configuration

start-server-and-test 1.15.3
Ubuntu 22.04 and Node.js 18.13.0
Windows 11 and Node.js 18.13.0

Problem description

start-server-and-test

When running a script defined as:

start-server-and-test start-server http://localhost:8000 cypress:run

the following message is output:

1: starting server using command "npm run start-server"
and when url "[ 'http://localhost:8000' ]" is responding with HTTP status code NaN
running tests using command "npm run cypress:run"

This is a regression from version 1.14.0 where the message was
" ... is responding with HTTP status code 200"

i.e. 200 has been replaced by NaN.

Expected behavior

start-server-and-test v1.15.0 introduced the --expect parameter, however there is no statement in README: expected to say that this parameter is required, so if the default HTTP code is still 200 then the startup message should also list 200 and not NaN (Not a Number) if no --expect parameter is supplied.

@applesaucesome
Copy link

+1

1 similar comment
@mihailgaberov
Copy link

+1

@MikeMcC399
Copy link
Author

@bahmutov

Could you take a look at this cosmetic regression please?

@github-actions
Copy link

🎉 This issue has been resolved in version 1.15.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399
Copy link
Author

@bahmutov

Thank you! I've updated to this version and confirm that it is working fine again now.

1: starting server using command "npm run start-server"
and when url "[ 'http://localhost:8000' ]" is responding with HTTP status code 200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants