Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy on node 20 #9799

Merged
merged 2 commits into from
Dec 30, 2023
Merged

deploy on node 20 #9799

merged 2 commits into from
Dec 30, 2023

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Dec 10, 2023 •
edited
Loading

TODO: update branch protection rules when we merge

  • package lib tests and setup action have changed due to engine-strict true/false and needing to use npm 9 for the older versions
  • remove main-20, integration-20, services-20
  • add main-21, integration-21, services-21

Closes #9780

@chris48s chris48s added the operations Hosting, monitoring, and reliability for the production badge servers label Dec 10, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2023 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against 4b2b5c9

@github-actions GitHub Actions
Copy link
Contributor

🚀 Updated review app: https://pr-9799-badges-shields.fly.dev

@chris48s chris48s marked this pull request as ready for review December 10, 2023 19:24
@chris48s chris48s mentioned this pull request Dec 22, 2023
Merged
PyvesB
PyvesB approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-checked, I don't think you've missed anything :)

@chris48s chris48s added this pull request to the merge queue Dec 30, 2023
Merged via the queue into badges:master with commit 01de891 Dec 30, 2023
@chris48s chris48s deleted the node20 branch December 30, 2023 19:08
@chris48s
Copy link
Member Author

have updated the branch protection rules so we'll need to remember to update PRs opened before this so they run the right tests

@chris48s chris48s mentioned this pull request Jan 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
operations Hosting, monitoring, and reliability for the production badge servers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy on Node 20
2 participants
@chris48s @PyvesB