-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ansible] Add collection badge #8578
Conversation
Thank you for the PR. A few things:
|
📋 Description
🔗 Data
🎤 Motivation
For some reason the tests of some Gitlab service are failing, even though I used the
I copied this 1:1 from the Ansible Role service, where there are two additional services. Unfortunately, the data for these services are not (yet) exposed in the collections API. I'd propose to keep the base class around so that they can be added later on. Any thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your service tests are failing with
AssertionError: label mismatch: expected 'collection' to equal 'role'
You need to switch label: 'role'
to label: 'collection'
in your service tests. That will get the build passing.
I copied this 1:1 from the Ansible Role service, where there are two additional services. Unfortunately, the data for these services are not (yet) exposed in the collections API. I'd propose to keep the base class around so that they can be added later on. Any thoughts?
I think while we just have the one badge lets drop the base class and move fetch()
into AnsibleGalaxyCollectionName
. We can factor it out later if we add more badges in future.
4f06013
to
39c27ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work - thanks
Add a badge for Ansible collections, almost identical to those for Ansible roles.
Unfortuntately, the
/api/v2/collections
endpoint (as opposed to/api/v1/roles
) of Ansible Galaxy exposes neither download numbers nor quality scores, so there's only the name badge for now.