Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about how we handle extensions / customizations / extra parameters #145

Open
evert opened this issue Jul 18, 2024 · 0 comments
Open
Labels
question Further information is requested

Comments

@evert
Copy link
Collaborator

evert commented Jul 18, 2024

Servers adding parameters to requests and responses comes up a lot:

I'm also looking into the 'OAuth 2.0 for First-Party Applications' draft, which explicitly asks implementors to define custom errors and responses.

This has lead me to the question: Should a good OAuth2 client assume that it may be extended anywhere, or is it better to be strict (and if it's not too painful add some support for extra parameters).

I've been in camp #2 but providing small extension points everywhere is getting somewhat annoying. Maybe for a v3 version of this library it's better to remove all 'extraParams' arguments and instead serialize/deserialize anything that gets thrown at us.

I don't have a concrete answer to this yet, but I'm leaving this here as a potential entry for discussion. (feel free to participate if you have an opinion!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant