Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Move Container\Code to the addons folder #2

Closed
HermanRas opened this issue Oct 25, 2020 · 7 comments
Closed

Request to Move Container\Code to the addons folder #2

HermanRas opened this issue Oct 25, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@HermanRas
Copy link

Hi All,

SUMERY
the current location of this repo, is set to root folder instead of addons folder as per the documentation below:
https://docs.godotengine.org/en/stable/tutorials/plugins/editor/making_plugins.html

PROBLEM DESCRIPTION
Using this project from the Godot Asset Store replaces my game's README and add the transit to the top level of my game, instead of the addons folder where its expected

SOLUTION
Move project code to ./addons/transit
fix all the res://transit/ links to res://addons/transit
move readme into transit folder
move license into transit folder

image

@HermanRas
Copy link
Author

I am willing to do all the work and add a PULL request to your repo if that would be easier ?

@backwardspy backwardspy self-assigned this Oct 25, 2020
@backwardspy
Copy link
Owner

Thanks for the report, I will sort that out now.

@backwardspy backwardspy added the enhancement New feature or request label Oct 25, 2020
@HermanRas
Copy link
Author

HermanRas commented Oct 25, 2020 via email

@backwardspy
Copy link
Owner

I have moved transit into an addons folder like you suggested. Instead of moving the repo's README and such into its own folder, I have excluded them from the export archive as suggested here:
vnen/godot-tiled-importer#75
This means the repo still renders nicely in Github's UI, but no extraneous files are downloaded inside Godot itself.
I will write back & close this issue when the change has been accepted on the Godot Asset Library and I can confirm that it works as intended when installing from there.
Thanks again for the issue report!

@HermanRas
Copy link
Author

HermanRas commented Oct 25, 2020 via email

@backwardspy
Copy link
Owner

@HermanRas Transit 1.1 is live on the asset library and seems to be working nicely. Please give it another try and let me know what you think!

@HermanRas
Copy link
Author

working 100% on Git and on Godot Asset Library, a Huge Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants