Add node 8 support #148
Merged
Add node 8 support #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stefanpenner
force-pushed
the
node-8
branch
3 times, most recently
from
319cc20 to
1c26ed2
Compare
node-tests/addon-test.js
Outdated
| @@ -691,7 +691,7 @@ describe('ember-cli-babel', function() { | |||
| expect(pluginRequired).to.be.true; | |||
| }); | |||
|
|
|||
| it('returns false when targets do not require plugin', function() { | |||
| it.only('returns false when targets do not require plugin', function() { | |||
There was a problem hiding this comment.
@stefanpenner sorry about that... was (foolishly) not even considering anyone else using isPluginRequired when we made string version target changes (originally targeted for 2.x) :(
There was a problem hiding this comment.
@existentialism not a problem. Just a surprise, glad it was easy to work around.
siva-sundar
pushed a commit
to siva-sundar/ember-cli-babel
that referenced
this pull request
Feb 11, 2021
Deserialize nested arrays in the parallel API correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #147