-
-
Notifications
You must be signed in to change notification settings - Fork 119
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix compatibility with Ember 3.27+ when using compileModules: false.
When using libraries that leverage `compileModules: false` (commonly used to transpile `vendor` tree's without introducing a wrapping AMD module) on Ember 3.27+ (where we don't transpile away the various `@ember/*` modules any longer) we would leave the debug module imports alone during transpilation. This resulted (in most cases) in there being a bare unwrapped and untranspiled `import` statement in `vendor.js`. This would then fail **everything**. This changes the logic slightly to continue transpiling to globals mode when `compileModules: false` is set. Note: this is really just a stop gap solution (and will still cause deprecations to be emitted, addons that are currently leveraging `compileModules: false` _will_ need to make some changes for Ember 4.0 (where a global `window.Ember` will not be ambiently available).
- Loading branch information
Showing
2 changed files
with
63 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters