Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Un-popped push #404

Closed
ghost opened this issue Mar 9, 2017 · 1 comment · Fixed by #405
Closed

Un-popped push #404

ghost opened this issue Mar 9, 2017 · 1 comment · Fixed by #405
Labels

Comments

@ghost
Copy link

ghost commented Mar 9, 2017

In the src/plugins/flow.js override of parseMaybeAssign, there is a call to this.state.context.push(), followed by a block of code, followed by a call to this.state.context.pop().
But there is an early return inside that block of code, meaning that the push may not be popped. This looks incorrect, but naively fixing it by adding a pop() before the early return breaks some tests.

@hzoo
Copy link
Member

hzoo commented Mar 9, 2017

Hey @andy-ms! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant