Require blocks around single block-scope declaration #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single block scoped declaration under an if/else requires a block statement. The block statement here if removed is a syntax error and this removal of block statement is valid only for vars and not for let or const. We could essentially go ahead and remove the left hand side of the variable declaration, but that is the job of the DeadCode elimination plugin. Here, we just correct the mistake and let simplify generate correct output when used in isolation. Let dead code take care of removal of block and the left hand side of the declaration
|
Will this work with |
|
|
|
It is in strict mode though. Will add block for function anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The var declaration removal should be done in DCE instead of simplify. This is necessary as simplify as a standalone plugin should not produce syntax errors.