Test on Node.js 8 #882
Merged
Test on Node.js 8 #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
reviewed
Nov 10, 2020
.github/workflows/ci.yml
Outdated
| - name: Build babel-loader | ||
| run: yarn run build | ||
| env: | ||
| YARN_NODE_LINKER: node-modules |
There was a problem hiding this comment.
The env YARN_NODE_LINKER can be moved to the job scope: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#env
nicolo-ribaudo
force-pushed
the
test-node-6.9
branch
from
fadf7fc to
69bbe09
Compare
nicolo-ribaudo
commented
Nov 10, 2020
| @@ -7,7 +7,7 @@ | |||
| ], | |||
| "main": "lib/index.js", | |||
| "engines": { | |||
| "node": ">= 6.9" | |||
| "node": ">= 8.9" | |||
There was a problem hiding this comment.
This was a breaking change in #822, but no one complained 🤷
We can make it work if someone opens an issue.
Also, AVA doesn't work on Node.js 8 so I'm running a smaller single test.
There was a problem hiding this comment.
schema-utils, introduced in that PR, uses some syntax that is not supported on Node.js 6.
JLHwung
approved these changes
Nov 10, 2020
existentialism
approved these changes
Nov 10, 2020
11 tasks
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel-loader/package.json
Line 10 in a4d17c0