Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EPIG #259

Closed
Dref360 opened this issue May 8, 2023 · 8 comments
Closed

Add EPIG #259

Dref360 opened this issue May 8, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@Dref360
Copy link
Member

Dref360 commented May 8, 2023

This could unlock some new opportunities for us, particularly for Transformers.

Github
Paper

@Dref360 Dref360 added the enhancement New feature or request label May 8, 2023
@reeshipaul
Copy link
Contributor

I would like to work on this implementation

@Dref360
Copy link
Member Author

Dref360 commented May 14, 2023

Awesome!
Thank you very much :)

We would be happy to help you as well if needed

@Dref360
Copy link
Member Author

Dref360 commented May 18, 2023

I'll read the full paper over the weekend. I would know more about how we could work on this.

@Dref360
Copy link
Member Author

Dref360 commented May 23, 2023

After reading the paper and looking at the codebase, I think the main issue is that we can't easily supply all targets to the heuristic.

We could directly provide the active dataset to the heuristic and then iterate over it when we call EPIG(active_set=active_set).get_scores(predictions).

What do you think? I don't think this is the perfect solution so I can be easily persuaded to go another route.

@reeshipaul
Copy link
Contributor

I have read the paper, will read it in depth once more till the weekend. Can we schedule a meet over the weekend to discuss about the implementation?

@Dref360
Copy link
Member Author

Dref360 commented May 24, 2023

Sounds good!

My calendar is available on Calendly: https://calendly.com/baal-org/30min?month=2023-05

If these don't work for you let me know and we will figure something out :) We can chat on Slack as well.

@reeshipaul
Copy link
Contributor

@Dref360 can you please send out an invite for slack to reeshipaul35@gmail.com

@reeshipaul reeshipaul mentioned this issue Jul 19, 2023
3 tasks
@Dref360
Copy link
Member Author

Dref360 commented May 27, 2024

Fixed in #270 thank you @reeshipaul for the PR!

@Dref360 Dref360 closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants