Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add SourceLink support to NuGet package for debugging #308

Closed
LaXiS96 opened this issue Aug 31, 2022 · 4 comments
Closed

Comments

@LaXiS96
Copy link

LaXiS96 commented Aug 31, 2022

Hello,
first of all, thanks for this exceptional library!

It's common nowadays for NuGet packages to include symbols to allow seamless debugging into library source code, without having to replace package references etc.

I don't have any prior experience with NuGet packaging but something similar has been done for sprache/Sprache#174.
If anybody has experience with NuGets and is willing to implement this feature, please do so; otherwise I might try it myself and hope for the best.

Thank you

@b3b00
Copy link
Owner

b3b00 commented Aug 31, 2022

Hello @LaXiS96,

great idea. Would you consider try it and submit a pull request ? I think that the sprache PR is a great starting point.

@b3b00
Copy link
Owner

b3b00 commented Aug 31, 2022

Hello @LaXiS96 , I 've just published v2.9.0.6 nuget with symbols.
Could you try and tell me if sourcelink works ok for you ?

@b3b00
Copy link
Owner

b3b00 commented Sep 2, 2022

@LaXiS96 nuget 2.9.0.6 was not ok. I've fixed it and 2.9.0.7 is ok (tested in visual studio pro 2019)
I have still some work to do to fix the github workflow that fails but still produces and publish a nuget.

I am closing the issue.

Feel free to reopen if something is not ok on your side

@b3b00 b3b00 closed this as completed Sep 2, 2022
@LaXiS96
Copy link
Author

LaXiS96 commented Sep 2, 2022

Hi,
debugging now seems to be working OK on VS 2022 Pro.

Thank you for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants