Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low quality HTML and CSS #19

Open
naomiaz opened this issue Sep 26, 2023 · 2 comments
Open

Low quality HTML and CSS #19

naomiaz opened this issue Sep 26, 2023 · 2 comments

Comments

@naomiaz
Copy link

naomiaz commented Sep 26, 2023

I'm trying to adjust the branding of the templates for a client, but it is an extreme mess. The HTML contains too many generic classes, and using ID selectors in CSS is bad practice in general because of specificity issues.
Will this get fixed in the future?

@rovangju
Copy link

Agreed - I'm also confused as to why there's a boat load of styles that are imported by gulp, but we don't get access to those source files?

@gopal-amlekar
Copy link

I agree, it is a nightmare to fix / rewrite the styles. I used prettier formatter in VSCode and it then shows all the styles (gulp generated) in a readable format. I then inspect each element, find out its class and literally overwrite it in my own css with all the specificity.
Besides, it uses Bootstrap 3. I tried to use BS 5 but it breaks the styles. BS 4 works but with some changes to the template.
Another scary stuff is the Handlebar generated JS scripts. It makes it very difficult to understand certain behaviours like the form validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants