Fixed catalog and collection clone logic to avoid dupe root link #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clone methods on catalog and collection create a new version of the STAC object and set the links on the clone manually. The problem with this is that the constructor of the Catalog sets the root link to itself - this is because a root link is required on a catalog, so a new instance should always link to itself as the root. This PR adds some additional logic to ensure that there is only one root link set in the clone. If the Catalog's root link is set to itself, then the root link of the clone will be set to the clone.
Fixes #63