Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old color scheme? #123

Open
1 of 3 tasks
sobolevn opened this issue Sep 3, 2021 · 16 comments
Open
1 of 3 tasks

Old color scheme? #123

sobolevn opened this issue Sep 3, 2021 · 16 comments

Comments

@sobolevn
Copy link

sobolevn commented Sep 3, 2021

Hi! Thanks a lot for the awesome theme. I am using it for like 4 years now.
Dotfiles: https://github.com/sobolevn/dotfiles#vs-code

My main question is: after a recent update (1-2 days ago) my color scheme has changed a lot. And I don't like it, sorry 🙂

Let's discuss new problems I see:
Снимок экрана 2021-09-03 в 22 06 44
From top to bottom:

  • New green highlight of (), which was not used before. It now has too many "attention" attracted to it
  • Purple function arguments and constants, it just does not fit the color scheme
  • New color of message panel on hover is too light

Related dempfi#250

Is there something you can suggest here?
Or should I just fork it?

@dempfi
Copy link
Member

dempfi commented Sep 3, 2021

4 years is really a lot of time. I'm happy to hear people loving and using ayu ❤️

Thank for detailed report, it seems all of this can be addressed:

  • I'll look into toning down a notch bracket highlight. I can see how that can be annoying;
  • Purple was used for arguments for a couple years now. What has changed tho is that I enabled semantic highlighting which causes this arguments color to be used in places of usage too. For now, I can recommend to disable semantic highlighting
  • Notifications color prominence is linked to list selection color and since I aimed to make list selections brighter and more readable, that also got applied to notifications; I'll check if it's possible to reduce contrast of those notifications;

@dempfi
Copy link
Member

dempfi commented Sep 3, 2021

@emlautarom1 when you say

Text used to be yellow, and now is pink-ish.

Do you mean the false constants or something else?

@dempfi
Copy link
Member

dempfi commented Sep 4, 2021

I've toned down bracket highlights in v1.0.2

@xuhaibahmad
Copy link

xuhaibahmad commented Sep 4, 2021

TYSM for this theme. I use Ayu Dark for pretty much every IDE I use for the past many years.

Please reconsider these recent changes, especially the purple accent. I haven't tried other languages with them yet, but currently, my Dart code looks like this (v1.0.2):

image

@dempfi
Copy link
Member

dempfi commented Sep 4, 2021

Wow, that's really terrible @xuhaibahmad. Can you share a piece of code for me to test on?

@xuhaibahmad
Copy link

xuhaibahmad commented Sep 4, 2021

Sure! I think the semantic highlighting will have this issue with languages/frameworks that uses object nesting such as Flutter, Kotlin, SwiftUI, and JetPack Compose, etc.

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';

class ClickableMaskView extends StatelessWidget {
  const ClickableMaskView({
    Key? key,
    required this.rippleColor,
    required this.onClick,
    required this.padding,
    required this.radius,
  }) : super(key: key);

  final Color rippleColor;
  final Function onClick;
  final double padding;
  final double radius;

  @override
  Widget build(BuildContext context) {
    return Positioned.fill(
      child: Container(
        padding: EdgeInsets.symmetric(horizontal: padding),
        child: Material(
          color: rippleColor,
          child: InkWell(
            onTap: () => onClick.call(),
            borderRadius: BorderRadius.circular(radius),
          ),
        ),
      ),
    );
  }
}

@sobolevn
Copy link
Author

sobolevn commented Sep 4, 2021

The same with python named arguments:
Снимок экрана 2021-09-04 в 11 24 13

setup(
    name="django-stubs",
    version="1.8.0",
    description="Mypy stubs for Django",
    long_description=readme,
    long_description_content_type="text/markdown",
    license="MIT",
    url="https://github.com/typeddjango/django-stubs",
    py_modules=[],
    python_requires=">=3.6",
    install_requires=dependencies,
)

@sobolevn
Copy link
Author

sobolevn commented Sep 4, 2021

One more problem: new search is very low on contrast. It is hard to see the highlighted text.
Снимок экрана 2021-09-04 в 12 42 32

I really hope that it will be possible to restore things back to normal soon 🙂

@dempfi
Copy link
Member

dempfi commented Sep 4, 2021

Can you guys give a go to this version ayu-1.0.2.vsix.zip

@sobolevn
Copy link
Author

sobolevn commented Sep 4, 2021

@dempfi thanks a lot! Brackets and keyword arguments are back to normal! 👍
However, function arguments, search results, and constants are still purple for some reason 😞

Снимок экрана 2021-09-04 в 22 19 04

@xuhaibahmad
Copy link

Much better! Though the use of purple for parameters means a lot of my code is still that color. Also, noticed that parameters are not colored when I disable semantic highlighting.

Semantic Highlighting ON:

image

Semantic Highlighting OFF:

image

@sobolevn
Copy link
Author

sobolevn commented Sep 4, 2021

Ok, I found the solution for my problem. Sharing with other people:

You can use older versions of extensions in vscode.
https://stackoverflow.com/questions/42626065/vs-code-rollback-extension-install-specific-extension-version/53755378

Demo (and the final result, code color is back to normal):

2021-09-04.22.33.57.mov

@naivelogic
Copy link

i had to rollback to v0.20.2. love ayu tho!!

@exitlol
Copy link

exitlol commented Sep 6, 2021

Hope I am not late for the party.
@dempfi I work with Angular/TS. And the yellow accent colors are still purple, the type associations are the same color as the Interface

screens from v.1.0.0 and up:
image
image
I think this is the worst part:
image

screens from same code before v.1.0.0:
image
image
image

settings.json:

{
    "workbench.colorTheme": "Ayu Dark Bordered",
    "editor.fontLigatures": true,
    "editor.fontFamily": "Fira Code",
    "workbench.iconTheme": "material-icon-theme",
    "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe",
    "editor.tabSize": 2,
    "editor.formatOnSave": true,
    "typescript.updateImportsOnFileMove.enabled": "always",
    "editor.codeActionsOnSave": {
        "source.fixAll.tslint": true
    },
    "javascript.updateImportsOnFileMove.enabled": "always",
    "extensions.autoUpdate": false,
    "gitlens.gitCommands.closeOnFocusOut": true,
    "editor.suggestSelection": "first",
    "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
    "bracket-pair-colorizer-2.colors": [
        "Gold",
        "Orchid",
        "LightSkyBlue"
    ],
    "editor.renameOnType": true,
    "workbench.startupEditor": "newUntitledFile",
    "angular.experimental-ivy": true,
    "terminal.integrated.defaultProfile.windows": "Git Bash"
}

If you need snippets or anything else let me know.

@emlautarom1
Copy link

@emlautarom1 when you say

Text used to be yellow, and now is pink-ish.

Do you mean the false constants or something else?

Yes, exactly that. Notice that the constant 2 is also pink-ish

@exitlol
Copy link

exitlol commented Sep 16, 2021

Any updates in this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants