Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Should ConfigFile be a dependency of ES? #9

Open
waldnercharles opened this issue Sep 24, 2015 · 1 comment
Open

Discussion: Should ConfigFile be a dependency of ES? #9

waldnercharles opened this issue Sep 24, 2015 · 1 comment

Comments

@waldnercharles
Copy link

It feels strange to me that ConfigFile is included as a dependency for ES. What if someone doesn't like the syntax for ConfigFile? It might be nice to provide an interface for serializing and deserializing, but not force an end user to to have ConfigFile if they don't intend on using it.

@ayebear
Copy link
Owner

ayebear commented Sep 24, 2015

This is only used for the EntityPrototypeLoader, so it would be easy to make as an optional module. But yes, I'll make it use a generic interface that allows you to add support for other formats. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants