From 8e2802786bc6e0de566275fcf66de26c89aaec99 Mon Sep 17 00:00:00 2001 From: Benjamin DENEUX Date: Wed, 29 Mar 2023 10:54:55 +0200 Subject: [PATCH] fix(lint): handle error --- x/logic/keeper/msg_server.go | 3 ++- x/mint/keeper/genesis.go | 6 +++++- x/mint/keeper/msg_server.go | 3 ++- x/mint/migrations/v2/migrations.go | 4 ++-- x/mint/types/codec.go | 4 ++-- 5 files changed, 13 insertions(+), 7 deletions(-) diff --git a/x/logic/keeper/msg_server.go b/x/logic/keeper/msg_server.go index ea0c9f7f..56256fa4 100644 --- a/x/logic/keeper/msg_server.go +++ b/x/logic/keeper/msg_server.go @@ -27,7 +27,8 @@ var _ types.MsgServiceServer = msgServer{} // account. func (ms msgServer) UpdateParams(goCtx context.Context, req *types.MsgUpdateParams) (*types.MsgUpdateParamsResponse, error) { if ms.authority.String() != req.Authority { - return nil, errorsmod.Wrapf(govtypes.ErrInvalidSigner, "invalid authority; expected %s, got %s", ms.authority.String(), req.Authority) + return nil, errorsmod.Wrapf(govtypes.ErrInvalidSigner, + "invalid authority; expected %s, got %s", ms.authority.String(), req.Authority) } ctx := sdk.UnwrapSDKContext(goCtx) diff --git a/x/mint/keeper/genesis.go b/x/mint/keeper/genesis.go index d9c0b76d..261e3278 100644 --- a/x/mint/keeper/genesis.go +++ b/x/mint/keeper/genesis.go @@ -1,6 +1,7 @@ package keeper import ( + errorsmod "cosmossdk.io/errors" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/okp4/okp4d/x/mint/types" ) @@ -8,7 +9,10 @@ import ( // InitGenesis new mint genesis. func (k Keeper) InitGenesis(ctx sdk.Context, ak types.AccountKeeper, data *types.GenesisState) { k.SetMinter(ctx, data.Minter) - k.SetParams(ctx, data.Params) + err := k.SetParams(ctx, data.Params) + if err != nil { + panic(errorsmod.Wrapf(err, "error setting params")) + } ak.GetModuleAccount(ctx, types.ModuleName) } diff --git a/x/mint/keeper/msg_server.go b/x/mint/keeper/msg_server.go index 60e438c6..d64e8c2e 100644 --- a/x/mint/keeper/msg_server.go +++ b/x/mint/keeper/msg_server.go @@ -27,7 +27,8 @@ var _ types.MsgServiceServer = msgServer{} // account. func (ms msgServer) UpdateParams(goCtx context.Context, req *types.MsgUpdateParams) (*types.MsgUpdateParamsResponse, error) { if ms.authority.String() != req.Authority { - return nil, errorsmod.Wrapf(govtypes.ErrInvalidSigner, "invalid authority; expected %s, got %s", ms.authority.String(), req.Authority) + return nil, errorsmod.Wrapf(govtypes.ErrInvalidSigner, + "invalid authority; expected %s, got %s", ms.authority.String(), req.Authority) } ctx := sdk.UnwrapSDKContext(goCtx) diff --git a/x/mint/migrations/v2/migrations.go b/x/mint/migrations/v2/migrations.go index 8528bac9..fa618907 100644 --- a/x/mint/migrations/v2/migrations.go +++ b/x/mint/migrations/v2/migrations.go @@ -29,8 +29,8 @@ func MigrateStore(ctx sdk.Context, store := ctx.KVStore(storeKey) var params types.Params - legacySubspace.WithKeyTable(types.ParamKeyTable()). - GetParamSet(ctx, ¶ms) + legacySubspace.WithKeyTable(types.ParamKeyTable()). //nolint:staticcheck + GetParamSet(ctx, ¶ms) if err := params.Validate(); err != nil { return err diff --git a/x/mint/types/codec.go b/x/mint/types/codec.go index e0b02f50..7ffb2837 100644 --- a/x/mint/types/codec.go +++ b/x/mint/types/codec.go @@ -29,7 +29,7 @@ const ( updateParamsName = "okp4/mint/MsgUpdateParams" ) -// RegisterInterfaces register implementations +// RegisterInterfaces register implementations. func RegisterInterfaces(registry codectypes.InterfaceRegistry) { registry.RegisterImplementations( (*sdk.Msg)(nil), @@ -39,7 +39,7 @@ func RegisterInterfaces(registry codectypes.InterfaceRegistry) { msgservice.RegisterMsgServiceDesc(registry, &_MsgService_serviceDesc) } -// RegisterLegacyAminoCodec required for EIP-712 +// RegisterLegacyAminoCodec required for EIP-712. func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) { cdc.RegisterConcrete(&MsgUpdateParams{}, updateParamsName, nil) }