From ff76cc41d0aa76a19531e8ecbfcab59405ccfe15 Mon Sep 17 00:00:00 2001 From: Wing Lian Date: Mon, 20 Jan 2025 15:07:03 -0500 Subject: [PATCH] address pr feedback --- src/axolotl/core/trainer_builder.py | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/axolotl/core/trainer_builder.py b/src/axolotl/core/trainer_builder.py index 645b99f444..1271c874c1 100755 --- a/src/axolotl/core/trainer_builder.py +++ b/src/axolotl/core/trainer_builder.py @@ -491,14 +491,13 @@ def create_optimizer_grouped_parameters(self, opt_model, optimizer_kwargs): ): params["embeddings"][name] = param elif name in decay_parameters: - if lr_groups_lookup and any( - group_modules in name for group_modules in lr_groups_lookup - ): - lr_group_module = [ - group_modules - for group_modules in lr_groups_lookup - if group_modules in name - ][0] + lr_group_modules = [ + group_modules + for group_modules in lr_groups_lookup + if group_modules in name + ] + if lr_groups_lookup and any(lr_group_modules): + lr_group_module = lr_group_modules[0] group_name = lr_groups_lookup[lr_group_module] params[f"to_weight_decay_{group_name}"][name] = param else: