From 473ea02370210012e231e6e2f39af5cf8fbe8f22 Mon Sep 17 00:00:00 2001
From: Islam Shehata <islam@axiom.co>
Date: Thu, 4 Apr 2024 12:38:09 +0200
Subject: [PATCH] checkout backfill

---
 backfill.py | 47 ++++++++++++++---------------------------------
 1 file changed, 14 insertions(+), 33 deletions(-)

diff --git a/backfill.py b/backfill.py
index aca6ace..bd18223 100644
--- a/backfill.py
+++ b/backfill.py
@@ -19,26 +19,16 @@
 
 def get_log_groups(token=None):
     if token is None:
-        if log_group_prefix != "":
-            return cloudwatch_logs_client.describe_log_groups(
-                logGroupNamePrefix=log_group_prefix, limit=log_groups_return_limit
-            )
-        else:
-            return cloudwatch_logs_client.describe_log_groups(
-                limit=log_groups_return_limit
-            )
+        return cloudwatch_logs_client.describe_log_groups(
+            logGroupNamePrefix=log_group_prefix, limit=log_groups_return_limit
+        )
     else:
-        if log_group_prefix != "":
-            return cloudwatch_logs_client.describe_log_groups(
-                logGroupNamePrefix=log_group_prefix,
-                nextToken=token,
-                limit=log_groups_return_limit,
-            )
-        else:
-            return cloudwatch_logs_client.describe_log_groups(
-                nextToken=token,
-                limit=log_groups_return_limit,
-            )
+        return cloudwatch_logs_client.describe_log_groups(
+            logGroupNamePrefix=log_group_prefix,
+            nextToken=token,
+            limit=log_groups_return_limit,
+        )
+
 
 def delete_subscription_filter(log_group_arn, lambda_arn):
     try:
@@ -111,12 +101,9 @@ def log_groups(token=None):
             except Exception:
                 pass
 
-            try:
-                create_subscription_filter(
-                    group["arn"], axiom_cloudwatch_lambda_ingester_arn
-                )
-            except cloudwatch_logs_client.exceptions.LimitExceededException as error:
-                print(error)
+            create_subscription_filter(
+                group["arn"], axiom_cloudwatch_lambda_ingester_arn
+            )
 
         if token is None:
             return
@@ -131,13 +118,7 @@ def log_groups(token=None):
         log_groups()
     except Exception as e:
         responseData["success"] = "False"
-        if event["ResponseURL"]:
-            cfnresponse.send(event, context, cfnresponse.FAILED, responseData)
-        else:
-            raise e
+        cfnresponse.send(event, context, cfnresponse.FAILED, responseData)
 
     responseData["success"] = "True"
-    if event["ResponseURL"]:
-        cfnresponse.send(event, context, cfnresponse.SUCCESS, responseData)
-    else:
-        return 'ok'
+    cfnresponse.send(event, context, cfnresponse.SUCCESS, responseData)