Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webcomponents randomly not rendered #27

Closed
6 tasks
AndyOGo opened this issue Dec 4, 2017 · 7 comments
Closed
6 tasks

Webcomponents randomly not rendered #27

AndyOGo opened this issue Dec 4, 2017 · 7 comments
Assignees
Labels

Comments

@AndyOGo
Copy link

AndyOGo commented Dec 4, 2017

Somehow importing our custom Web Components into Chrome by HTML Imports randomly triggers a weird bug in Chrome, which results in rendering the component in one place but not in another.

Switching to pure ESnext based import's seems to make Firefox some troubles #25 :

TypeError: window.customElements is undefined

This bug isn't reasonable and needs to be 1000% fixed.

Todo

  • Make 1000% sure to understand the cause of this bug - no guessing. Ideally easily observable by failing test.
  • order of components lifecycle has to be deterministic
  • Report this bug to Chrome's issue tracker and link it's issue here
  • find reliable cross-browser, testable workaround / bugfix
  • document above solution, and communicate it to everyone involved
  • make sure that every single web component can be reliable rendered in all supported browsers
@LucaMele
Copy link
Contributor

LucaMele commented Dec 5, 2017

Recommendation is to use only Custom Element from the Web-Components and not HTML Imports, therefore this issue can be a nice to have

@AndyOGo
Copy link
Author

AndyOGo commented Dec 5, 2017

I agree with avoiding HTML imports.

@AndyOGo
Copy link
Author

AndyOGo commented Dec 6, 2017

It seems that lifecycle execution (constructor, connectedCallback, attributeChangedCallback, disconnectedCallback, etc.) of hierarchical/nested components is NOT deterministic.
I face this weird behaivior at #34 regarding contextual scope #31

Example:

<axa-parent>
  <axa-child></axa-child>
</axa-parent>

Expected:

`axa-parent` constructor
`axa-child` constructor
`axa-child` connectedCallback
`axa-parent` connectedCallback

Observed (parent after child):

`axa-child` constructor
`axa-child` connectedCallback
`axa-parent` constructor
`axa-parent` connectedCallback

@AndyOGo AndyOGo self-assigned this Dec 6, 2017
@LucaMele
Copy link
Contributor

LucaMele commented Dec 7, 2017

Exactly, like proposed specs describe it.

@LucaMele
Copy link
Contributor

LucaMele commented Dec 7, 2017

As HTML imports are not reccomended, we keep this issue as very low prio

@LucaMele LucaMele added Low-prio and removed Bug labels Dec 7, 2017
@AndyOGo AndyOGo added this to the React Integration milestone Apr 17, 2018
@LucaMele
Copy link
Contributor

LucaMele commented Oct 8, 2018

i think is fixed.. feel free to reopen in case is not

@LucaMele LucaMele closed this as completed Oct 8, 2018
@AndyOGo
Copy link
Author

AndyOGo commented Oct 8, 2018

I don't know if it's fixed 🤔
Though I haven't seen it a while and we aren't using HTML imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants