Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variants keys not replaced #8

Closed
aphofstede opened this issue Apr 18, 2019 · 2 comments
Closed

Variants keys not replaced #8

aphofstede opened this issue Apr 18, 2019 · 2 comments

Comments

@aphofstede
Copy link

The variants config object is reconstructed, but the keys still use the old name, e.g.

    variants: {
        textStyle: ['responsive', 'hover', 'focus', 'group-hover'],
    }

Expected:

    variants: {
        fontStyle: ['responsive', 'hover', 'focus', 'group-hover'],
    }
@aphofstede
Copy link
Author

From the release notes upgrade guide:
"Here is a complete list of the sections that been split into multiple sections:

Old New
flexbox flexDirection, flexWrap, alignItems, alignSelf, justifyContent, alignContent, flex, flexGrow, flexShrink
lists listStylePosition, listStyleType
position position, inset
textStyle fontStyle, fontSmoothing, textDecoration, textTransform
whitespace whitespace, wordBreak

Note that in some cases (position, whitespace) the original section still exists, while in others (flexbox, textStyle), the original section has been completely removed."

@abdumu abdumu closed this as completed in 554fcc3 Apr 19, 2019
@abdumu
Copy link
Member

abdumu commented Apr 19, 2019

Thanks for reporting this.
I'm pretty sure it's fixed now, but if it's still there please comment to reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants