Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow users to set status for mitigations and threats. Close #61. Close #126 #131

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

jessieweiyi
Copy link
Contributor

Issue #, if available:

#61
#126

Description of changes:

This PR is to

  1. Allow users to set status for mitigations and threats
  2. Update Threat Model Report to show status of mitigations and threats
  3. Add mitigation status and threat status into Workspace Insight Dashboard

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jessieweiyi jessieweiyi requested a review from dboyd13 August 28, 2024 06:02
Copy link
Contributor

@dboyd13 dboyd13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon reflection, 'Abandoned' for Mitigation carries a negative connotation - and that it is simply left behind or neglected. I propose we change to 'Will not action' which carries slightly less negative connotation in my opinion, and is clear that it's a decision. Details inline.

Copy link
Contributor

@dboyd13 dboyd13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dboyd13 dboyd13 merged commit f430b90 into main Aug 30, 2024
2 checks passed
@dboyd13 dboyd13 deleted the feat/status branch August 30, 2024 01:21
Copy link

🎉 This PR is included in version 1.0.57 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants