Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplification in scikit-learn based estimators #704

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

mseeger
Copy link
Collaborator

@mseeger mseeger commented Jun 1, 2023

Small changes. Move wrapper code into one file, which is in line with all other wrapper code. Also, simplify imports.
Needed before BO developer tutorial PR goes out.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mseeger mseeger requested a review from jgolebiowski June 1, 2023 19:56
@mseeger mseeger requested review from wesk and removed request for wesk June 2, 2023 19:48
@mseeger mseeger force-pushed the refactor_sklearn branch from 4494d50 to 26f3183 Compare June 6, 2023 13:42
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 89.47% and no project coverage change.

Comparison is base (594b03b) 65.13% compared to head (26f3183) 65.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   65.13%   65.13%           
=======================================
  Files         421      421           
  Lines       28417    28415    -2     
=======================================
  Hits        18508    18508           
+ Misses       9909     9907    -2     
Impacted Files Coverage Δ
...edulers/searchers/bayesopt/models/sklearn_model.py 87.09% <85.71%> (ø)
.../schedulers/searchers/bayesopt/sklearn/__init__.py 100.00% <100.00%> (ø)
...rs/searchers/sklearn/sklearn_surrogate_searcher.py 75.00% <100.00%> (ø)
tst/schedulers/bayesopt/test_sklearn_surrogate.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@jgolebiowski jgolebiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, having both in the same file is probably a good idea.

@mseeger mseeger merged commit 9f3fd10 into main Jun 6, 2023
@mseeger mseeger deleted the refactor_sklearn branch June 6, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants