Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Random seed range in benchmarking #656

Merged
merged 2 commits into from
May 8, 2023
Merged

fix: Random seed range in benchmarking #656

merged 2 commits into from
May 8, 2023

Conversation

mseeger
Copy link
Collaborator

@mseeger mseeger commented May 8, 2023


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mseeger mseeger requested a review from wesk May 8, 2023 07:45
wesk
wesk previously approved these changes May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (f6b8a3c) 65.12% compared to head (c16a092) 65.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   65.12%   65.09%   -0.04%     
==========================================
  Files         374      374              
  Lines       27124    27123       -1     
==========================================
- Hits        17664    17655       -9     
- Misses       9460     9468       +8     
Impacted Files Coverage Δ
benchmarking/commons/utils.py 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wesk wesk self-requested a review May 8, 2023 08:11
@mseeger mseeger merged commit 45af582 into main May 8, 2023
@mseeger mseeger deleted the smallfix branch May 8, 2023 08:14
@mseeger mseeger added the fix label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants