chore: only validate PR titles; specify list of valid prefixes #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesk
force-pushed
the
2023-05-02-relax-validation
branch
from
bc12c64 to
f37fa3c
Compare
wesk
force-pushed
the
2023-05-02-relax-validation
branch
from
f37fa3c to
7aa4eed
Compare
wesk
force-pushed
the
2023-05-02-relax-validation
branch
from
7aa4eed to
1a0226b
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
+ Coverage 65.12% 65.13% +0.01%
==========================================
Files 372 372
Lines 27085 27085
==========================================
+ Hits 17640 17643 +3
+ Misses 9445 9442 -3 ☔ View full report in Codecov by Sentry. |
mseeger
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: CI was failing for #644, because the PR title followed the ConventionalCommits convention, but the commit title itself did not. The app by default requires that the PR title and at least one commit follows the convention. We do not actually need the commit itself to follow the convention, since when merging, GitHub will by default suggest that the PR title is used in the commit message.
Fix: configure the app to only validate the PR title itself, to make it easier for people to start contributing to Syne Tune.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.