Add config definitions for aws protocol tests #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
reviewed
Feb 4, 2021
rcoh
reviewed
Feb 4, 2021
|
|
||
| /// Config settings that can be set in the AWS config file. | ||
| structure FileConfig { | ||
| access_key_id: String, |
There was a problem hiding this comment.
I'm not positive I would model these—by modeling this explicitly, we'd need to upgrade Smithy for any new features that wanted to be tested (which is maybe OK?)
There was a problem hiding this comment.
These are for the protocol tests here, you'd need to update this package anyway to add more tests to it. In any event, adding a line here is never gonna be the bottleneck.
kstich
approved these changes
Feb 4, 2021
This updates the model of the config files to a representation of how they're actually parsed, namely as a map of profile to config.
kstich
approved these changes
Feb 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds aws config definitions intended to be used alongside: #702
It's not an exhaustive listing, but includes most of what should be needed for protocol tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.