Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export aws_types::SdkConfig in aws_config #1457

Merged
merged 5 commits into from
Jul 6, 2022
Merged

Conversation

calavera
Copy link
Contributor

@calavera calavera commented Jun 11, 2022

Motivation and Context

This way people that want to access that structure don't have to add aws_types.

Description

Add SdkConfig to the line that re-exports structs from aws_types.

Testing

I built to code to see if it compiled.

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@calavera calavera requested a review from a team as a code owner June 11, 2022 19:51
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcoh
Copy link
Collaborator

rcoh commented Jun 13, 2022

actually, please run cargo fmt then CI will pass

This way people that want to access that structure don't have to add aws_types.

Signed-off-by: David Calavera <david.calavera@gmail.com>
@calavera
Copy link
Contributor Author

Rebased with main, and formatted.

@rcoh rcoh enabled auto-merge (squash) June 13, 2022 14:13
@rcoh rcoh disabled auto-merge June 13, 2022 14:13
@rcoh
Copy link
Collaborator

rcoh commented Jun 13, 2022

oh actually do you mind adding a quick changelog entry? Other folks will probably want to know this exists so they can update their code

@calavera
Copy link
Contributor Author

I've added a new entry to the changelog.

@rcoh rcoh enabled auto-merge (squash) June 13, 2022 15:14
@rcoh rcoh merged commit b1d50b5 into smithy-lang:main Jul 6, 2022
@calavera calavera deleted the patch-1 branch July 6, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants