Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to set HTTP Connectors in Configs #1225

Closed
Velfi opened this issue Feb 25, 2022 · 4 comments
Closed

Allow users to set HTTP Connectors in Configs #1225

Velfi opened this issue Feb 25, 2022 · 4 comments
Assignees
@Velfi
Labels
breaking-change This will require a breaking change sdk sdk-ga
Milestone
SDK GA

Comments

@Velfi
Copy link
Contributor

Velfi commented Feb 25, 2022

Refactor our current network stack to allow users to set HTTP Connectors in Service Configs and Shared Configs.

Then, update Service Client creation to use this connector instead of creating a connector from defaults based on the currently enabled features.

This is in support of the "How we should use features" RFC.
@Velfi Velfi self-assigned this Feb 25, 2022
@Velfi Velfi mentioned this issue Feb 25, 2022
Merged
2 tasks
@Velfi Velfi moved this to In Progress in AWS Rust SDK Public Roadmap Mar 14, 2022
@Velfi Velfi moved this from In Progress to Researching in AWS Rust SDK Public Roadmap Mar 28, 2022
@jdisanti
Copy link
Collaborator

The connector customization needs to play into network calling credential providers (e.g., IMDS, HTTP token, etc) provider initialization as well: awslabs/aws-sdk-rust#579

@jdisanti jdisanti added this to the SDK GA milestone Sep 30, 2022
@jdisanti jdisanti added breaking-change This will require a breaking change sdk labels Sep 30, 2022
@jdisanti jdisanti mentioned this issue Oct 13, 2022
Closed
@jdisanti
Copy link
Collaborator

This would probably be implemented along side #960

@Velfi Velfi moved this to In Progress in AWS Rust SDK Public Roadmap Oct 27, 2022
@Velfi Velfi self-assigned this Oct 27, 2022
@Velfi Velfi mentioned this issue Oct 28, 2022
Merged
1 task
@Velfi
Copy link
Contributor Author

Velfi commented Oct 28, 2022

This is partly implemented by #1918

@Velfi Velfi mentioned this issue Oct 31, 2022
Closed
@Velfi Velfi moved this from In Progress to Pending Release in AWS Rust SDK Public Roadmap Nov 14, 2022
@jdisanti
Copy link
Collaborator

This was included in release-2022-12-14.

Repository owner moved this from Pending Release to Done in AWS Rust SDK Public Roadmap Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Velfi Velfi

Labels
breaking-change This will require a breaking change sdk sdk-ga
Projects
None yet
Milestone
SDK GA
Development

No branches or pull requests
2 participants
@jdisanti @Velfi