Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate NuGet symbol and source packages #243

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

christophercurrie
Copy link
Contributor

Similar to Java source jars, these packages can be published to NuGet to aid debugging by consumers.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... Would like to get @costleya to have a quick look as well, though.

@RomainMuller RomainMuller added the language/dotnet Related to .NET bindings (C#, F#, ...) label Sep 25, 2018
@costleya
Copy link
Contributor

I'm mostly ok with this, but I need to do some small changes to the publishing script to support pushing the symbols to https://nuget.smbsrc.net/.

@RomainMuller
Copy link
Contributor

@costleya but am I safe to merge the PR now? Or should I wait until you've prepared the publishing script updates?

@eladb
Copy link
Contributor

eladb commented Oct 10, 2018

@costleya ping

@RomainMuller
Copy link
Contributor

I have a conflict-free version of this branch, and submitted a PR on our publishing script to hopefully correctly publish the symbol packages to the right location.

@eladb
Copy link
Contributor

eladb commented Nov 18, 2018

@costleya what should we do with this? Can you pick this up please?

@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
@christophercurrie christophercurrie requested a review from a team as a code owner January 29, 2019 10:20
@RomainMuller RomainMuller merged commit aafd405 into aws:master Jan 29, 2019
RomainMuller added a commit that referenced this pull request Feb 4, 2019
### Bug Fixes
* remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350)
* **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341)
* **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401))
* **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345)

### Features
* **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c))
* Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
@RomainMuller RomainMuller mentioned this pull request Feb 4, 2019
RomainMuller added a commit that referenced this pull request Feb 4, 2019
### Bug Fixes
* remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350)
* **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341)
* **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401))
* **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345)

### Features
* **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c))
* Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. language/dotnet Related to .NET bindings (C#, F#, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants