fix: sitewise source time series module #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehbria
force-pushed
the
fix-iot-app-kit
branch
from
6843327 to
a6a6669
Compare
NorbertNader
previously approved these changes
Feb 28, 2022
boweihan
reviewed
Feb 28, 2022
| date: Date; | ||
| onError: ErrorCallback; | ||
| onSuccess: OnSuccessCallback; | ||
| }): Promise<void> { |
There was a problem hiding this comment.
is Promise the correct return signature?
There was a problem hiding this comment.
it resolves when the entire request is done. It gives you a way to know, and wait for it to be done, without wrapped it with a promise and doing a bunch of work to get the same end result
diehbria
force-pushed
the
fix-iot-app-kit
branch
2 times, most recently
from
e485ca9 to
e4bebad
Compare
gareth-amazon
previously approved these changes
Feb 28, 2022
| }, | ||
| ], | ||
| }), | ||
| ]} | ||
| /> | ||
| </div> | ||
| </div> | ||
| resolution:{' '} |
There was a problem hiding this comment.
Why remove the resolution controls in the demo?
boweihan
previously approved these changes
Feb 28, 2022
NorbertNader
previously approved these changes
Feb 28, 2022
diehbria
dismissed stale reviews from NorbertNader, boweihan, and gareth-amazon
via
b5ae8a6
diehbria
force-pushed
the
fix-iot-app-kit
branch
from
e4bebad to
b5ae8a6
Compare
gareth-amazon
approved these changes
Feb 28, 2022
sheilaXu
pushed a commit
that referenced
this pull request
Sep 23, 2022
TheEvilDev
pushed a commit
that referenced
this pull request
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
requestInformationsLegal
This project is available under the Apache 2.0 License.