-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor iotsitewise source structure #67
Conversation
457e5e8
to
912ee9d
Compare
@@ -0,0 +1,72 @@ | |||
// import { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to rewrite this.
85f8fad
to
d93dd19
Compare
import { ErrorDetails } from '../common/types'; | ||
|
||
export type TimeSeriesData = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feedback is that you are trying to re-use this type for both tables and charts. If you require additional data for a table you should make that part of the interface:
export type TimeSeriesTableData = {
dataStreams: {id: string, stream: DataStream}[];
viewport: MinimalViewPortConfig;
};
export type TimeSeriesTableData = {
dataStreams: DataStream[];
viewport: MinimalViewPortConfig;
};
maybe it makes sense to always have the IDs?
- bring back iot-table - expose toId from source-iotsitewise - move timeseries module to source-iotsitewise - move asset module to source-iotsitewise - remove sitewise explicit typining from components except resource explorer - remove sitewise-resource-explorer - refactor API so you initialize queries, instead of app kit instance
d93dd19
to
ee843d4
Compare
- bring back iot-table - expose toId from source-iotsitewise - move timeseries module to source-iotsitewise - move asset module to source-iotsitewise - remove sitewise explicit typining from components except resource explorer - remove sitewise-resource-explorer - refactor API so you initialize queries, instead of app kit instance Co-authored-by: Norbert Nader <Norbert.Nader@gmail.com>
Overview
widgetId
optional, automatically assign a uuid if not presenttime-series
andasset
work to thesource-iotsitewise
packagewhich removes the concept of a global iot app kit instance with credentials passed in.
iot-table
with support for table columns, utilizing exposed{ toId } from '@iot-app-kit/source-iotsitewise'
Remaining issues
composeProviders
Legal
This project is available under the Apache 2.0 License.