feat(composer): Implement data overlay container #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheilaXu
force-pushed
the
data-overlay-m1-container
branch
from
5a476a6 to
82d0ebb
Compare
| @@ -16,7 +16,7 @@ const useCallbackWhenNotPanning = (callback, deps, acceptableDriftDistance = 1) | |||
| const lastPointerDownLocation = useRef<[number, number] | null>(null); | |||
|
|
|||
| const onPointerUp = useCallback( | |||
| (e: ThreeEvent<MouseEvent>) => { | |||
| (e: ThreeEvent<MouseEvent> | PointerEvent) => { | |||
There was a problem hiding this comment.
Not sure if it is necessary right now but should we use ThreeEvent<PointerEvent> vs ThreeEvent<MouseEvent>? Not your change just thinking out loud
jwills-jdubs
approved these changes
Feb 17, 2023
sheilaXu
force-pushed
the
data-overlay-m1-container
branch
from
82d0ebb to
fe72d13
Compare
mumanity
approved these changes
Feb 22, 2023
...ages/scene-composer/src/components/three-fiber/DataOverlayComponent/DataOverlayContainer.tsx
Outdated
Show resolved
Hide resolved
...ages/scene-composer/src/components/three-fiber/DataOverlayComponent/DataOverlayComponent.tsx
Outdated
Show resolved
Hide resolved
sheilaXu
force-pushed
the
data-overlay-m1-container
branch
from
fe72d13 to
b35830f
Compare
mumanity
approved these changes
Feb 22, 2023
sheilaXu
added a commit
that referenced
this pull request
Feb 22, 2023
sheilaXu
added a commit
that referenced
this pull request
Mar 1, 2023
sheilaXu
added a commit
that referenced
this pull request
Mar 27, 2023
feat(composer): Implement data overlay container (#595) feat(composer): data overlay editor & render markdown feat(composer): add overlay panel config editor feat(composer): data binding variable support for data overlay feat(composer): implement add overlay from menu
sheilaXu
added a commit
that referenced
this pull request
Mar 27, 2023
feat(composer): Implement data overlay container (#595) feat(composer): data overlay editor & render markdown feat(composer): add overlay panel config editor feat(composer): data binding variable support for data overlay feat(composer): implement add overlay from menu
Closed
sheilaXu
added a commit
that referenced
this pull request
Mar 27, 2023
feat(composer): Implement data overlay container (#595) feat(composer): data overlay editor & render markdown feat(composer): add overlay panel config editor feat(composer): data binding variable support for data overlay feat(composer): implement add overlay from menu
sheilaXu
added a commit
that referenced
this pull request
Mar 27, 2023
feat(composer): Implement data overlay container (#595) feat(composer): data overlay editor & render markdown feat(composer): add overlay panel config editor feat(composer): data binding variable support for data overlay feat(composer): implement add overlay from menu
Closed
This was referenced Apr 4, 2023
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implement the container of data overlay component with simple text content rendering
Verifying Changes
Scene Composer
For
scene-composerpackage changes specifically, you can preview the component in the published storybook artifact. To do this, wait for thePublish Storybookaction to complete below.To run the storybook build locally, you need a local static web server:
Then open the website http://localhost:8080 to run the doc site.
Legal
This project is available under the Apache 2.0 License.