feat: bind gestures to components #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NorbertNader
requested review from
fpauer,
boweihan,
diehbria and
gareth-amazon
gareth-amazon
approved these changes
Jan 11, 2022
sheilaXu
pushed a commit
that referenced
this pull request
Sep 23, 2022
Co-authored-by: David Wu <daviwu@amazon.com>
TheEvilDev
pushed a commit
that referenced
this pull request
Nov 2, 2022
Co-authored-by: Norbert Nader <nnader@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Bind gestures to components. Now data will be requested for the selected viewport when panning or zooming out and correct resolution will be determined for viewport range when zooming.
Tests
It does not make much sense to write unit tests for this, since they would basically just check that when we dispatch a custom event
dateRangeChangewith certain details - start, end, lastUpdatedBy -subscribeToDataStreamsupdatecallback gets called with the updatedviewportin therequestobject. Instead we should backfill with integration tests for more "customer centric" tests once we onboard to cypress.Legal
This project is available under the Apache 2.0 License.