feat(aws-fargate-secretsmanager): Create new construct #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickychetta
requested review from
biffgaut,
hayesry,
mobri2a and
emcfins
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
previously approved these changes
Apr 27, 2022
| * Adds environment variables to the container with the ARN and Name of the Secrets Manager secret | ||
| * Add permissions to the container IAM role allowing it to publish to the Secrets Manager secret | ||
|
|
||
| ### Amazon Secrets Manager Secret |
There was a problem hiding this comment.
Compare these with aws-lambda-secretmanager
- This should mention random name and random value
- Explore whether the KMS comment adds value - I don't think we have to do anything with KMS when using secret manager. It's possible the right thing to do is remove that comment from the lambda-secretmanager README file.
There was a problem hiding this comment.
KMS comment does not add value
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
requested changes
May 3, 2022
source/patterns/@aws-solutions-constructs/aws-fargate-secretsmanager/lib/index.ts
Outdated
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-secretsmanager/lib/index.ts
Outdated
Show resolved
Hide resolved
...rns/@aws-solutions-constructs/aws-fargate-secretsmanager/test/fargate-secretsmanager.test.ts
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #669 , if available:
Description of changes:
Create a construct that links a Fargate Service to AWS Secrets Manager
Should create a VPC or accept an existing VPC
Should create a Fargate Service or accept an existing service
Should create a new secret object or accept an existing secret
Should grant the service IAM permission to read/write from the secret
Should set up environment variables in the service that identify the secret in the construct code so the container can read/write from the secret
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
fixes #669